Refine OffscreenCanvas PushFrame flow [chromium/src : main]

0 views

Skip to first unread message

Vasiliy Telezhnikov (Gerrit)

unread,

9:43 AM (6 hours ago) 9:43 AM

to Colin Blundell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, kainin...@chromium.org

Attention needed from Colin Blundell

Vasiliy Telezhnikov added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Vasiliy Telezhnikov . resolved

Please, take a look.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Colin Blundell (Gerrit)

unread,

10:33 AM (5 hours ago) 10:33 AM

to Vasiliy Telezhnikov, Colin Blundell, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cwalle...@chromium.org, kainin...@chromium.org

Attention needed from Vasiliy Telezhnikov

Colin Blundell voted and added 2 comments

Votes added by Colin Blundell

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Colin Blundell . resolved

Thanks!

File third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc

Line 602, Patchset 1 (Latest): context_->GetResourceForPushFrame(would_call_push_frame);

Colin Blundell . unresolved

optional nit that you can ignore if this code is going to go away in the near-immediate: I think that `should_call_push_frame` would be more clear than `would_call_push_frame` throughout.