Remove long-launched VideoWakeLockOptimisationHiddenMuted feature. [chromium/src : main]

0 views
Skip to first unread message

Dale Curtis (Gerrit)

unread,
Mar 20, 2023, 3:06:50 PMMar 20
to blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, poscia...@chromium.org, Yoav Weiss, chromium...@chromium.org, Raphael Kubo Da Costa

Attention is currently required from: Yoav Weiss.

Patch set 2:Auto-Submit +1Commit-Queue +1

View Change

    To view, visit change 4354797. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab5b96dc19e3005d26d7ce68b984a4992d10f2dd
    Gerrit-Change-Number: 4354797
    Gerrit-PatchSet: 2
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
    Gerrit-Attention: Yoav Weiss <yoav...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Mar 2023 19:06:41 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Yoav Weiss (Gerrit)

    unread,
    Mar 21, 2023, 6:00:10 AMMar 21
    to Dale Curtis, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, poscia...@chromium.org, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo Da Costa

    Attention is currently required from: Dale Curtis.

    Patch set 2:Code-Review +1Commit-Queue +2

    View Change

    1 comment:

    To view, visit change 4354797. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab5b96dc19e3005d26d7ce68b984a4992d10f2dd
    Gerrit-Change-Number: 4354797
    Gerrit-PatchSet: 2
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
    Gerrit-Attention: Dale Curtis <dalec...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Mar 2023 10:00:04 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 21, 2023, 6:02:05 AMMar 21
    to Dale Curtis, blink-rev...@chromium.org, blink-...@chromium.org, feature-me...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org, poscia...@chromium.org, Yoav Weiss, chromium...@chromium.org, Raphael Kubo Da Costa

    Chromium LUCI CQ submitted this change.

    View Change

    Approvals: Dale Curtis: Send CL to CQ automatically after approval Yoav Weiss: Looks good to me; Commit
    Remove long-launched VideoWakeLockOptimisationHiddenMuted feature.

    Visible wake lock restrictions launched in M84, so remove the
    removes the stale RuntimeFeature entry for it.

    R=yoavweiss

    Bug: 1340424
    Change-Id: Iab5b96dc19e3005d26d7ce68b984a4992d10f2dd
    Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4354797
    Reviewed-by: Yoav Weiss <yoav...@chromium.org>
    Commit-Queue: Yoav Weiss <yoav...@chromium.org>
    Auto-Submit: Dale Curtis <dalec...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1119837}
    ---
    M content/child/runtime_features.cc
    M media/base/media_switches.cc
    M media/base/media_switches.h
    M third_party/blink/renderer/core/html/media/video_wake_lock.cc
    M third_party/blink/renderer/platform/runtime_enabled_features.json5
    5 files changed, 6 insertions(+), 28 deletions(-)


    To view, visit change 4354797. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iab5b96dc19e3005d26d7ce68b984a4992d10f2dd
    Gerrit-Change-Number: 4354797
    Gerrit-PatchSet: 3
    Gerrit-Owner: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Dale Curtis <dalec...@chromium.org>
    Gerrit-Reviewer: Yoav Weiss <yoav...@chromium.org>
    Gerrit-CC: Raphael Kubo Da Costa <raphael.ku...@intel.com>
    Gerrit-MessageType: merged
    Reply all
    Reply to author
    Forward
    0 new messages