[Autofill] Select field suggestion in popover [chromium/src : main]

0 views
Skip to first unread message

Lukasz Wojtach (Gerrit)

unread,
Mar 19, 2026, 11:13:59 AMMar 19
to Julia Sobiech, Josef Raska, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar, Josef Raska and Julia Sobiech

Lukasz Wojtach added 1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Lukasz Wojtach . resolved

A PoC using @jar...@chromium.org idea to fix b/40057398#78 .
Since it hardcodes font style it still may look bad in some scenarios. Idea is to inherit font size (and alignment?) while pinning the font itself.

Since we use popover - site using autofill is safe from resizing, when autofill shows suggestion.

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
  • Josef Raska
  • Julia Sobiech
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I192d349bbd77487f566570bab7fcd98bd3daa0b2
Gerrit-Change-Number: 7680396
Gerrit-PatchSet: 4
Gerrit-Owner: Lukasz Wojtach <lwoj...@google.com>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Josef Raska <josef...@google.com>
Gerrit-Reviewer: Julia Sobiech <jsob...@google.com>
Gerrit-Attention: Julia Sobiech <jsob...@google.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Josef Raska <josef...@google.com>
Gerrit-Comment-Date: Thu, 19 Mar 2026 15:13:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Josef Raska (Gerrit)

unread,
Mar 19, 2026, 12:25:03 PMMar 19
to Lukasz Wojtach, Julia Sobiech, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Julia Sobiech and Lukasz Wojtach

Josef Raska added 1 comment

File third_party/blink/renderer/core/html/resources/html.css
Line 2269, Patchset 1 (Latest):select::-internal-select-autofill-preview[popover] {
Josef Raska . unresolved

To understand: The font is fixed, but we don't impact the dimensions of html elements, meaning the only UX impact is different font, but actually consistent font with the rest of Autofill, correct?

Open in Gerrit

Related details

Attention is currently required from:
  • Julia Sobiech
  • Lukasz Wojtach
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I9a3d94c215a64e4da235e9986333c9cb37a853a2
    Gerrit-Change-Number: 7679263
    Gerrit-PatchSet: 1
    Gerrit-Owner: Lukasz Wojtach <lwoj...@google.com>
    Gerrit-Reviewer: Josef Raska <josef...@google.com>
    Gerrit-Reviewer: Julia Sobiech <jsob...@google.com>
    Gerrit-Attention: Julia Sobiech <jsob...@google.com>
    Gerrit-Attention: Lukasz Wojtach <lwoj...@google.com>
    Gerrit-Comment-Date: Thu, 19 Mar 2026 16:24:49 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lukasz Wojtach (Gerrit)

    unread,
    Apr 17, 2026, 3:29:17 AM (13 days ago) Apr 17
    to Julia Sobiech, Josef Raska, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Josef Raska and Julia Sobiech

    Lukasz Wojtach added 1 comment

    File third_party/blink/renderer/core/html/resources/html.css
    Line 2269, Patchset 1:select::-internal-select-autofill-preview[popover] {
    Josef Raska . resolved

    To understand: The font is fixed, but we don't impact the dimensions of html elements, meaning the only UX impact is different font, but actually consistent font with the rest of Autofill, correct?

    Lukasz Wojtach

    Exactly - text is rendered on the invisible overlay / popup. It will not cause the site to resize to accomodate it.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Josef Raska
    • Julia Sobiech
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I9a3d94c215a64e4da235e9986333c9cb37a853a2
      Gerrit-Change-Number: 7679263
      Gerrit-PatchSet: 3
      Gerrit-Owner: Lukasz Wojtach <lwoj...@google.com>
      Gerrit-Reviewer: Josef Raska <josef...@google.com>
      Gerrit-Reviewer: Julia Sobiech <jsob...@google.com>
      Gerrit-Attention: Julia Sobiech <jsob...@google.com>
      Gerrit-Attention: Josef Raska <josef...@google.com>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 07:28:55 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Josef Raska <josef...@google.com>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages