Add exceptions for the corner cases of submit.respondWith() [4/N] [chromium/src : main]
0 views
Skip to first unread message
Mason Freed (Gerrit)
Jan 23, 2026, 6:55:21 PMJan 23
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Mason Freed voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 26, 2026, 3:59:57 AMJan 26
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
Anders Hartvoll Ruud voted and added 1 comment![]( "Open in Gerrit")
Votes added by Anders Hartvoll Ruud
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/script_tools/model_context_test.cc
Line 427, Patchset 2 (Latest):
"no error";Anders Hartvoll Ruud . unresolved
What does a literal string do here?
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 26, 2026, 4:25:21 AMJan 26
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/script_tools/model_context_test.cc
Line 427, Patchset 2 (Latest):
"no error";Anders Hartvoll Ruud . resolved
What does a literal string do here?
Anders Hartvoll Ruud
Oh, I see.
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 27, 2026, 11:44:07 AMJan 27
to Mason Freed, Ben Greenstein, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Add exceptions for the corner cases of submit.respondWith() [4/N]
This CL mainly adds a few more tests for corner cases, and implements
exception throwing for calling respondWith() a few unsupported ways.
Change-Id: Id06418284f6f672b0c505978f3cbb2c0ff8249ff
Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
Auto-Submit: Mason Freed <mas...@chromium.org>
Commit-Queue: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1575273}
Files:
- M third_party/blink/renderer/core/html/forms/submit_event.cc
- M third_party/blink/renderer/core/script_tools/model_context_test.cc
Change size: M
Delta: 2 files changed, 214 insertions(+), 6 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Anders Hartvoll Ruud
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Tizito Oscar (Gerrit)
Jan 27, 2026, 12:58:20 PMJan 27
to Mason Freed, Chromium LUCI CQ, Ben Greenstein, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Tizito Oscar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 5 (Latest):
Tizito Oscar . resolved
DMT CARTS FOR SALE | BUY DMT CARTS ONLINE | BUY DMT VAPE PENS | DMT CARTRIDGES | BEST DMT CARTS | DMT VAPE PENS FOR SALE ONLINE | DEADHEAD CHEMIST DMT CARTS FOR SALE | DMT VAPE PENS FOR SALE https://t.me/psychedelictrippystore427
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages