Add exceptions for the corner cases of submit.respondWith() [4/N] [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Jan 23, 2026, 6:55:21 PMJan 23
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud

Mason Freed voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id06418284f6f672b0c505978f3cbb2c0ff8249ff
Gerrit-Change-Number: 7514727
Gerrit-PatchSet: 1
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Fri, 23 Jan 2026 23:55:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Jan 26, 2026, 3:59:57 AMJan 26
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed

Anders Hartvoll Ruud voted and added 1 comment

Votes added by Anders Hartvoll Ruud

Code-Review+1

1 comment

File third_party/blink/renderer/core/script_tools/model_context_test.cc
Line 427, Patchset 2 (Latest): "no error";
Anders Hartvoll Ruud . unresolved

What does a literal string do here?

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id06418284f6f672b0c505978f3cbb2c0ff8249ff
    Gerrit-Change-Number: 7514727
    Gerrit-PatchSet: 2
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Mon, 26 Jan 2026 08:59:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Anders Hartvoll Ruud (Gerrit)

    unread,
    Jan 26, 2026, 4:25:21 AMJan 26
    to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
    Attention needed from Mason Freed

    Anders Hartvoll Ruud added 1 comment

    File third_party/blink/renderer/core/script_tools/model_context_test.cc
    Anders Hartvoll Ruud . resolved

    What does a literal string do here?

    Anders Hartvoll Ruud

    Oh, I see.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Mason Freed
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id06418284f6f672b0c505978f3cbb2c0ff8249ff
      Gerrit-Change-Number: 7514727
      Gerrit-PatchSet: 2
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Mon, 26 Jan 2026 09:25:03 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Anders Hartvoll Ruud <and...@chromium.org>
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jan 27, 2026, 11:44:07 AMJan 27
      to Mason Freed, Ben Greenstein, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Chromium LUCI CQ submitted the change

      Unreviewed changes

      2 is the latest approved patch-set.
      No files were changed between the latest approved patch-set and the submitted one.

      Change information

      Commit message:
      Add exceptions for the corner cases of submit.respondWith() [4/N]

      This CL mainly adds a few more tests for corner cases, and implements
      exception throwing for calling respondWith() a few unsupported ways.
      Change-Id: Id06418284f6f672b0c505978f3cbb2c0ff8249ff
      Reviewed-by: Anders Hartvoll Ruud <and...@chromium.org>
      Auto-Submit: Mason Freed <mas...@chromium.org>
      Commit-Queue: Mason Freed <mas...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1575273}
      Files:
      • M third_party/blink/renderer/core/html/forms/submit_event.cc
      • M third_party/blink/renderer/core/script_tools/model_context_test.cc
      Change size: M
      Delta: 2 files changed, 214 insertions(+), 6 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Anders Hartvoll Ruud
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id06418284f6f672b0c505978f3cbb2c0ff8249ff
      Gerrit-Change-Number: 7514727
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Ben Greenstein <be...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      open
      diffy
      satisfied_requirement

      Tizito Oscar (Gerrit)

      unread,
      Jan 27, 2026, 12:58:20 PMJan 27
      to Mason Freed, Chromium LUCI CQ, Ben Greenstein, Anders Hartvoll Ruud, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

      Tizito Oscar added 1 comment

      Patchset-level comments
      File-level comment, Patchset 5 (Latest):
      Tizito Oscar . resolved

      DMT CARTS FOR SALE | BUY DMT CARTS ONLINE | BUY DMT VAPE PENS | DMT CARTRIDGES | BEST DMT CARTS | DMT VAPE PENS FOR SALE ONLINE | DEADHEAD CHEMIST DMT CARTS FOR SALE | DMT VAPE PENS FOR SALE https://t.me/psychedelictrippystore427

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Id06418284f6f672b0c505978f3cbb2c0ff8249ff
      Gerrit-Change-Number: 7514727
      Gerrit-PatchSet: 5
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
      Gerrit-Reviewer: Ben Greenstein <be...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-CC: Tizito Oscar <tizito...@gmail.com>
      Gerrit-Comment-Date: Tue, 27 Jan 2026 17:58:07 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages