Report WebDX features for PIs and <template for> [chromium/src : main]
0 views
Skip to first unread message
Ian Clelland (Gerrit)
Jun 19, 2026, 10:32:03 AM (6 days ago) Jun 19
to Noam Rosenthal, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Noam Rosenthal
Ian Clelland added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Ian Clelland . unresolved
Should DRAFT_TemplateFor be emitted somewhere in this CL? I only see PI being counted
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Jun 23, 2026, 10:30:47 AM (2 days ago) Jun 23
to Chromium LUCI CQ, Ian Clelland, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Ian Clelland
Noam Rosenthal added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Ian Clelland . unresolved
Should DRAFT_TemplateFor be emitted somewhere in this CL? I only see PI being counted
Noam Rosenthal
It's mapped to kHTMLPatching which is already emitted in third_party/blink/common/use_counter/webdx_feature_maps.cc
Related details
Attention is currently required from:
- Ian Clelland
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ian Clelland (Gerrit)
Jun 23, 2026, 10:41:52 AM (2 days ago) Jun 23
to Noam Rosenthal, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Noam Rosenthal
Ian Clelland voted and added 1 comment![]( "Open in Gerrit")
Votes added by Ian Clelland
| Code-Review | +1 |
1 comment
Patchset-level comments
Ian Clelland . resolved
Noam RosenthalShould DRAFT_TemplateFor be emitted somewhere in this CL? I only see PI being counted
It's mapped to kHTMLPatching which is already emitted in third_party/blink/common/use_counter/webdx_feature_maps.cc
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kentaro Hara (Gerrit)
Jun 23, 2026, 10:53:41 AM (2 days ago) Jun 23
to Noam Rosenthal, Ian Clelland, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Noam Rosenthal
Kentaro Hara voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Noam Rosenthal
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Noam Rosenthal (Gerrit)
Jun 24, 2026, 2:33:58 PM (20 hours ago) Jun 24
to Kentaro Hara, Ian Clelland, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Noam Rosenthal voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2026, 3:56:58 PM (18 hours ago) Jun 24
to Noam Rosenthal, Kentaro Hara, Ian Clelland, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Report WebDX features for PIs and <template for>
Bug: 481087638
Change-Id: I9d5eb00adebf8b051c9bf35ea8f558456ccf6392
Reviewed-by: Ian Clelland <icle...@chromium.org>
Commit-Queue: Noam Rosenthal <nrose...@google.com>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1651916}
Files:
- M third_party/blink/common/use_counter/webdx_feature_maps.cc
- M third_party/blink/public/mojom/use_counter/metrics/webdx_feature.mojom
- M third_party/blink/renderer/core/html/parser/html_construction_site.cc
- M tools/metrics/histograms/metadata/blink/enums.xml
Change size: XS
Delta: 4 files changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ian Clelland, +1 by Kentaro Hara
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages