Improve HTMLMediaElement opaque handling for non-media content [chromium/src : main]
0 views
Skip to first unread message
Dale Curtis (Gerrit)
Apr 20, 2026, 1:08:57 PM (2 days ago) Apr 20
to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Ted (Chromium) Meyer
Dale Curtis voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Ted (Chromium) Meyer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Ted (Chromium) Meyer (Gerrit)
Apr 21, 2026, 3:46:26 PM (16 hours ago) Apr 21
to Dale Curtis, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Attention needed from Dale Curtis
Ted (Chromium) Meyer voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Dale Curtis
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dale Curtis (Gerrit)
Apr 21, 2026, 3:47:43 PM (16 hours ago) Apr 21
to Ted (Chromium) Meyer, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Dale Curtis voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2026, 6:43:22 PM (13 hours ago) Apr 21
to Dale Curtis, Ted (Chromium) Meyer, chromium...@chromium.org, srirama chandra sekhar, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Improve HTMLMediaElement opaque handling for non-media content
This makes two changes to how opaque handling is done:
* MSE content is never considered opaque since its data comes from
the page.
* SRC content uses the actual network state instead of the preload
attribute to determine loading.
I verified the test cases in https://crbug.com/40580490 don't
reproduce after these changes.
Fixed: 502371717
Change-Id: Ica576163c07131efcf61c5ebf3963d924aeab3c3
Reviewed-by: Ted (Chromium) Meyer <tmath...@chromium.org>
Commit-Queue: Dale Curtis <dalec...@chromium.org>
Auto-Submit: Dale Curtis <dalec...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1618509}
Files:
- M third_party/blink/renderer/core/html/media/html_media_element.cc
- M third_party/blink/renderer/core/html/media/html_media_element.h
- M third_party/blink/renderer/core/html/media/html_media_element_test.cc
Change size: M
Delta: 3 files changed, 80 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Ted (Chromium) Meyer
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages