[webmcp] Make FillFormControls transactional [chromium/src : main]
0 views
Skip to first unread message
Anders Hartvoll Ruud (Gerrit)
Jan 22, 2026, 10:16:33 AMJan 22
to Mason Freed, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Mason Freed
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Anders Hartvoll Ruud . resolved
Does this make sense? It seems bad to return a failure when we potentially did modify things.
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Jan 23, 2026, 1:44:17 PMJan 23
to Anders Hartvoll Ruud, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud
Mason Freed voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Code-Review | +1 |
2 comments
Patchset-level comments
Mason Freed . resolved
Looks good!
File third_party/blink/renderer/core/html/forms/html_form_element.cc
Line 192, Patchset 1 (Latest):
transactions;Mason Freed . unresolved
"transactions" is a bit funny. Maybe just `controls_to_fill` or something?
Related details
Attention is currently required from:
- Anders Hartvoll Ruud
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 24, 2026, 12:53:51 AMJan 24
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/forms/html_form_element.cc
"transactions" is a bit funny. Maybe just `controls_to_fill` or something?
Anders Hartvoll Ruud
Done.
Avoided this terminology except in the high-level description in the commit message.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Anders Hartvoll Ruud (Gerrit)
Jan 24, 2026, 1:37:22 AMJan 24
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Anders Hartvoll Ruud voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 24, 2026, 8:48:06 AMJan 24
to Anders Hartvoll Ruud, Mason Freed, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/html/forms/html_form_element.cc
Insertions: 5, Deletions: 5.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
[webmcp] Make FillFormControls transactional
Currently, it's possible for FillFormControls to return "false"
(failure), but still modify the form control states. This is assumed
to be undesirable behavior, and therefore this CL makes FillWebMCPData
transactional: We now validate the input first, and then "commit"
those changes as a whole once we're sure it is valid.
FillWebMCPData's capability of returning a bool is currently unused;
I've removed it for now, since any validation step needs to happen
separately in a transactional model.
Bug: 475992364
Change-Id: I8a8c18e043efe76d7adecb6c0ccc02e354b3388d
Commit-Queue: Anders Hartvoll Ruud <and...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1574160}
Files:
- M third_party/blink/renderer/core/html/forms/html_form_control_element.cc
- M third_party/blink/renderer/core/html/forms/html_form_control_element.h
- M third_party/blink/renderer/core/html/forms/html_form_element.cc
- M third_party/blink/renderer/core/html/forms/html_form_element.h
- M third_party/blink/renderer/core/html/forms/html_form_mcp_tool_test.cc
- M third_party/blink/renderer/core/html/forms/html_input_element.cc
- M third_party/blink/renderer/core/html/forms/html_input_element.h
- M third_party/blink/renderer/core/html/forms/html_select_element.cc
- M third_party/blink/renderer/core/html/forms/html_select_element.h
Change size: M
Delta: 9 files changed, 61 insertions(+), 16 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mason Freed
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages