[mathml] Improve parsing of negative dimensions for mspace/mpadded [chromium/src : main]
Frédéric Wang (Gerrit)
Attention is currently required from: Ian Kilpatrick.
Frédéric Wang would like Ian Kilpatrick to review this change.
[mathml] Improve parsing of negative dimensions for mspace/mpadded
A CSSPrimitiveValue::ValueRange parameter is added to the
ParseMathLength/AddMathLengthToComputedStyle functions and is used to
prevent negative values for some attributes of the mspace/mpadded at
parsing time. This fixes some assertion failures during layout.
Bug: 1421195
Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
---
M third_party/blink/renderer/core/css/parser/css_parser.cc
M third_party/blink/renderer/core/css/parser/css_parser.h
M third_party/blink/renderer/core/mathml/mathml_element.cc
M third_party/blink/renderer/core/mathml/mathml_element.h
M third_party/blink/renderer/core/mathml/mathml_padded_element.cc
M third_party/blink/renderer/core/mathml/mathml_space_element.cc
A third_party/blink/web_tests/external/wpt/mathml/crashtests/mspace-mpadded-negative-dimensions.html
7 files changed, 52 insertions(+), 19 deletions(-)
To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.
Frédéric Wang (Gerrit)
Attention is currently required from: Ian Kilpatrick.
Blink W3C Test Autoroller (Gerrit)
Attention is currently required from: Ian Kilpatrick.
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/39161.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Ian Kilpatrick (Gerrit)
Attention is currently required from: Frédéric Wang.
Patch set 2:Code-Review +1
1 comment:
Patchset:
lgtm - Thanks for this.
To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.
Frédéric Wang (Gerrit)
Attention is currently required from: Frédéric Wang.
Patch set 2:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
[mathml] Improve parsing of negative dimensions for mspace/mpadded
A CSSPrimitiveValue::ValueRange parameter is added to the
ParseMathLength/AddMathLengthToComputedStyle functions and is used to
prevent negative values for some attributes of the mspace/mpadded at
parsing time. This fixes some assertion failures during layout.
Bug: 1421195
Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362438
Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
Commit-Queue: Frédéric Wang <fw...@igalia.com>
Cr-Commit-Position: refs/heads/main@{#1121571}
---
M third_party/blink/renderer/core/css/parser/css_parser.cc
M third_party/blink/renderer/core/css/parser/css_parser.h
M third_party/blink/renderer/core/mathml/mathml_element.cc
M third_party/blink/renderer/core/mathml/mathml_element.h
M third_party/blink/renderer/core/mathml/mathml_padded_element.cc
M third_party/blink/renderer/core/mathml/mathml_space_element.cc
A third_party/blink/web_tests/external/wpt/mathml/crashtests/mspace-mpadded-negative-dimensions.html
7 files changed, 52 insertions(+), 19 deletions(-)
Blink W3C Test Autoroller (Gerrit)
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/39161