[mathml] Improve parsing of negative dimensions for mspace/mpadded [chromium/src : main]

0 views
Skip to first unread message

Frédéric Wang (Gerrit)

unread,
Mar 23, 2023, 4:15:47 AMMar 23
to Ian Kilpatrick, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Attention is currently required from: Ian Kilpatrick.

Frédéric Wang would like Ian Kilpatrick to review this change.

View Change

[mathml] Improve parsing of negative dimensions for mspace/mpadded

A CSSPrimitiveValue::ValueRange parameter is added to the
ParseMathLength/AddMathLengthToComputedStyle functions and is used to
prevent negative values for some attributes of the mspace/mpadded at
parsing time. This fixes some assertion failures during layout.

Bug: 1421195
Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
---
M third_party/blink/renderer/core/css/parser/css_parser.cc
M third_party/blink/renderer/core/css/parser/css_parser.h
M third_party/blink/renderer/core/mathml/mathml_element.cc
M third_party/blink/renderer/core/mathml/mathml_element.h
M third_party/blink/renderer/core/mathml/mathml_padded_element.cc
M third_party/blink/renderer/core/mathml/mathml_space_element.cc
A third_party/blink/web_tests/external/wpt/mathml/crashtests/mspace-mpadded-negative-dimensions.html
7 files changed, 52 insertions(+), 19 deletions(-)


To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
Gerrit-Change-Number: 4362438
Gerrit-PatchSet: 2
Gerrit-Owner: Frédéric Wang <fw...@igalia.com>
Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
Gerrit-MessageType: newchange

Frédéric Wang (Gerrit)

unread,
Mar 23, 2023, 4:15:54 AMMar 23
to apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Ian Kilpatrick, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org

Attention is currently required from: Ian Kilpatrick.

View Change

    To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
    Gerrit-Change-Number: 4362438
    Gerrit-PatchSet: 2
    Gerrit-Owner: Frédéric Wang <fw...@igalia.com>
    Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
    Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Mar 2023 08:15:43 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Mar 23, 2023, 7:23:00 AMMar 23
    to Frédéric Wang, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Ian Kilpatrick, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org

    Attention is currently required from: Ian Kilpatrick.

    Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/39161.

    When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.

    WPT Export docs:
    https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process

    View Change

      To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
      Gerrit-Change-Number: 4362438
      Gerrit-PatchSet: 2
      Gerrit-Owner: Frédéric Wang <fw...@igalia.com>
      Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-Attention: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-Comment-Date: Thu, 23 Mar 2023 11:22:51 +0000

      Ian Kilpatrick (Gerrit)

      unread,
      Mar 23, 2023, 5:38:55 PMMar 23
      to Frédéric Wang, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Blink W3C Test Autoroller, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org

      Attention is currently required from: Frédéric Wang.

      Patch set 2:Code-Review +1

      View Change

      1 comment:

      To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
      Gerrit-Change-Number: 4362438
      Gerrit-PatchSet: 2
      Gerrit-Owner: Frédéric Wang <fw...@igalia.com>
      Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
      Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-Attention: Frédéric Wang <fw...@igalia.com>
      Gerrit-Comment-Date: Thu, 23 Mar 2023 21:38:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Frédéric Wang (Gerrit)

      unread,
      Mar 24, 2023, 2:17:56 AMMar 24
      to apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Ian Kilpatrick, Blink W3C Test Autoroller, Chromium LUCI CQ, Alexis Menard, chromium...@chromium.org

      Attention is currently required from: Frédéric Wang.

      Patch set 2:Commit-Queue +2

      View Change

        To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
        Gerrit-Change-Number: 4362438
        Gerrit-PatchSet: 2
        Gerrit-Owner: Frédéric Wang <fw...@igalia.com>
        Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-CC: Alexis Menard <alexis...@intel.com>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-Attention: Frédéric Wang <fw...@igalia.com>
        Gerrit-Comment-Date: Fri, 24 Mar 2023 06:17:47 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        Gerrit-MessageType: comment

        Chromium LUCI CQ (Gerrit)

        unread,
        Mar 24, 2023, 3:28:26 AMMar 24
        to Frédéric Wang, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Ian Kilpatrick, Blink W3C Test Autoroller, Alexis Menard, chromium...@chromium.org

        Chromium LUCI CQ submitted this change.

        View Change

        Approvals: Ian Kilpatrick: Looks good to me Frédéric Wang: Commit
        [mathml] Improve parsing of negative dimensions for mspace/mpadded

        A CSSPrimitiveValue::ValueRange parameter is added to the
        ParseMathLength/AddMathLengthToComputedStyle functions and is used to
        prevent negative values for some attributes of the mspace/mpadded at
        parsing time. This fixes some assertion failures during layout.

        Bug: 1421195
        Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
        Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4362438
        Reviewed-by: Ian Kilpatrick <ikilp...@chromium.org>
        Commit-Queue: Frédéric Wang <fw...@igalia.com>
        Cr-Commit-Position: refs/heads/main@{#1121571}

        ---
        M third_party/blink/renderer/core/css/parser/css_parser.cc
        M third_party/blink/renderer/core/css/parser/css_parser.h
        M third_party/blink/renderer/core/mathml/mathml_element.cc
        M third_party/blink/renderer/core/mathml/mathml_element.h
        M third_party/blink/renderer/core/mathml/mathml_padded_element.cc
        M third_party/blink/renderer/core/mathml/mathml_space_element.cc
        A third_party/blink/web_tests/external/wpt/mathml/crashtests/mspace-mpadded-negative-dimensions.html
        7 files changed, 52 insertions(+), 19 deletions(-)


        To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
        Gerrit-Change-Number: 4362438
        Gerrit-PatchSet: 3
        Gerrit-Owner: Frédéric Wang <fw...@igalia.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
        Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
        Gerrit-CC: Alexis Menard <alexis...@intel.com>
        Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
        Gerrit-MessageType: merged

        Blink W3C Test Autoroller (Gerrit)

        unread,
        Mar 24, 2023, 3:53:04 AMMar 24
        to Frédéric Wang, Chromium LUCI CQ, apavlo...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, Ian Kilpatrick, Alexis Menard, chromium...@chromium.org

        The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/39161

        View Change

          To view, visit change 4362438. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ia6e8ecdbb1554e5e255a95c503cf9ed5d096916f
          Gerrit-Change-Number: 4362438
          Gerrit-PatchSet: 3
          Gerrit-Owner: Frédéric Wang <fw...@igalia.com>
          Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
          Gerrit-Reviewer: Frédéric Wang <fw...@igalia.com>
          Gerrit-Reviewer: Ian Kilpatrick <ikilp...@chromium.org>
          Gerrit-CC: Alexis Menard <alexis...@intel.com>
          Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
          Gerrit-Comment-Date: Fri, 24 Mar 2023 07:52:57 +0000
          Reply all
          Reply to author
          Forward
          0 new messages