The <command> element should be treated as invalid in HTML parsing. [chromium/src : main]
0 views
Skip to first unread message
Javier Fernandez (Gerrit)
Mar 5, 2026, 3:53:33 AM (yesterday) Mar 5
to Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
New activity on the change![]( "Open in Gerrit")
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Javier Fernandez (Gerrit)
Mar 5, 2026, 3:55:07 AM (yesterday) Mar 5
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Mason Freed
Javier Fernandez added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Javier Fernandez . resolved
Hi @masonf
I have found this other bug while investigating the Adoption Algorithm issue.
It seems that WebKit's parser doesn't know about the <command> element either, so I think we could align with that.
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
3:33 PM (8 hours ago) 3:33 PM
to Javier Fernandez, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Javier Fernandez
Mason Freed added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mason Freed . resolved
Nice catch! I'm amazed I hadn't seen that.
As much as I hate to say it, we should probably add a runtime enabled feature for this too, since it's possible someone depends on it or something. I think the changes are small, but better safe than sorry. Otherwise, looks good to me.
Related details
Attention is currently required from:
- Javier Fernandez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
3:34 PM (8 hours ago) 3:34 PM
to Javier Fernandez, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Javier Fernandez
Mason Freed added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Mason Freed . resolved
Oh one more thing, you should remove `"command"` from third_party/blink/renderer/core/html/html_tag_names.json5
Related details
Attention is currently required from:
- Javier Fernandez
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages