Web IDL: Fix HTMLConstructor extended attribute usage #4 [chromium/src : main]

0 views
Skip to first unread message

Ho Cheung (Gerrit)

unread,
Sep 14, 2025, 11:09:07 AM (8 days ago) Sep 14
to Fredrik Söderquist, srirama chandra sekhar, AyeAye, gl...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, jmedle...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org
Attention needed from Joey Arhar

Ho Cheung voted and added 1 comment

Votes added by Ho Cheung

Auto-Submit+1
Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iece7ad510cee25056f18b2af69e707ed98b5011a
Gerrit-Change-Number: 6945366
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Sun, 14 Sep 2025 15:08:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Ho Cheung (Gerrit)

unread,
Sep 15, 2025, 8:01:05 PM (6 days ago) Sep 15
to Chromium LUCI CQ, Fredrik Söderquist, srirama chandra sekhar, AyeAye, gl...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, jmedle...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org
Attention needed from Joey Arhar

Ho Cheung added 1 comment

Patchset-level comments
Ho Cheung . resolved

@Joey

friendly ping

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iece7ad510cee25056f18b2af69e707ed98b5011a
Gerrit-Change-Number: 6945366
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Sep 2025 00:00:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Sep 16, 2025, 2:08:47 PM (5 days ago) Sep 16
to Ho Cheung, Chromium LUCI CQ, Fredrik Söderquist, srirama chandra sekhar, AyeAye, gl...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, jmedle...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org
Attention needed from Ho Cheung

Joey Arhar voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Ho Cheung
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iece7ad510cee25056f18b2af69e707ed98b5011a
Gerrit-Change-Number: 6945366
Gerrit-PatchSet: 1
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Ho Cheung <hoch...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Sep 2025 18:08:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Sep 16, 2025, 5:32:05 PM (5 days ago) Sep 16
to Ho Cheung, Fredrik Söderquist, srirama chandra sekhar, AyeAye, gl...@chromium.org, feature-me...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, jmedle...@chromium.org, silv...@chromium.org, blink-rev...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Web IDL: Fix HTMLConstructor extended attribute usage #4

Move [HTMLConstructor] from interface declarations to constructor
operations to comply with Web IDL specification section 3.2.3.
Bug: 40683312
Change-Id: Iece7ad510cee25056f18b2af69e707ed98b5011a
Commit-Queue: Joey Arhar <jar...@chromium.org>
Auto-Submit: Ho Cheung <hoch...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1516269}
Files:
  • M third_party/blink/renderer/core/html/canvas/html_canvas_element.idl
  • M third_party/blink/renderer/core/html/fenced_frame/html_fenced_frame_element.idl
  • M third_party/blink/renderer/core/html/forms/html_button_element.idl
  • M third_party/blink/renderer/core/html/forms/html_data_list_element.idl
  • M third_party/blink/renderer/core/html/forms/html_field_set_element.idl
  • M third_party/blink/renderer/core/html/forms/html_form_element.idl
  • M third_party/blink/renderer/core/html/forms/html_input_element.idl
  • M third_party/blink/renderer/core/html/forms/html_label_element.idl
  • M third_party/blink/renderer/core/html/forms/html_legend_element.idl
  • M third_party/blink/renderer/core/html/forms/html_opt_group_element.idl
  • M third_party/blink/renderer/core/html/forms/html_output_element.idl
  • M third_party/blink/renderer/core/html/forms/html_select_element.idl
  • M third_party/blink/renderer/core/html/forms/html_selected_content_element.idl
  • M third_party/blink/renderer/core/html/forms/html_text_area_element.idl
  • M third_party/blink/renderer/core/html/html_template_element.idl
  • M third_party/blink/renderer/core/html/html_time_element.idl
  • M third_party/blink/renderer/core/html/html_title_element.idl
  • M third_party/blink/renderer/core/html/html_ulist_element.idl
  • M third_party/blink/renderer/core/html/media/html_video_element.idl
  • M third_party/blink/renderer/core/html/track/html_track_element.idl
Change size: M
Delta: 20 files changed, 39 insertions(+), 37 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Joey Arhar
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iece7ad510cee25056f18b2af69e707ed98b5011a
Gerrit-Change-Number: 6945366
Gerrit-PatchSet: 2
Gerrit-Owner: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Ho Cheung <hoch...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages