[html-in-canvas] Support nested canvases [chromium/src : main]

0 views
Skip to first unread message

Philip Rogers (Gerrit)

unread,
Sep 12, 2025, 7:45:09 PM (9 days ago) Sep 12
to Stephen Chenney, Chris Harrelson, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Stephen Chenney

Philip Rogers voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Stephen Chenney
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2ff0bdb0146a31751f5c1169f6802819f5a19909
Gerrit-Change-Number: 6944753
Gerrit-PatchSet: 3
Gerrit-Owner: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
Gerrit-CC: Chris Harrelson <chri...@chromium.org>
Gerrit-Attention: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Fri, 12 Sep 2025 23:45:00 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Stephen Chenney (Gerrit)

unread,
Sep 14, 2025, 3:10:26 PM (7 days ago) Sep 14
to Philip Rogers, Chromium LUCI CQ, Chris Harrelson, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Philip Rogers

Stephen Chenney voted and added 1 comment

Votes added by Stephen Chenney

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Stephen Chenney . resolved

LGTM. It's nice to be proved wrong in this case; I doubted it would work. Also thanks for simplifying the flags. I tried to think of other test cases but nothing came to mind.

Open in Gerrit

Related details

Attention is currently required from:
  • Philip Rogers
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2ff0bdb0146a31751f5c1169f6802819f5a19909
    Gerrit-Change-Number: 6944753
    Gerrit-PatchSet: 5
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Chris Harrelson <chri...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Comment-Date: Sun, 14 Sep 2025 19:10:19 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Philip Rogers (Gerrit)

    unread,
    Sep 14, 2025, 6:20:20 PM (7 days ago) Sep 14
    to Stephen Chenney, Chromium LUCI CQ, Chris Harrelson, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Philip Rogers voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2ff0bdb0146a31751f5c1169f6802819f5a19909
    Gerrit-Change-Number: 6944753
    Gerrit-PatchSet: 5
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Chris Harrelson <chri...@chromium.org>
    Gerrit-Comment-Date: Sun, 14 Sep 2025 22:20:11 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 14, 2025, 7:52:37 PM (7 days ago) Sep 14
    to Philip Rogers, Stephen Chenney, Chris Harrelson, chromium...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [html-in-canvas] Support nested canvases

    This patch adds support for nested html-in-canvas. There is partner
    interest in the feature. Nested canvas is also a solution for granular
    invalidation, as the `fireOnEveryPaint` resize observer signal is
    per-canvas, so nested canvases can be used for nested invalidation
    signals.

    The patch itself is a simplification, as `kPaintingCanvasDrawElement`
    was ultimately just complexity for preventing this usecase.
    Fixed: 413728246
    Change-Id: I2ff0bdb0146a31751f5c1169f6802819f5a19909
    Reviewed-by: Stephen Chenney <sche...@chromium.org>
    Commit-Queue: Philip Rogers <p...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1515326}
    Files:
    • M third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
    • M third_party/blink/renderer/core/paint/box_painter_base.cc
    • M third_party/blink/renderer/core/paint/paint_flags.h
    • M third_party/blink/renderer/core/paint/paint_layer_painter.cc
    • M third_party/blink/renderer/core/paint/video_painter.cc
    • M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.cc
    • M third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
    • M third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/error-conditions.html
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/fireOnEveryPaint-nested-canvas.html
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/moved-nested-canvas.html
    • M third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-canvas-not-rendered.html
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-canvas-ref.html
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-canvas.html
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-div-canvas.html
    • A third_party/blink/web_tests/wpt_internal/html/canvas/drawElementImage/nested-webgl-canvas.html
    Change size: L
    Delta: 15 files changed, 247 insertions(+), 30 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Stephen Chenney
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2ff0bdb0146a31751f5c1169f6802819f5a19909
    Gerrit-Change-Number: 6944753
    Gerrit-PatchSet: 6
    Gerrit-Owner: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Stephen Chenney <sche...@chromium.org>
    Gerrit-CC: Chris Harrelson <chri...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages