WTF: Rename IsLowerASCII() to ContainsNoAsciiUpper() [chromium/src : main]
0 views
Skip to first unread message
Kent Tamura (Gerrit)
3:05 AM (20 hours ago) 3:05 AM
to Kent Tamura, Fredrik Söderquist, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Fredrik Söderquist
Kent Tamura voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kent Tamura
| Auto-Submit | +1 |
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Fredrik Söderquist (Gerrit)
5:09 AM (18 hours ago) 5:09 AM
to Kent Tamura, Chromium LUCI CQ, AyeAye, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Attention needed from Kent Tamura
Fredrik Söderquist voted and added 1 comment![]( "Open in Gerrit")
Votes added by Fredrik Söderquist
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
File third_party/blink/renderer/platform/wtf/text/atomic_string.cc
Line 97, Patchset 4 (Latest):
if (source.ContainsNoAsciiUpper()) [[likely]] {Fredrik Söderquist . resolved
It's a bit confusing that `AtomicString` has this optimization, but `String` doesn't.
Related details
Attention is currently required from:
- Kent Tamura
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
5:16 AM (18 hours ago) 5:16 AM
to Kent Tamura, Fredrik Söderquist, AyeAye, Menard, Alexis, chromium...@chromium.org, apavlo...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
WTF: Rename IsLowerASCII() to ContainsNoAsciiUpper()
The previous name IsLowerASCII() was confusing. It could be
misinterpreted as checking if a string consists entirely of lowercase
ASCII characters. However, its actual behavior was to check for the
absence of any ASCII uppercase characters, which means it would return
true for strings containing non-ASCII characters (e.g., "foo©").
The new name, ContainsNoAsciiUpper(), more precisely reflects this
logic.
For consistency, this CL also renames IsUpperASCII() to
ContainsNoAsciiLower().
Bug: 473854537
Change-Id: I384c1f58f8527acde7e67627944c1ebe30d56036
Reviewed-by: Fredrik Söderquist <f...@opera.com>
Auto-Submit: Kent Tamura <tk...@chromium.org>
Commit-Queue: Fredrik Söderquist <f...@opera.com>
Cr-Commit-Position: refs/heads/main@{#1595272}
Files:
- M third_party/blink/renderer/core/css/check_pseudo_has_fast_reject_filter.cc
- M third_party/blink/renderer/core/css/selector_filter.cc
- M third_party/blink/renderer/core/dom/element.cc
- M third_party/blink/renderer/core/dom/element_data.h
- M third_party/blink/renderer/core/html/html_capability_element_base.cc
- M third_party/blink/renderer/core/trustedtypes/trusted_type_policy_factory.cc
- M third_party/blink/renderer/modules/buckets/storage_bucket_manager.cc
- M third_party/blink/renderer/platform/wtf/text/ascii_fast_path.h
- M third_party/blink/renderer/platform/wtf/text/atomic_string.cc
- M third_party/blink/renderer/platform/wtf/text/atomic_string.h
- M third_party/blink/renderer/platform/wtf/text/atomic_string_table.cc
- M third_party/blink/renderer/platform/wtf/text/ignoring_ascii_case_hash.h
- M third_party/blink/renderer/platform/wtf/text/string_impl.h
- M third_party/blink/renderer/platform/wtf/text/string_view.cc
- M third_party/blink/renderer/platform/wtf/text/string_view.h
- M third_party/blink/renderer/platform/wtf/text/string_view_test.cc
- M third_party/blink/renderer/platform/wtf/text/wtf_string.h
- M third_party/blink/renderer/platform/wtf/text/wtf_string_test.cc
- M third_party/blink/renderer/platform/wtf/uuid.cc
Change size: M
Delta: 19 files changed, 73 insertions(+), 41 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Fredrik Söderquist
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages