Remove Impression struct and associated navigation parameters [chromium/src : main]

0 views
Skip to first unread message

Nan Lin (Gerrit)

unread,
Jun 24, 2026, 10:44:26 AM (4 days ago) Jun 24
to Andrew Paseltiner, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
Attention needed from Andrew Paseltiner

Nan Lin added 1 comment

Patchset-level comments
File-level comment, Patchset 16 (Latest):
Nan Lin . resolved

Hi Andrew, could you PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Paseltiner
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
Gerrit-Change-Number: 7958374
Gerrit-PatchSet: 16
Gerrit-Owner: Nan Lin <lin...@chromium.org>
Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Daniel Cheng <dch...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
Gerrit-Comment-Date: Wed, 24 Jun 2026 14:44:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Paseltiner (Gerrit)

unread,
Jun 24, 2026, 10:51:32 AM (4 days ago) Jun 24
to Nan Lin, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Nate Chapin, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
Attention needed from Nan Lin

Andrew Paseltiner voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Nan Lin
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
    Gerrit-Change-Number: 7958374
    Gerrit-PatchSet: 16
    Gerrit-Owner: Nan Lin <lin...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Nan Lin <lin...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 14:51:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nan Lin (Gerrit)

    unread,
    Jun 24, 2026, 11:29:20 AM (4 days ago) Jun 24
    to Nate Chapin, Andrew Paseltiner, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
    Attention needed from Nate Chapin

    Nan Lin added 1 comment

    Patchset-level comments
    Nan Lin . resolved

    @jap...@chromium.org Could you PTAL at blink changes, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Nate Chapin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
    Gerrit-Change-Number: 7958374
    Gerrit-PatchSet: 16
    Gerrit-Owner: Nan Lin <lin...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 15:29:00 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nan Lin (Gerrit)

    unread,
    Jun 24, 2026, 11:30:29 AM (4 days ago) Jun 24
    to Avi Drissman, Chromium IPC Reviews, Nate Chapin, Andrew Paseltiner, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
    Attention needed from Avi Drissman, Chromium IPC Reviews and Nate Chapin

    Nan Lin added 1 comment

    Patchset-level comments
    Nan Lin . resolved

    @a...@chromium.org Could you PTAL at //content changes, thanks!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Chromium IPC Reviews
    • Nate Chapin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
    Gerrit-Change-Number: 7958374
    Gerrit-PatchSet: 16
    Gerrit-Owner: Nan Lin <lin...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 15:30:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    gwsq (Gerrit)

    unread,
    Jun 24, 2026, 11:37:45 AM (4 days ago) Jun 24
    to Nan Lin, Chromium IPC Reviews, Ken Buchanan, Avi Drissman, Nate Chapin, Andrew Paseltiner, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
    Attention needed from Avi Drissman, Ken Buchanan and Nate Chapin

    Message from gwsq

    From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
    IPC: ke...@chromium.org

    📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

    IPC reviewer(s): ke...@chromium.org


    Reviewer source(s):
    ke...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Ken Buchanan
    • Nate Chapin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
    Gerrit-Change-Number: 7958374
    Gerrit-PatchSet: 16
    Gerrit-Owner: Nan Lin <lin...@chromium.org>
    Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
    Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
    Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
    Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
    Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Daniel Cheng <dch...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: gwsq
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 15:37:01 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Ken Buchanan (Gerrit)

    unread,
    Jun 24, 2026, 12:13:18 PM (4 days ago) Jun 24
    to Nan Lin, Chromium IPC Reviews, Avi Drissman, Nate Chapin, Andrew Paseltiner, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
    Attention needed from Avi Drissman, Nan Lin and Nate Chapin

    Ken Buchanan voted and added 1 comment

    Votes added by Ken Buchanan

    Code-Review+1

    1 comment

    Patchset-level comments
    Ken Buchanan . resolved

    mojom and traits lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Avi Drissman
    • Nan Lin
    • Nate Chapin
    Gerrit-Attention: Nan Lin <lin...@chromium.org>
    Gerrit-Attention: Avi Drissman <a...@chromium.org>
    Gerrit-Attention: Nate Chapin <jap...@chromium.org>
    Gerrit-Comment-Date: Wed, 24 Jun 2026 16:13:02 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Nan Lin (Gerrit)

    unread,
    Jun 24, 2026, 12:21:20 PM (4 days ago) Jun 24
    to Ken Buchanan, Chromium IPC Reviews, Avi Drissman, Nate Chapin, Andrew Paseltiner, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
    Attention needed from Andrew Paseltiner, Avi Drissman, Ken Buchanan and Nate Chapin

    New activity on the change

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Andrew Paseltiner
    • Avi Drissman
    • Ken Buchanan
    • Nate Chapin
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
      Gerrit-Change-Number: 7958374
      Gerrit-PatchSet: 18
      Gerrit-Owner: Nan Lin <lin...@chromium.org>
      Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
      Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
      Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
      Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
      Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
      Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Daniel Cheng <dch...@chromium.org>
      Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
      Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
      Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
      Gerrit-Attention: Avi Drissman <a...@chromium.org>
      Gerrit-Attention: Nate Chapin <jap...@chromium.org>
      Gerrit-Comment-Date: Wed, 24 Jun 2026 16:21:07 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nate Chapin (Gerrit)

      unread,
      Jun 24, 2026, 12:24:45 PM (4 days ago) Jun 24
      to Nan Lin, Ken Buchanan, Chromium IPC Reviews, Avi Drissman, Andrew Paseltiner, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
      Attention needed from Andrew Paseltiner, Avi Drissman, Ken Buchanan and Nan Lin

      Nate Chapin voted and added 1 comment

      Votes added by Nate Chapin

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 18 (Latest):
      Nate Chapin . resolved

      blink/ LGTM

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Andrew Paseltiner
      • Avi Drissman
      • Ken Buchanan
      • Nan Lin
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
        Gerrit-Change-Number: 7958374
        Gerrit-PatchSet: 18
        Gerrit-Owner: Nan Lin <lin...@chromium.org>
        Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
        Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Daniel Cheng <dch...@chromium.org>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
        Gerrit-Attention: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
        Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Attention: Avi Drissman <a...@chromium.org>
        Gerrit-Comment-Date: Wed, 24 Jun 2026 16:24:32 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Andrew Paseltiner (Gerrit)

        unread,
        Jun 24, 2026, 12:29:15 PM (4 days ago) Jun 24
        to Nan Lin, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Avi Drissman, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
        Attention needed from Avi Drissman, Ken Buchanan and Nan Lin

        Andrew Paseltiner voted Code-Review+1

        Code-Review+1
        Open in Gerrit

        Related details

        Attention is currently required from:
        Gerrit-Attention: Avi Drissman <a...@chromium.org>
        Gerrit-Comment-Date: Wed, 24 Jun 2026 16:29:03 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Avi Drissman (Gerrit)

        unread,
        Jun 24, 2026, 3:03:24 PM (4 days ago) Jun 24
        to Nan Lin, Avi Drissman, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
        Attention needed from Ken Buchanan and Nan Lin

        Avi Drissman voted and added 1 comment

        Votes added by Avi Drissman

        Code-Review+1

        1 comment

        Patchset-level comments
        File-level comment, Patchset 19 (Latest):
        Avi Drissman . resolved

        🫡

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Ken Buchanan
        • Nan Lin
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement is not satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
        Gerrit-Change-Number: 7958374
        Gerrit-PatchSet: 19
        Gerrit-Owner: Nan Lin <lin...@chromium.org>
        Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
        Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
        Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
        Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
        Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
        Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
        Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
        Gerrit-CC: Daniel Cheng <dch...@chromium.org>
        Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
        Gerrit-CC: gwsq
        Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
        Gerrit-Attention: Nan Lin <lin...@chromium.org>
        Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
        Gerrit-Comment-Date: Wed, 24 Jun 2026 19:03:14 +0000
        Gerrit-HasComments: Yes
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        unsatisfied_requirement
        open
        diffy

        Nan Lin (Gerrit)

        unread,
        Jun 24, 2026, 3:48:25 PM (4 days ago) Jun 24
        to Bo Liu, Avi Drissman, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
        Attention needed from Andrew Paseltiner, Avi Drissman, Bo Liu, Ken Buchanan and Nate Chapin

        Nan Lin added 1 comment

        Patchset-level comments
        File-level comment, Patchset 20 (Latest):
        Nan Lin . resolved

        @bo...@chromium.org Could you PTAL at //components/embedder_support/android/contextmenu/ context_menu_builder.cc, thanks!

        Open in Gerrit

        Related details

        Attention is currently required from:
        • Andrew Paseltiner
        • Avi Drissman
        • Bo Liu
        • Ken Buchanan
        • Nate Chapin
        Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
          Gerrit-Change-Number: 7958374
          Gerrit-PatchSet: 20
          Gerrit-Owner: Nan Lin <lin...@chromium.org>
          Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
          Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
          Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
          Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
          Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
          Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
          Gerrit-Attention: Avi Drissman <a...@chromium.org>
          Gerrit-Attention: Bo Liu <bo...@chromium.org>
          Gerrit-Attention: Nate Chapin <jap...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 19:48:15 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Nan Lin (Gerrit)

          unread,
          Jun 24, 2026, 3:49:55 PM (4 days ago) Jun 24
          to Shunya Shishido, Bo Liu, Avi Drissman, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
          Attention needed from Andrew Paseltiner, Avi Drissman, Bo Liu, Ken Buchanan, Nate Chapin and Shunya Shishido

          Nan Lin added 1 comment

          Patchset-level comments
          Nan Lin . resolved

          @sisid...@chromium.org Could you PTAL at components/page_load_metrics/google/browser/ from_gws_abandoned_page_load_metrics_observer.*, thanks!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Andrew Paseltiner
          • Avi Drissman
          • Bo Liu
          • Ken Buchanan
          • Nate Chapin
          • Shunya Shishido
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
          Gerrit-Change-Number: 7958374
          Gerrit-PatchSet: 20
          Gerrit-Owner: Nan Lin <lin...@chromium.org>
          Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
          Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
          Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
          Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
          Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
          Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
          Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
          Gerrit-Attention: Avi Drissman <a...@chromium.org>
          Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
          Gerrit-Attention: Bo Liu <bo...@chromium.org>
          Gerrit-Attention: Nate Chapin <jap...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 19:49:40 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Nan Lin (Gerrit)

          unread,
          Jun 24, 2026, 3:50:51 PM (4 days ago) Jun 24
          to Chris Thompson, Shunya Shishido, Bo Liu, Avi Drissman, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
          Attention needed from Andrew Paseltiner, Avi Drissman, Bo Liu, Chris Thompson, Ken Buchanan, Nate Chapin and Shunya Shishido

          Nan Lin added 1 comment

          Patchset-level comments
          Nan Lin . resolved

          @cth...@chromium.org Could you PTAL at tools/metrics/histograms/metadata/navigation/enums.xml, thanks!

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Andrew Paseltiner
          • Avi Drissman
          • Bo Liu
          • Chris Thompson
          • Ken Buchanan
          • Nate Chapin
          • Shunya Shishido
          Submit Requirements:
          • requirement satisfiedCode-Coverage
          • requirement is not satisfiedCode-Owners
          • requirement is not satisfiedCode-Review
          • requirement is not satisfiedReview-Enforcement
          Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
          Gerrit-MessageType: comment
          Gerrit-Project: chromium/src
          Gerrit-Branch: main
          Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
          Gerrit-Change-Number: 7958374
          Gerrit-PatchSet: 20
          Gerrit-Owner: Nan Lin <lin...@chromium.org>
          Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
          Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
          Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
          Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
          Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
          Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
          Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
          Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
          Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
          Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
          Gerrit-CC: Daniel Cheng <dch...@chromium.org>
          Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
          Gerrit-CC: gwsq
          Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
          Gerrit-Attention: Chris Thompson <cth...@chromium.org>
          Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
          Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
          Gerrit-Attention: Avi Drissman <a...@chromium.org>
          Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
          Gerrit-Attention: Bo Liu <bo...@chromium.org>
          Gerrit-Attention: Nate Chapin <jap...@chromium.org>
          Gerrit-Comment-Date: Wed, 24 Jun 2026 19:50:40 +0000
          Gerrit-HasComments: Yes
          Gerrit-Has-Labels: No
          satisfied_requirement
          unsatisfied_requirement
          open
          diffy

          Chris Thompson (Gerrit)

          unread,
          Jun 24, 2026, 3:52:12 PM (4 days ago) Jun 24
          to Nan Lin, Shunya Shishido, Bo Liu, Avi Drissman, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
          Attention needed from Andrew Paseltiner, Avi Drissman, Bo Liu, Ken Buchanan, Nan Lin, Nate Chapin and Shunya Shishido

          Chris Thompson voted and added 1 comment

          Votes added by Chris Thompson

          Code-Review+1

          1 comment

          Patchset-level comments
          Nan Lin . resolved

          @cth...@chromium.org Could you PTAL at tools/metrics/histograms/metadata/navigation/enums.xml, thanks!

          Chris Thompson

          LGTM

          Open in Gerrit

          Related details

          Attention is currently required from:
          • Andrew Paseltiner
          • Avi Drissman
          • Bo Liu
          • Ken Buchanan
          • Nan Lin
          • Nate Chapin
          • Shunya Shishido
          Submit Requirements:
            • requirement satisfiedCode-Coverage
            • requirement is not satisfiedCode-Owners
            • requirement satisfiedCode-Review
            Gerrit-Attention: Nan Lin <lin...@chromium.org>
            Gerrit-Attention: Ken Buchanan <ke...@chromium.org>
            Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
            Gerrit-Attention: Avi Drissman <a...@chromium.org>
            Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
            Gerrit-Attention: Bo Liu <bo...@chromium.org>
            Gerrit-Attention: Nate Chapin <jap...@chromium.org>
            Gerrit-Comment-Date: Wed, 24 Jun 2026 19:51:55 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Nan Lin <lin...@chromium.org>
            satisfied_requirement
            unsatisfied_requirement
            open
            diffy

            Avi Drissman (Gerrit)

            unread,
            Jun 24, 2026, 3:52:56 PM (4 days ago) Jun 24
            to Nan Lin, Avi Drissman, Chris Thompson, Shunya Shishido, Bo Liu, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
            Attention needed from Andrew Paseltiner, Bo Liu, Ken Buchanan, Nan Lin, Nate Chapin and Shunya Shishido

            Avi Drissman voted Code-Review+1

            Code-Review+1
            Open in Gerrit

            Related details

            Attention is currently required from:
            • Andrew Paseltiner
            • Bo Liu
            • Ken Buchanan
            • Nan Lin
            • Nate Chapin
            • Shunya Shishido
              Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement is not satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Gerrit-Attention: Shunya Shishido <sisid...@chromium.org>
                Gerrit-Attention: Bo Liu <bo...@chromium.org>
                Gerrit-Attention: Nate Chapin <jap...@chromium.org>
                Gerrit-Comment-Date: Wed, 24 Jun 2026 19:52:47 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy

                Shunya Shishido (Gerrit)

                unread,
                Jun 24, 2026, 8:39:18 PM (4 days ago) Jun 24
                to Nan Lin, Avi Drissman, Chris Thompson, Bo Liu, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
                Attention needed from Andrew Paseltiner, Bo Liu, Nan Lin and Nate Chapin

                Shunya Shishido voted and added 1 comment

                Votes added by Shunya Shishido

                Code-Review+1

                1 comment

                Patchset-level comments
                Shunya Shishido . resolved

                page_load_metrics LGTM

                Open in Gerrit

                Related details

                Attention is currently required from:
                • Andrew Paseltiner
                • Bo Liu
                • Nan Lin
                • Nate Chapin
                Gerrit-Attention: Andrew Paseltiner <apase...@chromium.org>
                Gerrit-Attention: Bo Liu <bo...@chromium.org>
                Gerrit-Attention: Nate Chapin <jap...@chromium.org>
                Gerrit-Comment-Date: Thu, 25 Jun 2026 00:38:49 +0000
                Gerrit-HasComments: Yes
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                unsatisfied_requirement
                open
                diffy

                Bo Liu (Gerrit)

                unread,
                Jun 24, 2026, 10:32:09 PM (4 days ago) Jun 24
                to Nan Lin, Bo Liu, Shunya Shishido, Avi Drissman, Chris Thompson, Andrew Paseltiner, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
                Attention needed from Andrew Paseltiner, Nan Lin and Nate Chapin

                Bo Liu voted Code-Review+1

                Code-Review+1
                Open in Gerrit

                Related details

                Attention is currently required from:
                • Andrew Paseltiner
                • Nan Lin
                • Nate Chapin
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                Gerrit-Attention: Nate Chapin <jap...@chromium.org>
                Gerrit-Comment-Date: Thu, 25 Jun 2026 02:31:54 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Andrew Paseltiner (Gerrit)

                unread,
                Jun 25, 2026, 8:21:02 AM (3 days ago) Jun 25
                to Nan Lin, Bo Liu, Shunya Shishido, Avi Drissman, Chris Thompson, Nate Chapin, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
                Attention needed from Nan Lin and Nate Chapin

                Andrew Paseltiner voted Code-Review+1

                Code-Review+1
                Open in Gerrit

                Related details

                Attention is currently required from:
                • Nan Lin
                • Nate Chapin
                Gerrit-Attention: Nate Chapin <jap...@chromium.org>
                Gerrit-Comment-Date: Thu, 25 Jun 2026 12:20:49 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy

                Nate Chapin (Gerrit)

                unread,
                Jun 25, 2026, 1:45:08 PM (3 days ago) Jun 25
                to Nan Lin, Andrew Paseltiner, Bo Liu, Shunya Shishido, Avi Drissman, Chris Thompson, Ken Buchanan, Chromium IPC Reviews, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Daniel Cheng, Hiroki Nakagawa, prerendering-reviews, alexmo...@chromium.org, apaselti...@chromium.org, asvitkine...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, bmcquad...@chromium.org, creis...@chromium.org, csharris...@chromium.org, gavinp...@chromium.org, gavin...@chromium.org, horo+...@chromium.org, ipc-securi...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, loading...@chromium.org, navigation...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, tburkar...@chromium.org
                Attention needed from Nan Lin

                Nate Chapin voted Code-Review+1

                Code-Review+1
                Open in Gerrit

                Related details

                Attention is currently required from:
                • Nan Lin
                Submit Requirements:
                • requirement satisfiedCode-Coverage
                • requirement satisfiedCode-Owners
                • requirement satisfiedCode-Review
                • requirement satisfiedReview-Enforcement
                Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
                Gerrit-MessageType: comment
                Gerrit-Project: chromium/src
                Gerrit-Branch: main
                Gerrit-Change-Id: Ic632f4dffc7229bb2f82be098783180388fbd8bb
                Gerrit-Change-Number: 7958374
                Gerrit-PatchSet: 21
                Gerrit-Owner: Nan Lin <lin...@chromium.org>
                Gerrit-Reviewer: Andrew Paseltiner <apase...@chromium.org>
                Gerrit-Reviewer: Avi Drissman <a...@chromium.org>
                Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
                Gerrit-Reviewer: Chris Thompson <cth...@chromium.org>
                Gerrit-Reviewer: Ken Buchanan <ke...@chromium.org>
                Gerrit-Reviewer: Nan Lin <lin...@chromium.org>
                Gerrit-Reviewer: Nate Chapin <jap...@chromium.org>
                Gerrit-Reviewer: Shunya Shishido <sisid...@chromium.org>
                Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
                Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
                Gerrit-CC: Daniel Cheng <dch...@chromium.org>
                Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
                Gerrit-CC: gwsq
                Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
                Gerrit-Attention: Nan Lin <lin...@chromium.org>
                Gerrit-Comment-Date: Thu, 25 Jun 2026 17:44:42 +0000
                Gerrit-HasComments: No
                Gerrit-Has-Labels: Yes
                satisfied_requirement
                open
                diffy
                Reply all
                Reply to author
                Forward
                0 new messages