Support :user-valid/:user-invalid on multifield inputs [chromium/src : main]
0 views
Skip to first unread message
Joey Arhar (Gerrit)
Apr 18, 2024, 6:03:52 PMApr 18
to AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, dpr...@google.com, blink-rev...@chromium.org, blink-...@chromium.org
Joey Arhar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Joey Arhar . unresolved
note to self:
check the wpt.fyi results to see if firefox passes the test. if not, then relax the test and maybe make an internal test which asserts the webkit-like special behavior i added.
also add subtests for type=datetime-local and type=time
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 18, 2024, 6:06:55 PMApr 18
to AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, dpr...@google.com, blink-rev...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
Exportable changes to web-platform-tests were detected in this CL and a pull request in the upstream repo has been made: https://github.com/web-platform-tests/wpt/pull/45792.
When this CL lands, the bot will automatically merge the PR on GitHub if the required GitHub checks pass; otherwise, ecosystem-infra@ team will triage the failures and may contact you.
WPT Export docs:
https://chromium.googlesource.com/chromium/src/+/main/docs/testing/web_platform_tests.md#Automatic-export-process
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dominique Fauteux-Chapleau (Gerrit)
Apr 22, 2024, 2:42:43 PMApr 22
to dpr...@google.com, Blink W3C Test Autoroller, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Dominique Fauteux-Chapleau removed dpr...@google.com from this change![]( "Open in Gerrit")
Deleted Reviewers:
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Apr 24, 2024, 3:37:23 PMApr 24
to Di Zhang, Blink W3C Test Autoroller, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Di Zhang
Joey Arhar added 1 comment![]( "Open in Gerrit")
Patchset-level comments
note to self:
check the wpt.fyi results to see if firefox passes the test. if not, then relax the test and maybe make an internal test which asserts the webkit-like special behavior i added.
also add subtests for type=datetime-local and type=time
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Apr 25, 2024, 2:38:41 PMApr 25
to Joey Arhar, Blink W3C Test Autoroller, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Di Zhang added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/forms/html_input_element.cc
Line 2501, Patchset 5 (Latest):
SetUserHasEditedTheFieldAndBlurred();Di Zhang . unresolved
I am slightly nervous that this function is called SetFocused() yet we are setting the blurred first. Should the order be:
```
TextControlElement::SetFocused(is_focused, focus_type);
if (!input_type_view_->IsMultipleFieldsTemporal() &&
UserHasEditedTheField()) {
SetUserHasEditedTheFieldAndBlurred();
}
```
File third_party/blink/web_tests/external/wpt/css/selectors/user-invalid.html
Line 233, Patchset 5 (Latest):
await test_driver.send_keys(date, `1${tabKey}1${tabKey}1234${tabKey}${tabKey}`);Di Zhang . unresolved
This is cool. Should we add an assert that the document.activeElement isn't the date anymore?
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Apr 29, 2024, 4:50:06 PMApr 29
to Di Zhang, Blink W3C Test Autoroller, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Di Zhang
Joey Arhar added 2 comments![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/forms/html_input_element.cc
Line 2501, Patchset 5 (Latest):
SetUserHasEditedTheFieldAndBlurred();Di Zhang . resolved
I am slightly nervous that this function is called SetFocused() yet we are setting the blurred first. Should the order be:
```
TextControlElement::SetFocused(is_focused, focus_type);
if (!input_type_view_->IsMultipleFieldsTemporal() &&
UserHasEditedTheField()) {
SetUserHasEditedTheFieldAndBlurred();
}
```
Joey Arhar
Yeah we probably shouldn't call SetUserHasEditedTheFieldAndBlurred when the input gains focus, so I added a check to only run it if !is_focused, which means that the input is actually being blurred. I also moved the super call up front like you asked.
File third_party/blink/web_tests/external/wpt/css/selectors/user-invalid.html
Line 233, Patchset 5 (Latest):
await test_driver.send_keys(date, `1${tabKey}1${tabKey}1234${tabKey}${tabKey}`);Di Zhang . resolved
This is cool. Should we add an assert that the document.activeElement isn't the date anymore?
Attention is currently required from:
- Di Zhang
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Apr 29, 2024, 5:05:49 PMApr 29
to Joey Arhar, Blink W3C Test Autoroller, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar
Di Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Apr 29, 2024, 5:56:06 PMApr 29
to Di Zhang, Blink W3C Test Autoroller, AyeAye, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Joey Arhar voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 29, 2024, 5:59:51 PMApr 29
to Joey Arhar, Di Zhang, Blink W3C Test Autoroller, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Support :user-valid/:user-invalid on multifield inputs
This patch makes :user-valid and :user-invalid start working on inputs
with type date, datetime-local, and time.
I matched the webkit behavior for when to start matching in response to
keyboard input, and added a separate tentative test for that behavior.
Fixed: 328674226
Change-Id: If3c394e43043a0b3d27eac22d0671c6b45b82bc6
Reviewed-by: Di Zhang <dizh...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1294002}
Files:
- M third_party/blink/renderer/core/html/forms/html_input_element.cc
- M third_party/blink/renderer/core/html/forms/html_input_element.h
- M third_party/blink/renderer/core/html/forms/html_text_area_element.cc
- M third_party/blink/renderer/core/html/forms/html_text_area_element.h
- M third_party/blink/renderer/core/html/forms/input_type_view.h
- M third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.cc
- M third_party/blink/renderer/core/html/forms/multiple_fields_temporal_input_type_view.h
- M third_party/blink/renderer/core/html/forms/text_control_element.cc
- M third_party/blink/web_tests/external/wpt/css/selectors/user-invalid.html
- A third_party/blink/web_tests/external/wpt/css/selectors/user-valid-user-invalid-multifield-inputs.tentative.html
- M third_party/blink/web_tests/external/wpt/css/selectors/user-valid.html
Change size: L
Delta: 11 files changed, 269 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Di Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Blink W3C Test Autoroller (Gerrit)
Apr 29, 2024, 9:30:05 PMApr 29
to Chromium LUCI CQ, Di Zhang, AyeAye, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Message from Blink W3C Test Autoroller![]( "Open in Gerrit")
The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/45792
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages