Implement "directionality of an attribute" and use it for title. [chromium/src : main]
0 views
Skip to first unread message
David Baron (Gerrit)
Jun 24, 2025, 11:24:37 AMJun 24
to David Baron, Di Zhang, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from Di Zhang
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Di Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Jun 24, 2025, 12:21:23 PMJun 24
to David Baron, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Attention needed from David Baron
Di Zhang voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- David Baron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jun 24, 2025, 12:22:59 PMJun 24
to David Baron, Di Zhang, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
David Baron voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
David Baron (Gerrit)
Jun 24, 2025, 12:26:17 PMJun 24
to David Baron, Chromium LUCI CQ, Di Zhang, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
David Baron voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2025, 1:17:22 PMJun 24
to David Baron, Di Zhang, chromium...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, zol...@webkit.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
2 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/html/html_element.cc
Insertions: 2, Deletions: 0.
@@ -2692,6 +2692,8 @@
}
if (const LayoutObject* layout_object = GetLayoutObject()) {
+ // Note that this isn't part of the HTML spec's concept, but we've
+ // always honored CSS directionality for the title attribute.
direction = layout_object->StyleRef().Direction();
}
if (RuntimeEnabledFeatures::AttributeDirectionalityEnabled() &&
```
Change information
Commit message:
Implement "directionality of an attribute" and use it for title.
This implements the HTML spec's concept of "directionality of an
attribute" (which can differ from the element's direction for certain
attributes when the element has dir=auto), and uses that concept for the
directionality of the title attribute (which is the only place blink was
using the element directionality with the value of an attribute).
Fixed: 41179037
Change-Id: Ib333e9f218f0174248731758ae0ac9ab337ace7c
Commit-Queue: David Baron <dba...@chromium.org>
Reviewed-by: Di Zhang <dizh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1478010}
Files:
- M third_party/blink/renderer/core/html/html_element.cc
- M third_party/blink/renderer/core/html/html_element.h
- M third_party/blink/renderer/core/html/html_element_test.cc
- M third_party/blink/renderer/core/layout/hit_test_result.cc
- M third_party/blink/renderer/platform/runtime_enabled_features.json5
Change size: M
Delta: 5 files changed, 115 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Di Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages