[PEPC] Decouple checker for geolocation and permission element [chromium/src : main]

0 views

Skip to first unread message

Thomas Nguyen (Gerrit)

unread,

Sep 17, 2025, 5:50:01 AM (2 days ago) Sep 17

to Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Permissions Reviews, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org

Attention needed from Chromium IPC Reviews and Joey Arhar

Thomas Nguyen added 1 comment

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Thomas Nguyen . resolved

Hi Joey, could you please take a look at this CL?

The tests are generated by Gemini

Open in Gerrit

Related details

Attention is currently required from:

Chromium IPC Reviews
Joey Arhar

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

gwsq (Gerrit)

unread,

Sep 17, 2025, 5:50:43 AM (2 days ago) Sep 17

to Thomas Nguyen, Chromium IPC Reviews, Camille Lamy, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Permissions Reviews, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, dcheng+c...@chromium.org, ipc-securi...@chromium.org, kinuko...@chromium.org, mattreyno...@chromium.org

Attention needed from Camille Lamy and Joey Arhar

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: cl...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): cl...@chromium.org

Reviewer source(s):
cl...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)