Allow VTTCue OnEnter and OnExit events to fire if not within Track. [chromium/src : main]
0 views
Skip to first unread message
Thomas Guilbert (Gerrit)
Sep 17, 2025, 4:50:18 PM (2 days ago) Sep 17
to Syed AbuTalib, Thomas Guilbert, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-revie...@chromium.org, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, silv...@chromium.org
Attention needed from Syed AbuTalib
Thomas Guilbert voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Syed AbuTalib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Sep 17, 2025, 4:50:24 PM (2 days ago) Sep 17
to Syed AbuTalib, Thomas Guilbert, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-revie...@chromium.org, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, silv...@chromium.org
Attention needed from Syed AbuTalib
Thomas Guilbert voted![]( "Open in Gerrit")
| Code-Review | +0 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Syed AbuTalib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Sep 18, 2025, 5:36:24 PM (2 days ago) Sep 18
to Syed AbuTalib, Thomas Guilbert, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-revie...@chromium.org, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, silv...@chromium.org
Attention needed from Syed AbuTalib
Thomas Guilbert added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/track/text_track_cue.cc
Line 126, Patchset 6 (Parent):
if (!track() || track()->mode() == TextTrackMode::kDisabled)Thomas Guilbert . unresolved
I dug into this, and this code has been around and largely unchanged since 2012... The spec doesn't specify what should happen when there is no text track.
This change might be ok, but I think we want to preserve the behavior where a disabled TextTrackCue does not fire events.
Related details
Attention is currently required from:
- Syed AbuTalib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Syed AbuTalib (Gerrit)
Sep 18, 2025, 6:28:58 PM (2 days ago) Sep 18
to Thomas Guilbert, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-revie...@chromium.org, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, silv...@chromium.org
Syed AbuTalib added 1 comment![]( "Open in Gerrit")
File third_party/blink/renderer/core/html/track/text_track_cue.cc
Line 126, Patchset 6 (Parent):
if (!track() || track()->mode() == TextTrackMode::kDisabled)Thomas Guilbert . resolved
I dug into this, and this code has been around and largely unchanged since 2012... The spec doesn't specify what should happen when there is no text track.
This change might be ok, but I think we want to preserve the behavior where a disabled TextTrackCue does not fire events.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Thomas Guilbert (Gerrit)
Sep 18, 2025, 6:32:55 PM (2 days ago) Sep 18
to Syed AbuTalib, Thomas Guilbert, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-revie...@chromium.org, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, silv...@chromium.org
Attention needed from Syed AbuTalib
Thomas Guilbert voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Syed AbuTalib
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Syed AbuTalib (Gerrit)
Sep 18, 2025, 7:27:03 PM (2 days ago) Sep 18
to Fredrik Söderquist, Thomas Guilbert, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, srirama chandra sekhar, blink-revie...@chromium.org, feature-me...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, silv...@chromium.org
Attention needed from Fredrik Söderquist
Syed AbuTalib added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 8 (Latest):
Syed AbuTalib . resolved
I will wait for the last few trybots before I find an appropriate owner.
Related details
Attention is currently required from:
- Fredrik Söderquist
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages