Remove Blink.Canvas.RequestedImageMimeTypes histograms and related code [chromium/src : main]
0 views
Skip to first unread message
Nicolás Peña (Gerrit)
Jul 31, 2026, 3:31:50 PM (11 hours ago) Jul 31
to Dave Tapuska, Chromium Metrics Reviews, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, cblume+im...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, asvitkine...@chromium.org, mbarowsky+watc...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com
Attention needed from Dave Tapuska
Nicolás Peña voted and added 2 comments![]( "Open in Gerrit")
Votes added by Nicolás Peña
| Code-Review | +1 |
2 comments
Commit Message
File-level comment, Patchset 1 (Latest):
Nicolás Peña . unresolved
Please fix this INFO reported by Metrics: The following histograms were removed without an obsoletion message: Blink.Canva...
The following histograms were removed without an obsoletion message: Blink.Canvas.RequestedImageMimeTypes_toBlobCallback, Blink.Canvas.RequestedImageMimeTypes_toDataURL, Blink.Canvas.RequestedImageMimeTypes_convertToBlobPromise. It is preferred to add an obsoletion message when a histogram is removed: https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#add-an-obsoletion-message.
Line 9, Patchset 1 (Latest):
This CL removes the Blink.Canvas.RequestedImageMimeTypes histograms, which tracked the requested image MIME types for canvas toDataURL, toBlob, and convertToBlob operations. As a result, the EncodeReason enum and parameter are removed from ImageEncoderUtils::ToEncodingMimeType, simplifying the method signature and implementation.Nicolás Peña . unresolved
nit: format
Related details
Attention is currently required from:
- Dave Tapuska
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Jul 31, 2026, 3:39:57 PM (11 hours ago) Jul 31
to Nicolás Peña, Chromium Metrics Reviews, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, cblume+im...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, asvitkine...@chromium.org, mbarowsky+watc...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com
Dave Tapuska voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dave Tapuska
| Commit-Queue | +2 |
Please fix this INFO reported by Metrics: The following histograms were removed without an obsoletion message: Blink.Canva...
The following histograms were removed without an obsoletion message: Blink.Canvas.RequestedImageMimeTypes_toBlobCallback, Blink.Canvas.RequestedImageMimeTypes_toDataURL, Blink.Canvas.RequestedImageMimeTypes_convertToBlobPromise. It is preferred to add an obsoletion message when a histogram is removed: https://chromium.googlesource.com/chromium/src/tools/+/HEAD/metrics/histograms/README.md#add-an-obsoletion-message.
Dave Tapuska
Done
Line 9, Patchset 1:
This CL removes the Blink.Canvas.RequestedImageMimeTypes histograms, which tracked the requested image MIME types for canvas toDataURL, toBlob, and convertToBlob operations. As a result, the EncodeReason enum and parameter are removed from ImageEncoderUtils::ToEncodingMimeType, simplifying the method signature and implementation.Nicolás Peña . resolved
Dave Tapuskanit: format
Done
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 31, 2026, 4:53:05 PM (10 hours ago) Jul 31
to Dave Tapuska, Nicolás Peña, Chromium Metrics Reviews, srirama chandra sekhar, android-bu...@system.gserviceaccount.com, blink-...@chromium.org, cblume+im...@chromium.org, feature-me...@chromium.org, kinuko...@chromium.org, asvitkine...@chromium.org, mbarowsky+watc...@chromium.org, blink-rev...@chromium.org, eric.c...@apple.com
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Remove Blink.Canvas.RequestedImageMimeTypes histograms and related code
This CL removes the Blink.Canvas.RequestedImageMimeTypes histograms,
which tracked the requested image MIME types for canvas toDataURL,
toBlob, and convertToBlob operations. As a result, the EncodeReason enum
and parameter are removed from ImageEncoderUtils::ToEncodingMimeType,
simplifying the method signature and implementation.
BUG=428706237
OBSOLETE_HISTOGRAM[Blink.Canvas.RequestedImageMimeTypes_toBlobCallback=Expired
OBSOLETE_HISTOGRAM[Blink.Canvas.RequestedImageMimeTypes_toDataURL]=Expired
OBSOLETE_HISTOGRAM[Blink.Canvas.RequestedImageMimeTypes_convertToBlobPromise]=Expired
Change-Id: Ibd7f2085c125659f4c55d42618299e8d2c16e992
Reviewed-by: Nicolás Peña <n...@chromium.org>
Commit-Queue: Dave Tapuska <dtap...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1672085}
Files:
- M third_party/blink/renderer/core/html/canvas/canvas_async_blob_creator.cc
- M third_party/blink/renderer/core/html/canvas/html_canvas_element.cc
- M third_party/blink/renderer/core/html/media/html_video_element.cc
- M third_party/blink/renderer/platform/image-encoders/image_encoder_utils.cc
- M third_party/blink/renderer/platform/image-encoders/image_encoder_utils.h
- M tools/metrics/histograms/metadata/blink/enums.xml
- M tools/metrics/histograms/metadata/blink/histograms.xml
Change size: M
Delta: 7 files changed, 9 insertions(+), 103 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nicolás Peña
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages