Add !important to [inert] interactivity UA stylesheet rule [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Sep 17, 2025, 7:00:41 PM (2 days ago) Sep 17
to Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Rune Lillesveen

Mason Freed voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Rune Lillesveen
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I19fc847977f87251c4210ca1c404ac1898a0b8f5
Gerrit-Change-Number: 6961205
Gerrit-PatchSet: 2
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
Gerrit-Attention: Rune Lillesveen <fut...@chromium.org>
Gerrit-Comment-Date: Wed, 17 Sep 2025 23:00:30 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Rune Lillesveen (Gerrit)

unread,
Sep 18, 2025, 3:02:45 AM (yesterday) Sep 18
to Mason Freed, Rune Lillesveen, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org
Attention needed from Mason Freed

Rune Lillesveen voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19fc847977f87251c4210ca1c404ac1898a0b8f5
    Gerrit-Change-Number: 6961205
    Gerrit-PatchSet: 3
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-Attention: Mason Freed <mas...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Sep 2025 07:02:27 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Sep 18, 2025, 3:06:00 AM (yesterday) Sep 18
    to Mason Freed, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Add !important to [inert] interactivity UA stylesheet rule

    See this CSSWG resolution:

    - https://github.com/w3c/csswg-drafts/issues/12049#issuecomment-3303716541

    This adds a killswitch for the new behavior, which is to add
    !important to that rule.
    Bug: 408241037
    Change-Id: I19fc847977f87251c4210ca1c404ac1898a0b8f5
    Reviewed-by: Rune Lillesveen <fut...@chromium.org>
    Commit-Queue: Rune Lillesveen <fut...@chromium.org>
    Auto-Submit: Mason Freed <mas...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1517089}
    Files:
    • M third_party/blink/renderer/core/html/resources/html.css
    • M third_party/blink/renderer/platform/runtime_enabled_features.json5
    • A third_party/blink/web_tests/external/wpt/css/css-ui/inert-attribute-overriding.html
    • D third_party/blink/web_tests/external/wpt/css/css-ui/interactivity-inert-click-002.html
    • M third_party/blink/web_tests/external/wpt/css/css-ui/interactivity-inert-html-attribute-ua.html
    Change size: M
    Delta: 5 files changed, 57 insertions(+), 28 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rune Lillesveen
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19fc847977f87251c4210ca1c404ac1898a0b8f5
    Gerrit-Change-Number: 6961205
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Sep 18, 2025, 3:59:15 AM (yesterday) Sep 18
    to Mason Freed, Chromium LUCI CQ, Rune Lillesveen, chromium...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/54919

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I19fc847977f87251c4210ca1c404ac1898a0b8f5
    Gerrit-Change-Number: 6961205
    Gerrit-PatchSet: 4
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Rune Lillesveen <fut...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Sep 2025 07:59:10 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages