Implement popover for customizable combobox [chromium/src : main]

0 views

Skip to first unread message

Joey Arhar (Gerrit)

unread,

Dec 11, 2025, 6:34:33 PM (yesterday) Dec 11

to David Baron, Chromium LUCI CQ, AyeAye, blink-re...@chromium.org, browser-comp...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, blink-re...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org

Attention needed from David Baron

Joey Arhar added 1 comment

Commit Message

Line 17, Patchset 9 (Latest):logic in AutofillAgent could be tricky.

Joey Arhar . unresolved

I'd love to hear if you have any better ideas on how to do this, or thoughts on autofill in general in the case that we are using <datalist> for rendering as a popover instead of suggestions that are just passed to autofill.

For some more context, autofill controls the rendering of the "native" datalist and in some situations may combine its own suggestions with the ones provided by the datalist in the page. Here's an example where autofill puts the page's datalist suggestions and then my own email within one picker (the input is not even in a form element):
```
<input name=email list=datalist>
<datalist id=datalist>
  <option>one</option>
  <option>two</option>
</datalist>
```
https://screenshot.googleplex.com/C7AN9uDL8ep4JiG

imo, in the case where the site is making a combobox with this new feature and has its own options to autocomplete with, then we shouldn't bother trying to autofill it, which is why I implemented this patch to do so.

Open in Gerrit

Related details

Attention is currently required from:

David Baron

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages