DOM: Fix aria-expanded state for menu items [chromium/src : main]

0 views

Skip to first unread message

Dominic Farolino (Gerrit)

unread,

Dec 18, 2025, 8:43:58 AM (22 hours ago) Dec 18

to David Grogan, Chromium LUCI CQ, Mason Freed, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from David Grogan and Mason Freed

Dominic Farolino voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

David Grogan
Mason Freed

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mason Freed (Gerrit)

unread,

Dec 18, 2025, 2:30:29 PM (17 hours ago) Dec 18

to Dominic Farolino, David Grogan, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, abigailbk...@google.com, blink-rev...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from David Grogan and Dominic Farolino

Mason Freed voted and added 2 comments

Votes added by Mason Freed

Code-Review

2 comments

Patchset-level comments

File-level comment, Patchset 4 (Latest):

Mason Freed . resolved

LGTM, just one nit.

File third_party/blink/renderer/core/html/html_collection.cc

Line 280, Patchset 4 (Latest): return invoker->commandForElement() != nullptr;

Mason Freed . unresolved

nit: I'd remove `!= nullptr` from all of these.