[Blink] Move ImageBitmap resource provider from CRCHost to context [chromium/src : main]
0 views
Skip to first unread message
Vasiliy Telezhnikov (Gerrit)
Jun 24, 2025, 7:45:17 AMJun 24
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Colin Blundell
Vasiliy Telezhnikov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Vasiliy Telezhnikov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Colin Blundell
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Colin Blundell (Gerrit)
Jun 25, 2025, 2:22:26 AMJun 25
to Colin Blundell, Vasiliy Telezhnikov, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Colin Blundell voted and added 1 comment![]( "Open in Gerrit")
Votes added by Colin Blundell
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 25, 2025, 2:57:27 AMJun 25
to Colin Blundell, Vasiliy Telezhnikov, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[Blink] Move ImageBitmap resource provider from CRCHost to context
The only subtle part is ensuring that the resource provider continues to
be reset at every relevant place where
OffscreenCanvas::DiscardResources() is called (note:
ImageBitmapRenderingContextBase sets a resource provider *only* for
offscreen canvas).
They are:
* Dispose() [1]
* from within ImageBitmap context itself in Reset()
The other calls are all for other context types and/or
HTMLCanvasElement.
[1] https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/offscreencanvas/offscreen_canvas.cc;l=123?q=offscreen_canvas.cc&ss=chromium
Bug: 352263194
Change-Id: Ia8dc58516f1c89e1ac76b6335c118c3f759be95f
Reviewed-by: Vasiliy Telezhnikov <vas...@chromium.org>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1478378}
Files:
- M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.cc
- M third_party/blink/renderer/core/html/canvas/canvas_rendering_context_host.h
- M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.cc
- M third_party/blink/renderer/modules/canvas/imagebitmap/image_bitmap_rendering_context_base.h
Change size: M
Delta: 4 files changed, 17 insertions(+), 34 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Vasiliy Telezhnikov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages