[v8] Migrate to Get/SetPrototype() and Holder() from ..V2 versions [chromium/src : main]

0 views
Skip to first unread message

Igor Sheludko (Gerrit)

unread,
7:27 AM (16 hours ago) 7:27 AM
to Michael Lippautz, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Michael Lippautz

Igor Sheludko voted and added 1 comment

Votes added by Igor Sheludko

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Igor Sheludko . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Michael Lippautz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Iaf652054d61c786853e5e6b83b49ed600759af86
Gerrit-Change-Number: 7642968
Gerrit-PatchSet: 1
Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Michael Lippautz <mlip...@chromium.org>
Gerrit-Comment-Date: Fri, 06 Mar 2026 12:27:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Lippautz (Gerrit)

unread,
11:02 AM (12 hours ago) 11:02 AM
to Igor Sheludko, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
Attention needed from Igor Sheludko

Michael Lippautz voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Igor Sheludko
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf652054d61c786853e5e6b83b49ed600759af86
    Gerrit-Change-Number: 7642968
    Gerrit-PatchSet: 1
    Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 16:02:26 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Igor Sheludko (Gerrit)

    unread,
    12:10 PM (11 hours ago) 12:10 PM
    to Devlin Cronin, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
    Attention needed from Devlin Cronin

    Igor Sheludko added 1 comment

    Patchset-level comments
    Igor Sheludko . resolved

    Devlin, PTAL at extensions and renderer

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Devlin Cronin
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf652054d61c786853e5e6b83b49ed600759af86
    Gerrit-Change-Number: 7642968
    Gerrit-PatchSet: 1
    Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 17:10:22 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Igor Sheludko (Gerrit)

    unread,
    12:16 PM (11 hours ago) 12:16 PM
    to Kent Tamura, Devlin Cronin, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
    Attention needed from Devlin Cronin and Kent Tamura

    Igor Sheludko added 1 comment

    Patchset-level comments
    Igor Sheludko . resolved

    Kent, PTAL at third_party/blink/renderer/extensions

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Devlin Cronin
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf652054d61c786853e5e6b83b49ed600759af86
    Gerrit-Change-Number: 7642968
    Gerrit-PatchSet: 1
    Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 17:16:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Devlin Cronin (Gerrit)

    unread,
    4:02 PM (7 hours ago) 4:02 PM
    to Igor Sheludko, Devlin Cronin, Kent Tamura, Michael Lippautz, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, kinuko...@chromium.org, oshima...@chromium.org
    Attention needed from Igor Sheludko and Kent Tamura

    Devlin Cronin voted and added 1 comment

    Votes added by Devlin Cronin

    Code-Review+1

    1 comment

    Patchset-level comments
    Devlin Cronin . resolved

    extensions LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Igor Sheludko
    • Kent Tamura
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Iaf652054d61c786853e5e6b83b49ed600759af86
    Gerrit-Change-Number: 7642968
    Gerrit-PatchSet: 1
    Gerrit-Owner: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Devlin Cronin <rdevlin...@chromium.org>
    Gerrit-Reviewer: Igor Sheludko <ish...@chromium.org>
    Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
    Gerrit-Reviewer: Michael Lippautz <mlip...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Igor Sheludko <ish...@chromium.org>
    Gerrit-Attention: Kent Tamura <tk...@chromium.org>
    Gerrit-Comment-Date: Fri, 06 Mar 2026 21:02:30 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages