[PDF Ink Signatures] Insert /ActualText for text annotations [chromium/src : main]

0 views

Skip to first unread message

April Kallmeyer (Gerrit)

unread,

May 29, 2026, 1:25:34 PM (3 days ago) May 29

to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, ipc-securi...@chromium.org, pdf-r...@chromium.org

Attention needed from Lei Zhang

April Kallmeyer voted Commit-Queue+1

Commit-Queue

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

April Kallmeyer (Gerrit)

unread,

May 29, 2026, 3:54:10 PM (3 days ago) May 29

Attention needed from Lei Zhang

April Kallmeyer added 1 comment

File pdf/pdf_ink_text.cc

Line 234, Patchset 8 (Latest):

      const uint32_t last_index =
          i + 1 < text_run->typeface_runs.size() &&
                  !text_run->typeface_runs[i + 1]->glyphs.empty()
              ? text_run->typeface_runs[i + 1]->glyphs.front()->character_index
              : text_run->text.size();

April Kallmeyer . resolved

This complexity would go away with https://chromium-review.googlesource.com/c/chromium/src/+/7829334, it would just be in the helper function once.