bindings: Implement web_idl.ObservableArray in web_idl_database [chromium/src : main]
Yuki Shiino (Gerrit)
Attention is currently required from: Kenichi Ishibashi.
Yuki Shiino would like Kenichi Ishibashi to review this change.
bindings: Implement web_idl.ObservableArray in web_idl_database
Implements a class to represent an observable array of a certain
element type in order to help bindings code generation.
Instances of web_idl.ObservableArray have
- web_idl.IdlType that represents the observable array
- list of web_idl.Attribute that use the observable array type
Change-Id: I0b6168ee08ca53b344a73c906418240ef0c70700
Bug: 1201744
---
M third_party/blink/renderer/bindings/scripts/web_idl/__init__.py
M third_party/blink/renderer/bindings/scripts/web_idl/database.py
M third_party/blink/renderer/bindings/scripts/web_idl/idl_compiler.py
M third_party/blink/renderer/bindings/scripts/web_idl/idl_type.py
A third_party/blink/renderer/bindings/scripts/web_idl/observable_array.py
5 files changed, 93 insertions(+), 1 deletion(-)
To view, visit change 3159922. To unsubscribe, or for help writing mail filters, visit settings.
Yuki Shiino (Gerrit)
Attention is currently required from: Kenichi Ishibashi.
1 comment:
Patchset:
Would you review this patch?
Just FYI, I'm now prototyping IDL observable array at:
https://chromium-review.googlesource.com/c/chromium/src/+/3156769
and I first thought that we can implement it with C++ template, but it turns out that it'd be hard (or messy) to do so. So, now I'm now going to use code generation for observable arrays in addition to C++ template.
To view, visit change 3159922. To unsubscribe, or for help writing mail filters, visit settings.
Kenichi Ishibashi (Gerrit)
Attention is currently required from: Yuki Shiino.
Patch set 5:Code-Review +1
1 comment:
Patchset:
lgtm. We need more code to generate bindings for observable arrays. Is my understanding correct?
To view, visit change 3159922. To unsubscribe, or for help writing mail filters, visit settings.
Yuki Shiino (Gerrit)
1 comment:
Patchset:
lgtm. We need more code to generate bindings for observable arrays. […]
Yes, right.
To view, visit change 3159922. To unsubscribe, or for help writing mail filters, visit settings.
Yuki Shiino (Gerrit)
Patch set 5:Commit-Queue +2
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
bindings: Implement web_idl.ObservableArray in web_idl_database
Implements a class to represent an observable array of a certain
element type in order to help bindings code generation.
Instances of web_idl.ObservableArray have
- web_idl.IdlType that represents the observable array
- list of web_idl.Attribute that use the observable array type
Change-Id: I0b6168ee08ca53b344a73c906418240ef0c70700
Bug: 1201744
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3159922
Reviewed-by: Kenichi Ishibashi <ba...@chromium.org>
Commit-Queue: Yuki Shiino <yukis...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922041}
---
M third_party/blink/renderer/bindings/scripts/web_idl/__init__.py
M third_party/blink/renderer/bindings/scripts/web_idl/database.py
M third_party/blink/renderer/bindings/scripts/web_idl/idl_compiler.py
M third_party/blink/renderer/bindings/scripts/web_idl/idl_type.py
A third_party/blink/renderer/bindings/scripts/web_idl/observable_array.py
5 files changed, 121 insertions(+), 1 deletion(-)