[wip] add assume [chromium/src : main]

0 views

Skip to first unread message

Steinar H Gunderson (Gerrit)

unread,

Dec 18, 2025, 3:53:14 PM (15 hours ago) Dec 18

to Raphael Kubo da Costa, chromium...@chromium.org, (Julie)Jeongeun Kim, Menard, Alexis, Kentaro Hara, Kevin Babbitt, blink-re...@chromium.org, kinuko...@chromium.org, lucasrada...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, blink-rev...@chromium.org, apavlo...@chromium.org, francisjp...@google.com, josiah...@chromium.org, blink-revie...@chromium.org, gavinp...@chromium.org, blink-re...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, mac-r...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, dtseng...@chromium.org, blink-...@chromium.org, loading-rev...@chromium.org

Steinar H Gunderson has uploaded the change for review

Commit message

[wip] add assume

Change-Id: I21857f6058f099ac3c0668465f5e3d9fdca26246

Change diff

diff --git a/third_party/blink/renderer/platform/wtf/text/string_table.h b/third_party/blink/renderer/platform/wtf/text/string_table.h
index 6c5e61d..0a77036 100644
--- a/third_party/blink/renderer/platform/wtf/text/string_table.h
+++ b/third_party/blink/renderer/platform/wtf/text/string_table.h
@@ -23,6 +23,8 @@
   static StringHandle Compress(StringImpl* ptr) {
     uint32_t val = static_cast<uint32_t>(reinterpret_cast<uintptr_t>(ptr));
     DCHECK_EQ(Uncompress(StringHandle{val}), ptr);
+    [[assume((uint64_t(static_cast<int32_t>(val)) & GetMask()) ==
+             reinterpret_cast<uintptr_t>(ptr))]];
     return StringHandle{val};
   }

Change information

Files:

M third_party/blink/renderer/platform/wtf/text/string_table.h

Change size: XS

Delta: 1 file changed, 2 insertions(+), 0 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

chromeperf@appspot.gserviceaccount.com (Gerrit)

unread,

Dec 18, 2025, 4:52:25 PM (14 hours ago) Dec 18

to Steinar H Gunderson, Menard, Alexis, chromium...@chromium.org, Kentaro Hara, (Julie)Jeongeun Kim, Kevin Babbitt, Raphael Kubo da Costa, abigailbk...@google.com, apavlo...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, gavinp...@chromium.org, josiah...@chromium.org, kinuko...@chromium.org, kyungjunle...@google.com, loading-rev...@chromium.org, lucasrada...@google.com, mac-r...@chromium.org, nektar...@chromium.org, yuzo+...@chromium.org

Attention needed from Steinar H Gunderson