WebVTT: Apply display:ruby and display:ruby-text [chromium/src : main]

0 views
Skip to first unread message

Kent Tamura (Gerrit)

unread,
Apr 18, 2024, 5:41:57 PMApr 18
to Kent Tamura, Koji Ishii, Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, silv...@chromium.org, zol...@webkit.org
Attention needed from Koji Ishii

Kent Tamura voted and added 1 comment

Votes added by Kent Tamura

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Kent Tamura . resolved

kojii@, would you review this please?

Open in Gerrit

Related details

Attention is currently required from:
  • Koji Ishii
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8cc94aa3718e74aba224b94d611c4dd93d8e8790
Gerrit-Change-Number: 5465262
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Koji Ishii <ko...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Apr 2024 21:41:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Koji Ishii (Gerrit)

unread,
Apr 19, 2024, 12:19:09 AMApr 19
to Kent Tamura, Chromium LUCI CQ, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, silv...@chromium.org, zol...@webkit.org
Attention needed from Kent Tamura

Koji Ishii voted and added 1 comment

Votes added by Koji Ishii

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Koji Ishii . resolved

lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Kent Tamura
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8cc94aa3718e74aba224b94d611c4dd93d8e8790
Gerrit-Change-Number: 5465262
Gerrit-PatchSet: 3
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Kent Tamura <tk...@chromium.org>
Gerrit-Comment-Date: Fri, 19 Apr 2024 04:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Apr 19, 2024, 12:23:23 AMApr 19
to Kent Tamura, Koji Ishii, chromium...@chromium.org, Fredrik Söderquist, srirama chandra sekhar, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-...@chromium.org, eric.c...@apple.com, gl...@chromium.org, jmedle...@chromium.org, kinuko...@chromium.org, silv...@chromium.org, zol...@webkit.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
WebVTT: Apply display:ruby and display:ruby-text

This CL should have no behavior changes.
Bug: 40592240
Change-Id: I8cc94aa3718e74aba224b94d611c4dd93d8e8790
Auto-Submit: Kent Tamura <tk...@chromium.org>
Reviewed-by: Koji Ishii <ko...@chromium.org>
Commit-Queue: Koji Ishii <ko...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1289748}
Files:
  • M third_party/blink/renderer/core/html/track/vtt/vtt_element.cc
  • M third_party/blink/renderer/core/layout/layout_theme.cc
  • M third_party/blink/renderer/platform/runtime_enabled_features.json5
  • M third_party/blink/web_tests/TestExpectations
Change size: S
Delta: 4 files changed, 23 insertions(+), 8 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Koji Ishii
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8cc94aa3718e74aba224b94d611c4dd93d8e8790
Gerrit-Change-Number: 5465262
Gerrit-PatchSet: 4
Gerrit-Owner: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>
Gerrit-Reviewer: Koji Ishii <ko...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages