Return the document charset for unknown attribute values [chromium/src : main]
Xiaocheng Hu (Gerrit)
Attention is currently required from: Yash Joshi.
1 comment:
File third_party/blink/renderer/core/html/link_resource.cc:
charset.empty() && GetDocument().GetFrame() &&
(WTF::TextEncoding(charset).IsValid())The correct condition seems to be
```
if ((charset.empty() || !WTF::TextEncoding(charset).IsValid()) &&
GetDocument().GetFrame()) {
return GetDocument().Encoding();
}
```
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Yash Joshi (Gerrit)
Attention is currently required from: Xiaocheng Hu.
1 comment:
File third_party/blink/renderer/core/html/link_resource.cc:
charset.empty() && GetDocument().GetFrame() &&
(WTF::TextEncoding(charset).IsValid())
The correct condition seems to be […]
Tried implementing the suggestion and the build goes successful after that but the test at http://wpt.live/css/css-syntax/charset/page-windows-1251-charset-attribute-bogus.html still fails on the new build.
Would appreciate if you could point me to what may be causing this.
Thanks a lot for your help btw :)
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Xiaocheng Hu (Gerrit)
Attention is currently required from: Yash Joshi.
1 comment:
File third_party/blink/renderer/core/html/link_resource.cc:
charset.empty() && GetDocument().GetFrame() &&
(WTF::TextEncoding(charset).IsValid())
Tried implementing the suggestion and the build goes successful after that but the test at http://wp […]
Could you update this patch as suggested, so that I can trigger a test run here and see the result?
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Yash Joshi (Gerrit)
1 comment:
Patchset:
Sorry for the delay. Have uploaded the asked patchset
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Yash Joshi (Gerrit)
Attention is currently required from: Xiaocheng Hu.
1 comment:
File third_party/blink/renderer/core/html/link_resource.cc:
charset.empty() && GetDocument().GetFrame() &&
(WTF::TextEncoding(charset).IsValid())
Could you update this patch as suggested, so that I can trigger a test run here and see the result?
Done
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Xiaocheng Hu (Gerrit)
Attention is currently required from: Yash Joshi.
1 comment:
Patchset:
Weird... The test passes on our try bots (even without this patch) but fails with the production build. I'll take a look
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Xiaocheng Hu (Gerrit)
Patchset:
Weird... […]
I looked into this and there should be some other issues, see notes at https://bugs.chromium.org/p/chromium/issues/detail?id=1215064#c5.
More investigation is needed, but this might no longer be a beginner-level issue. Feel free if you want to stop working on it.
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Yash Joshi (Gerrit)
Attention is currently required from: Xiaocheng Hu.
1 comment:
Patchset:
I looked into this and there should be some other issues, see notes at https://bugs.chromium. […]
No issues then.
I am very grateful for your time and patience
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Xiaocheng Hu (Gerrit)
Attention is currently required from: Yash Joshi.
1 comment:
Patchset:
No issues then. […]
Sure. Please set WIP/abandon this patch if you are no longer working on it, so that it will be removed from my review queue.
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.
Yash Joshi (Gerrit)
Yash Joshi abandoned this change.
To view, visit change 4157951. To unsubscribe, or for help writing mail filters, visit settings.