Fix double-NUL terminated string iteration in TaskTraceErrorCallback [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Jan 16, 2026, 6:40:08 PMJan 16
to Daniel Cheng, Sergei Glazunov, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, fuzzin...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, webap...@microsoft.com
Attention needed from Sergei Glazunov

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Sergei Glazunov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib3fdc379d6ddc328288a3612c98fb225c95e0367
Gerrit-Change-Number: 7489281
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Sergei Glazunov <glaz...@google.com>
Gerrit-CC: Luna Lu <loon...@chromium.org>
Gerrit-Attention: Sergei Glazunov <glaz...@google.com>
Gerrit-Comment-Date: Fri, 16 Jan 2026 23:39:58 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Jan 23, 2026, 2:48:37 PMJan 23
to Daniel Cheng, Sergei Glazunov, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, fuzzin...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, webap...@microsoft.com
Attention needed from Daniel Cheng and Sergei Glazunov

Tom Sepez voted and added 1 comment

Votes added by Tom Sepez

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Tom Sepez . resolved

It fixes the bug, but is it what we want? Unsure of downstream consequences ...

Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
  • Sergei Glazunov
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib3fdc379d6ddc328288a3612c98fb225c95e0367
    Gerrit-Change-Number: 7489281
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Sergei Glazunov <glaz...@google.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-Attention: Sergei Glazunov <glaz...@google.com>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Fri, 23 Jan 2026 19:48:25 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Jan 23, 2026, 4:04:55 PMJan 23
    to Daniel Cheng, Tom Sepez, Sergei Glazunov, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, fuzzin...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, webap...@microsoft.com
    Attention needed from Sergei Glazunov

    Daniel Cheng added 1 comment

    Patchset-level comments
    Tom Sepez . resolved

    It fixes the bug, but is it what we want? Unsure of downstream consequences ...

    Daniel Cheng

    I think (but I'm not 100% sure) this might print out things like inlined stack frames and such too.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sergei Glazunov
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib3fdc379d6ddc328288a3612c98fb225c95e0367
    Gerrit-Change-Number: 7489281
    Gerrit-PatchSet: 2
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Sergei Glazunov <glaz...@google.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-Attention: Sergei Glazunov <glaz...@google.com>
    Gerrit-Comment-Date: Fri, 23 Jan 2026 21:04:43 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Tom Sepez <tse...@chromium.org>
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Jan 27, 2026, 1:21:28 AMJan 27
    to Daniel Cheng, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Peter Williamson, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Tom Sepez, Sergei Glazunov, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, aixba+wat...@chromium.org, ajayramamurth...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitki...@chromium.org, borealis-re...@google.com, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, marq+...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, translat...@chromium.org, xlythe+wa...@google.com, zelin+watch-we...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, fuzzin...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, webap...@microsoft.com
    Attention needed from Sergei Glazunov

    Daniel Cheng voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sergei Glazunov
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib3fdc379d6ddc328288a3612c98fb225c95e0367
    Gerrit-Change-Number: 7489281
    Gerrit-PatchSet: 3
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Sergei Glazunov <glaz...@google.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
    Gerrit-CC: Luna Lu <loon...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-CC: Peter Williamson <pet...@chromium.org>
    Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
    Gerrit-CC: Simon Hangl <sim...@google.com>
    Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
    Gerrit-Attention: Sergei Glazunov <glaz...@google.com>
    Gerrit-Comment-Date: Tue, 27 Jan 2026 06:21:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Daniel Cheng (Gerrit)

    unread,
    Jan 27, 2026, 10:27:18 AMJan 27
    to Daniel Cheng, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Peter Williamson, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Tom Sepez, Sergei Glazunov, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, aixba+wat...@chromium.org, ajayramamurth...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitki...@chromium.org, borealis-re...@google.com, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, marq+...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, translat...@chromium.org, xlythe+wa...@google.com, zelin+watch-we...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, fuzzin...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, webap...@microsoft.com
    Gerrit-Comment-Date: Tue, 27 Jan 2026 15:27:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Sergei Glazunov (Gerrit)

    unread,
    Jan 27, 2026, 10:32:01 AMJan 27
    to Daniel Cheng, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Peter Williamson, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Tom Sepez, Chromium LUCI CQ, chromium...@chromium.org, Luna Lu, aixba+wat...@chromium.org, ajayramamurth...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitki...@chromium.org, borealis-re...@google.com, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, marq+...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, translat...@chromium.org, xlythe+wa...@google.com, zelin+watch-we...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, fuzzin...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, webap...@microsoft.com
    Attention needed from Daniel Cheng

    Sergei Glazunov voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Comment-Date: Tue, 27 Jan 2026 15:31:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 27, 2026, 11:42:42 AMJan 27
    to Daniel Cheng, Sergei Glazunov, Enterprise Policy Reviews, Andrew Rayskiy, Peter Beverloo, Peter Williamson, prerendering-reviews, Rijubrata Bhaumik, Simon Hangl, Tom Sepez, chromium...@chromium.org, Luna Lu, aixba+wat...@chromium.org, ajayramamurth...@google.com, alexmo...@chromium.org, alexmt...@chromium.org, apaselti...@chromium.org, asvitki...@chromium.org, borealis-re...@google.com, chfreme...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, cros-ed...@google.com, crost...@chromium.org, dclasson+w...@google.com, dewitt...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watc...@chromium.org, druber...@chromium.org, eme-r...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, filesapp...@chromium.org, gavin...@chromium.org, hais+wat...@google.com, halliwe...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, ios-revie...@chromium.org, ios-r...@chromium.org, ipc-securi...@chromium.org, jackshira+w...@google.com, japhet+...@chromium.org, kinuko+...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, marq+...@chromium.org, mek+w...@chromium.org, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, nator...@chromium.org, navigation...@chromium.org, net-r...@chromium.org, network-ser...@chromium.org, oshima...@chromium.org, philli...@chromium.org, pushi+wat...@google.com, rayanka...@chromium.org, rginda...@chromium.org, rrsilva+wat...@google.com, storage...@chromium.org, suetfei+wa...@google.com, tbarzi...@chromium.org, tburkar...@chromium.org, translat...@chromium.org, xlythe+wa...@google.com, zelin+watch-we...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, chasej...@chromium.org, dmurph+watch...@chromium.org, fuzzin...@chromium.org, iclella...@chromium.org, jmedle...@chromium.org, webap...@microsoft.com

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix double-NUL terminated string iteration in TaskTraceErrorCallback

    Otherwise the loop always terminates after the first entry: `strlen()`
    does not include the terminating NUL, which leaves `ptr` pointing at NUL
    at the beginning of the next loop.
    Fixed: 474407531
    Change-Id: Ib3fdc379d6ddc328288a3612c98fb225c95e0367
    Commit-Queue: Daniel Cheng <dch...@chromium.org>
    Reviewed-by: Tom Sepez <tse...@chromium.org>
    Reviewed-by: Sergei Glazunov <glaz...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1575271}
    Files:
    • M base/debug/asan_service.cc
    Change size: XS
    Delta: 1 file changed, 2 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Sergei Glazunov, +1 by Tom Sepez
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ib3fdc379d6ddc328288a3612c98fb225c95e0367
    Gerrit-Change-Number: 7489281
    Gerrit-PatchSet: 4
    Gerrit-Owner: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: Sergei Glazunov <glaz...@google.com>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-CC: Andrew Rayskiy <green...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages