[CoCE] Usermedia element with constraints should keep working in legacy mode [chromium/src : refs/branch-heads/7766]

0 views
Skip to first unread message

Krishna Govind (Gerrit)

unread,
Apr 1, 2026, 6:09:08 PM (12 hours ago) Apr 1
to Ravjit Uppal, Chromium LUCI CQ, srirama chandra sekhar, AyeAye, eric.c...@apple.com, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Ravjit Uppal

Krishna Govind voted

Code-Review+1
Owners-Override+1
Open in Gerrit

Related details

Attention is currently required from:
  • Ravjit Uppal
Submit Requirements:
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedLint
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7766
Gerrit-Change-Id: Ib213b876a50abbb0a4cecd79279c80042dd7bbb4
Gerrit-Change-Number: 7723338
Gerrit-PatchSet: 2
Gerrit-Owner: Ravjit Uppal <rav...@chromium.org>
Gerrit-Reviewer: Krishna Govind <gov...@chromium.org>
Gerrit-Reviewer: Ravjit Uppal <rav...@chromium.org>
Gerrit-CC: srirama chandra sekhar <srir...@samsung.com>
Gerrit-Attention: Ravjit Uppal <rav...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 22:08:57 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Krishna Govind (Gerrit)

unread,
Apr 1, 2026, 6:09:24 PM (12 hours ago) Apr 1
to Ravjit Uppal, Chromium LUCI CQ, srirama chandra sekhar, AyeAye, eric.c...@apple.com, feature-me...@chromium.org, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Krishna Govind submitted the change

Change information

Commit message:
[CoCE] Usermedia element with constraints should keep working in legacy mode

If no constraints are set on the usermedia element, it should keep its
status quo. That is the stream attribute should never be initialized and
the onstream event should never be fired.

The usermedia element should not regress for its existing users.

(cherry picked from commit a9a3ad12104e89d6c618109b8beca54b2ced6d31)
Bug: 494481589
Change-Id: Ib213b876a50abbb0a4cecd79279c80042dd7bbb4
Commit-Queue: Ravjit Uppal <rav...@chromium.org>
Reviewed-by: Joey Arhar <jar...@chromium.org>
Cr-Original-Commit-Position: refs/heads/main@{#1608750}
Reviewed-by: Krishna Govind <gov...@chromium.org>
Owners-Override: Krishna Govind <gov...@chromium.org>
Cr-Commit-Position: refs/branch-heads/7766@{#7}
Cr-Branched-From: cc10483432346c1df9714af01aee321636072e6f-refs/heads/main@{#1607787}
Files:
  • M chrome/test/data/permissions/permission_element.html
  • M third_party/blink/renderer/core/html/html_user_media_element.cc
  • M third_party/blink/renderer/core/html/html_user_media_element.h
  • M third_party/blink/renderer/core/html/html_user_media_element_test.cc
  • A third_party/blink/web_tests/external/wpt/html/semantics/permission-element/usermedia/usermedia-no-constraints.tentative.html
Change size: M
Delta: 5 files changed, 138 insertions(+), 3 deletions(-)
Branch: refs/branch-heads/7766
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Krishna Govind
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: refs/branch-heads/7766
Gerrit-Change-Id: Ib213b876a50abbb0a4cecd79279c80042dd7bbb4
Gerrit-Change-Number: 7723338
Gerrit-PatchSet: 3
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages