Use !important in -internal-auto-base() [chromium/src : main]

1 view
Skip to first unread message

Joey Arhar (Gerrit)

unread,
Jul 28, 2025, 11:51:28 AM7/28/25
to Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Anders Hartvoll Ruud

Joey Arhar added 1 comment

File third_party/blink/renderer/core/html/resources/html.css
Line 985, Patchset 1 (Latest): line-height: -internal-auto-base(initial !important, initial);
Joey Arhar . unresolved

I should probably just file a bug for this, but it seems like !important doesn't work inside -internal-auto-base(). Is this fixable?

Open in Gerrit

Related details

Attention is currently required from:
  • Anders Hartvoll Ruud
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I77e960ddb3cbb4816e2b3773bade83037af43cdd
Gerrit-Change-Number: 6781006
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Comment-Date: Mon, 28 Jul 2025 15:51:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Anders Hartvoll Ruud (Gerrit)

unread,
Jul 30, 2025, 3:58:49 AM7/30/25
to AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar

Anders Hartvoll Ruud added 1 comment

File third_party/blink/renderer/core/html/resources/html.css
Line 985, Patchset 1 (Latest): line-height: -internal-auto-base(initial !important, initial);
Joey Arhar . unresolved

I should probably just file a bug for this, but it seems like !important doesn't work inside -internal-auto-base(). Is this fixable?

Anders Hartvoll Ruud

It's intentional ... `!important` is an aspect of the declaration as a whole, not something that can appear via a substitution.

Is this fixable?

No.

Your best bet is probably doing it "by hand" in StyleAdjuster.

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I77e960ddb3cbb4816e2b3773bade83037af43cdd
Gerrit-Change-Number: 6781006
Gerrit-PatchSet: 1
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Anders Hartvoll Ruud <and...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 30 Jul 2025 07:58:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jan 22, 2026, 10:41:15 AMJan 22
to Anders Hartvoll Ruud, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org

Joey Arhar abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages