[tracing] Replace TRACE_EVENT_CATEGORY_GROUP_ENABLED with TRACE_EVENT_CATEGORY_ENABLED in blink [chromium/src : main]

0 views
Skip to first unread message

Scott Haseley (Gerrit)

unread,
Jan 8, 2026, 12:13:15 PM (4 days ago) Jan 8
to Etienne Pierre-Doray, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org
Attention needed from Etienne Pierre-Doray

Scott Haseley added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Scott Haseley . resolved

Hey Etienne, WDYT? I was going to change this in a few places, but figured I'd just do all of blink while I'm at.

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1ff8265f25ceded3939e1920d7178c5409cfe735
Gerrit-Change-Number: 7412509
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Haseley <shas...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 17:13:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jan 9, 2026, 2:50:32 PM (3 days ago) Jan 9
to Scott Haseley, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org
Attention needed from Scott Haseley

Etienne Pierre-Doray added 1 comment

Patchset-level comments
Etienne Pierre-Doray . resolved

Nice, thanks!
I hope you used gemini to make these changes :p

Open in Gerrit

Related details

Attention is currently required from:
  • Scott Haseley
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I1ff8265f25ceded3939e1920d7178c5409cfe735
Gerrit-Change-Number: 7412509
Gerrit-PatchSet: 2
Gerrit-Owner: Scott Haseley <shas...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Menard, Alexis <alexis...@intel.com>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Scott Haseley <shas...@chromium.org>
Gerrit-Comment-Date: Fri, 09 Jan 2026 19:50:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jan 9, 2026, 2:50:37 PM (3 days ago) Jan 9
to Scott Haseley, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org
Attention needed from Scott Haseley

Etienne Pierre-Doray voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Scott Haseley
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ff8265f25ceded3939e1920d7178c5409cfe735
    Gerrit-Change-Number: 7412509
    Gerrit-PatchSet: 2
    Gerrit-Owner: Scott Haseley <shas...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Scott Haseley <shas...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 19:50:29 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Jan 9, 2026, 2:54:36 PM (3 days ago) Jan 9
    to Scott Haseley, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org
    Attention needed from Scott Haseley

    Etienne Pierre-Doray added 1 comment

    Patchset-level comments
    Etienne Pierre-Doray . resolved

    You could also similarly migrate TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED to TRACE_EVENT_CATEGORY_ENABLED

    Gerrit-Comment-Date: Fri, 09 Jan 2026 19:54:29 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Scott Haseley (Gerrit)

    unread,
    Jan 9, 2026, 4:03:14 PM (3 days ago) Jan 9
    to Philip Rogers, Etienne Pierre-Doray, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org
    Attention needed from Philip Rogers

    Scott Haseley added 2 comments

    Patchset-level comments
    Scott Haseley . resolved

    pdr: mind reviewing for blink/common? Thanks.

    Etienne Pierre-Doray . resolved

    You could also similarly migrate TRACE_EVENT_API_GET_CATEGORY_GROUP_ENABLED to TRACE_EVENT_CATEGORY_ENABLED

    Scott Haseley

    Cool, I was gonna ask you about that one!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Philip Rogers
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ff8265f25ceded3939e1920d7178c5409cfe735
    Gerrit-Change-Number: 7412509
    Gerrit-PatchSet: 2
    Gerrit-Owner: Scott Haseley <shas...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Philip Rogers <p...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 21:03:03 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Philip Rogers (Gerrit)

    unread,
    Jan 9, 2026, 4:05:34 PM (3 days ago) Jan 9
    to Scott Haseley, Etienne Pierre-Doray, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org
    Attention needed from Scott Haseley

    Philip Rogers voted and added 1 comment

    Votes added by Philip Rogers

    Code-Review+1

    1 comment

    Patchset-level comments
    Philip Rogers . resolved

    blink/common LGTM

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Scott Haseley
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ff8265f25ceded3939e1920d7178c5409cfe735
    Gerrit-Change-Number: 7412509
    Gerrit-PatchSet: 2
    Gerrit-Owner: Scott Haseley <shas...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Menard, Alexis <alexis...@intel.com>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: Scott Haseley <shas...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 21:05:18 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Scott Haseley (Gerrit)

    unread,
    Jan 9, 2026, 4:14:39 PM (3 days ago) Jan 9
    to Philip Rogers, Etienne Pierre-Doray, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org

    Scott Haseley voted and added 1 comment

    Votes added by Scott Haseley

    Commit-Queue+2

    1 comment

    Patchset-level comments
    Scott Haseley . resolved

    Thanks!

    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Fri, 09 Jan 2026 21:14:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Scott Haseley (Gerrit)

    unread,
    Jan 9, 2026, 5:50:52 PM (3 days ago) Jan 9
    to Philip Rogers, Etienne Pierre-Doray, Chromium LUCI CQ, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org

    Scott Haseley voted Commit-Queue+2

    Commit-Queue+2
    Gerrit-Comment-Date: Fri, 09 Jan 2026 22:50:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 9, 2026, 6:08:44 PM (3 days ago) Jan 9
    to Scott Haseley, Philip Rogers, Etienne Pierre-Doray, Menard, Alexis, chromium...@chromium.org, Dirk Schulze, Olga Gerchikov, Kentaro Hara, Raphael Kubo da Costa, Stephen Chenney, blink-revie...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, chikamu...@chromium.org, core-timi...@chromium.org, devtools-re...@chromium.org, drott+bl...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org, scheduler-...@chromium.org, speed-metrics...@chromium.org, tommyw+w...@chromium.org, zol...@webkit.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Replace TRACE_EVENT_CATEGORY_GROUP_ENABLED with TRACE_EVENT_CATEGORY_ENABLED in blink

    Drive-by cleanup, changing TRACE_EVENT_CATEGORY_GROUP_ENABLED to
    TRACE_EVENT_CATEGORY_ENABLED in blink. This is a bit cleaner since it
    avoids having to use a temporary in a bunch of cases.
    Bug: None
    Change-Id: I1ff8265f25ceded3939e1920d7178c5409cfe735
    Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
    Reviewed-by: Philip Rogers <p...@chromium.org>
    Commit-Queue: Scott Haseley <shas...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1567243}
    Files:
    • M third_party/blink/common/page/content_to_visible_time_reporter.cc
    • M third_party/blink/renderer/core/animation/animation.cc
    • M third_party/blink/renderer/core/dom/document.cc
    • M third_party/blink/renderer/core/frame/animation_frame_timing_monitor.cc
    • M third_party/blink/renderer/core/html/parser/html_document_parser.cc
    • M third_party/blink/renderer/core/html/parser/html_document_parser_fastpath.cc
    • M third_party/blink/renderer/core/inspector/inspector_trace_events.cc
    • M third_party/blink/renderer/core/layout/layout_image.cc
    • M third_party/blink/renderer/core/layout/layout_shift_tracker.cc
    • M third_party/blink/renderer/core/paint/timing/paint_timing_detector.h
    • M third_party/blink/renderer/core/paint/timing/paint_timing_visualizer.cc
    • M third_party/blink/renderer/core/timing/performance_user_timing.cc
    • M third_party/blink/renderer/modules/mediastream/web_media_player_ms.cc
    • M third_party/blink/renderer/modules/mediastream/web_media_player_ms_compositor.cc
    • M third_party/blink/renderer/modules/webcodecs/decoder_template.cc
    • M third_party/blink/renderer/platform/bindings/runtime_call_stats.cc
    • M third_party/blink/renderer/platform/graphics/paint/raster_invalidation_tracking.cc
    • M third_party/blink/renderer/platform/scheduler/common/idle_helper.cc
    Change size: M
    Delta: 18 files changed, 25 insertions(+), 67 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Philip Rogers, +1 by Etienne Pierre-Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I1ff8265f25ceded3939e1920d7178c5409cfe735
    Gerrit-Change-Number: 7412509
    Gerrit-PatchSet: 3
    Gerrit-Owner: Scott Haseley <shas...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Philip Rogers <p...@chromium.org>
    Gerrit-Reviewer: Scott Haseley <shas...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages