Check feature flag before using feature parameter [chromium/src : main]
0 views
Skip to first unread message
Minoru Chikamune (Gerrit)
Apr 18, 2024, 1:49:22 AMApr 18
to Minoru Chikamune, Yoshisato Yanagisawa, Kouhei Ueno, Shunya Shishido, Alex N. Jose, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Alex N. Jose, Kouhei Ueno, Shunya Shishido and Yoshisato Yanagisawa
New activity on the change![]( "Open in Gerrit")
Related details
Attention is currently required from:
- Alex N. Jose
- Kouhei Ueno
- Shunya Shishido
- Yoshisato Yanagisawa
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Yoshisato Yanagisawa (Gerrit)
Apr 18, 2024, 2:09:59 AMApr 18
to Minoru Chikamune, Kouhei Ueno, Shunya Shishido, Alex N. Jose, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Alex N. Jose, Kouhei Ueno, Minoru Chikamune and Shunya Shishido
Yoshisato Yanagisawa voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Alex N. Jose
- Kouhei Ueno
- Minoru Chikamune
- Shunya Shishido
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Shunya Shishido (Gerrit)
Apr 18, 2024, 2:24:00 AMApr 18
to Minoru Chikamune, Yoshisato Yanagisawa, Kouhei Ueno, Alex N. Jose, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Alex N. Jose, Kouhei Ueno and Minoru Chikamune
Shunya Shishido voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Alex N. Jose
- Kouhei Ueno
- Minoru Chikamune
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Alex N. Jose (Gerrit)
Apr 18, 2024, 9:19:24 AMApr 18
to Minoru Chikamune, Shunya Shishido, Yoshisato Yanagisawa, Kouhei Ueno, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Kouhei Ueno and Minoru Chikamune
Alex N. Jose voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Kouhei Ueno
- Minoru Chikamune
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kouhei Ueno (Gerrit)
Apr 21, 2024, 9:09:55 PMApr 21
to Minoru Chikamune, Alex N. Jose, Shunya Shishido, Yoshisato Yanagisawa, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Attention needed from Minoru Chikamune
Kouhei Ueno voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Minoru Chikamune
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Minoru Chikamune (Gerrit)
Apr 21, 2024, 10:09:46 PMApr 21
to Minoru Chikamune, Kouhei Ueno, Alex N. Jose, Shunya Shishido, Yoshisato Yanagisawa, chromium...@chromium.org, Nate Chapin, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Minoru Chikamune voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 21, 2024, 10:57:17 PMApr 21
to Minoru Chikamune, Kouhei Ueno, Alex N. Jose, Shunya Shishido, Yoshisato Yanagisawa, chromium...@chromium.org, Nate Chapin, blink-rev...@chromium.org, blink-...@chromium.org, gavinp...@chromium.org, loading...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Check feature flag before using feature parameter
This CL checks kLCPCriticalPathPredictor feature flag before checking
the kLCPCriticalPathPredictorImageLoadPriorityEnabledForHTMLImageElement
feature parameter. This fix is not an important change because the
default value of the feature parameter was false.
Relevant: https://crrev.com/c/5096537
Bug: 40063266
Change-Id: I74192e7c54225c178fdaef91a7a0a5e8b1d215a6
Reviewed-by: Yoshisato Yanagisawa <yyana...@chromium.org>
Reviewed-by: Kouhei Ueno <kou...@chromium.org>
Commit-Queue: Minoru Chikamune <chik...@chromium.org>
Reviewed-by: Shunya Shishido <sisid...@chromium.org>
Reviewed-by: Alex N. Jose <ale...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1290476}
Files:
- M third_party/blink/renderer/core/html/html_image_element.cc
- M third_party/blink/renderer/core/loader/image_loader.cc
Change size: XS
Delta: 2 files changed, 4 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Shunya Shishido, +1 by Yoshisato Yanagisawa, +1 by Alex N. Jose, +1 by Kouhei Ueno
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages