Remove outdated parser test, and modify another [chromium/src : main]
0 views
Skip to first unread message
Mason Freed (Gerrit)
Jun 23, 2025, 5:16:12 PMJun 23
to Di Zhang, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Di Zhang
Mason Freed voted Auto-Submit+1![]( "Open in Gerrit")
| Auto-Submit | +1 |
Related details
Attention is currently required from:
- Di Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Di Zhang (Gerrit)
Jun 24, 2025, 12:06:38 PMJun 24
to Mason Freed, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Attention needed from Mason Freed
Di Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Di Zhang
| Code-Review | +1 |
1 comment
File third_party/blink/renderer/core/html/parser/html_parser_metrics_test.cc
Line 50, Patchset 1 (Latest):
// https://crbug.com/1222653Di Zhang . unresolved
this link can be removed.
Related details
Attention is currently required from:
- Mason Freed
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mason Freed (Gerrit)
Jun 24, 2025, 1:48:44 PMJun 24
to Di Zhang, Chromium LUCI CQ, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Mason Freed voted and added 2 comments![]( "Open in Gerrit")
Votes added by Mason Freed
| Auto-Submit | +1 |
| Commit-Queue | +2 |
2 comments
Patchset-level comments
File third_party/blink/renderer/core/html/parser/html_parser_metrics_test.cc
this link can be removed.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 24, 2025, 2:15:08 PMJun 24
to Mason Freed, Di Zhang, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, kinuko...@chromium.org, loading-rev...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/renderer/core/html/parser/html_parser_metrics_test.cc
Insertions: 0, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Remove outdated parser test, and modify another
These tests were written before the parser had time-based
yield heuristics. They previously were token-count based,
which meant that tests could be reliable. This CL just
removes the one that is entirely predicated on token counts,
and removes the yield count checking for the other.
Fixed: 40187289
Change-Id: I109662f4b025ff301c94e67310542bf197b441f5
Auto-Submit: Mason Freed <mas...@chromium.org>
Commit-Queue: Mason Freed <mas...@chromium.org>
Reviewed-by: Di Zhang <dizh...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1478055}
Files:
- M third_party/blink/renderer/core/html/parser/html_parser_metrics_test.cc
Change size: M
Delta: 1 file changed, 1 insertion(+), 107 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Di Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages