Mason Freed (Gerrit)

unread,

Jul 23, 2026, 7:55:14 PM (8 days ago) Jul 23

to Vladimir Levin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, alexmo...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org

Attention needed from Vladimir Levin

Mason Freed added 1 comment

Commit Message

Line 18, Patchset 10:


Also updates the browser-side UnboundedSurfaceWindow implementation to
allocate dummy Mojo remote/receiver connections to keep the Viz-side
CompositorFrameSinkImpl connection alive, preventing premature
self-destruction.

Mason Freed . unresolved

This was a Jetski thing, which seems hacky, but I'm not sure if there's a better way to keep the connection alive?

Open in Gerrit

Related details

Attention is currently required from:

Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Vladimir Levin (Gerrit)

unread,

Jul 27, 2026, 4:37:47 PM (4 days ago) Jul 27

to Mason Freed, Vasiliy Telezhnikov, Tzarial, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, alexmo...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org

Attention needed from Mason Freed, Tzarial and Vasiliy Telezhnikov

Vladimir Levin added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Vladimir Levin . resolved

cc looks fine, but looping in more folks for trees in viz review.

Is it correct to say that we have a layer in the "main" compositor frame sink support that internally finds and binds to the unbounded compositor frame sink support? Or how does that work?

+vasilyt +zork for trees in viz review, feel free to redirect as appropriate.

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed
Tzarial
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mason Freed (Gerrit)

unread,

Jul 27, 2026, 6:52:22 PM (4 days ago) Jul 27

to Vasiliy Telezhnikov, Tzarial, Vladimir Levin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, alexmo...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org

Attention needed from Tzarial, Vasiliy Telezhnikov and Vladimir Levin

Mason Freed added 1 comment

Patchset-level comments

File-level comment, Patchset 15 (Latest):

Vladimir Levin . resolved

cc looks fine, but looping in more folks for trees in viz review.
Is it correct to say that we have a layer in the "main" compositor frame sink support that internally finds and binds to the unbounded compositor frame sink support? Or how does that work?
+vasilyt +zork for trees in viz review, feel free to redirect as appropriate.

Mason Freed

Roughly yes I think that's exactly right. Before, the browser handling connecting the Viz process with the renderer, so that the renderer could send things to the right sinks, separately. Now (with treesinviz), since the layer tree is already in Viz, it doesn't have to cross Mojo boundaries to find the unbounded element's sink. It just needs the ID and it can look it up locally. Otherwise, the logic stays the same.

Thanks for adding more reviewers, who can tell me I'm wrong. 😊

Open in Gerrit

Related details

Attention is currently required from:

Tzarial
Vasiliy Telezhnikov
Vladimir Levin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mason Freed (Gerrit)

unread,

Jul 30, 2026, 1:06:08 PM (2 days ago) Jul 30

to Rakina Zata Amni, Vasiliy Telezhnikov, Tzarial, Vladimir Levin, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Daniel Cheng, alexmo...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, cc-...@chromium.org, creis...@chromium.org, ipc-securi...@chromium.org, mac-r...@chromium.org, navigation...@chromium.org

Attention needed from Rakina Zata Amni, Tzarial and Vasiliy Telezhnikov

Mason Freed added 1 comment

Patchset-level comments

File-level comment, Patchset 19 (Latest):

Mason Freed . resolved

Gentle ping zork@ and vasilyt@.

Also +rakina@ for content/browser/*.

Open in Gerrit

Related details

Attention is currently required from:

Rakina Zata Amni
Tzarial
Vasiliy Telezhnikov

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Implement unbounded element rendering support under TreesInViz [chromium/src : main]

Mason Freed (Gerrit)

Mason Freed added 1 comment

Related details

Vladimir Levin (Gerrit)

Vladimir Levin added 1 comment

Related details

Mason Freed (Gerrit)

Mason Freed added 1 comment

Related details

Mason Freed (Gerrit)

Mason Freed added 1 comment

Related details