Rename interesttarget attribute and friends [chromium/src : main]

0 views
Skip to first unread message

Mason Freed (Gerrit)

unread,
Jun 10, 2025, 2:39:10 PMJun 10
to Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

Mason Freed voted and added 1 comment

Votes added by Mason Freed

Code-Review-1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Mason Freed . resolved

Reminder to self: don't land until devrel is done with demos

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is blockingCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
Gerrit-Change-Number: 6626064
Gerrit-PatchSet: 1
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Comment-Date: Tue, 10 Jun 2025 18:39:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
blocking_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jun 16, 2025, 8:25:49 PMJun 16
to Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Joey Arhar

Mason Freed voted and added 1 comment

Votes added by Mason Freed

Code-Review+0

1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Mason Freed . resolved

Hopefully the latest patchset passes, but I want to get a start on the review for this patch, because it's large. LMK what you see.

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
Gerrit-Change-Number: 6626064
Gerrit-PatchSet: 8
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Jun 2025 00:25:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jun 17, 2025, 8:36:00 AMJun 17
to Mason Freed, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Mason Freed

Joey Arhar voted and added 3 comments

Votes added by Joey Arhar

Code-Review+1

3 comments

File third_party/blink/renderer/core/sanitizer/builtins_default_config.json
Line 754, Patchset 8 (Parent): "interestaction",
Joey Arhar . unresolved

interestaction looks like its an attribute in svg_attribute_names. should we leave it in here?

File third_party/blink/renderer/modules/accessibility/ax_object.h
Line 930, Patchset 8 (Latest): // have details relationships with their target, when that interest for is
Joey Arhar . unresolved

Is this sentence complete?

File third_party/blink/renderer/modules/accessibility/ax_object.cc
Line 2840, Patchset 8 (Latest):// Interest for invoking elements (with the `interestfor` attribute) should
// have details relationships with their target, when that interest for is
// a) visible, b) is rich, and c) not the next element in the DOM (depth first
// search order).
Joey Arhar . unresolved

Should there be a comment for this method both in the header and the cc file? I'd consider only commenting one of the two.

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
Gerrit-Change-Number: 6626064
Gerrit-PatchSet: 8
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Tue, 17 Jun 2025 12:35:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jun 18, 2025, 5:41:08 PMJun 18
to AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Joey Arhar

Mason Freed added 3 comments

File third_party/blink/renderer/core/sanitizer/builtins_default_config.json
Joey Arhar . resolved

interestaction looks like its an attribute in svg_attribute_names. should we leave it in here?

Mason Freed

Nope - removed.

File third_party/blink/renderer/modules/accessibility/ax_object.h
Line 930, Patchset 8: // have details relationships with their target, when that interest for is
Joey Arhar . resolved

Is this sentence complete?

Mason Freed

Weird. I have no idea where that came from, but the whole new chunk is now gone.

File third_party/blink/renderer/modules/accessibility/ax_object.cc
Line 2840, Patchset 8:// Interest for invoking elements (with the `interestfor` attribute) should

// have details relationships with their target, when that interest for is
// a) visible, b) is rich, and c) not the next element in the DOM (depth first
// search order).
Joey Arhar . unresolved

Should there be a comment for this method both in the header and the cc file? I'd consider only commenting one of the two.

Mason Freed

Well, I guess the purpose and content are different. I always put the "how to use this" help in the .h file, since that's what an IDE will show you as you autocomplete it. And then if needed, I put this kind of comment here, which is "how does this actually work" - about how it's implemented. That matter when someone else comes to change it later.

Ok to keep both?

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
Gerrit-Change-Number: 6626064
Gerrit-PatchSet: 9
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Jun 2025 21:40:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jun 18, 2025, 5:41:20 PMJun 18
to AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Joey Arhar

Mason Freed voted Auto-Submit+1

Auto-Submit+1
Gerrit-Comment-Date: Wed, 18 Jun 2025 21:41:09 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Jun 23, 2025, 1:10:16 PMJun 23
to Mason Freed, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Mason Freed

Joey Arhar voted and added 1 comment

Votes added by Joey Arhar

Code-Review+1

1 comment

File third_party/blink/renderer/modules/accessibility/ax_object.cc
Line 2840, Patchset 8:// Interest for invoking elements (with the `interestfor` attribute) should
// have details relationships with their target, when that interest for is
// a) visible, b) is rich, and c) not the next element in the DOM (depth first
// search order).
Joey Arhar . resolved

Should there be a comment for this method both in the header and the cc file? I'd consider only commenting one of the two.

Mason Freed

Well, I guess the purpose and content are different. I always put the "how to use this" help in the .h file, since that's what an IDE will show you as you autocomplete it. And then if needed, I put this kind of comment here, which is "how does this actually work" - about how it's implemented. That matter when someone else comes to change it later.

Ok to keep both?

Joey Arhar

yes

Open in Gerrit

Related details

Attention is currently required from:
  • Mason Freed
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
Gerrit-Change-Number: 6626064
Gerrit-PatchSet: 10
Gerrit-Owner: Mason Freed <mas...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alexis Menard <alexis...@intel.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Fredrik Söderquist <f...@opera.com>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Mason Freed <mas...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Jun 2025 17:10:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Joey Arhar <jar...@chromium.org>
Comment-In-Reply-To: Mason Freed <mas...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Mason Freed (Gerrit)

unread,
Jun 23, 2025, 6:11:01 PMJun 23
to Theresa Sullivan, Daniel Cheng, Bo Liu, David Tseng, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
Attention needed from Bo Liu, Daniel Cheng, David Tseng, Joey Arhar and Theresa Sullivan

Mason Freed voted and added 1 comment

Votes added by Mason Freed

Auto-Submit+0

1 comment

Patchset-level comments
File-level comment, Patchset 12 (Latest):
Mason Freed . resolved

Now, of course, I need lots of reviewers. Thanks in advance!

twellington:
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java
chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinatorTest.java
chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuHeaderMediatorTest.java
chrome/browser/resources/chromeos/accessibility/definitions/automation.d.ts
dcheng:
third_party/blink/common/context_menu_data/context_menu_mojom_traits.cc
third_party/blink/common/context_menu_data/context_menu_params_builder.cc
third_party/blink/common/context_menu_data/untrustworthy_context_menu_params.cc
third_party/blink/public/common/context_menu_data/context_menu_data.h
third_party/blink/public/common/context_menu_data/context_menu_mojom_traits.h
third_party/blink/public/common/context_menu_data/untrustworthy_context_menu_params.h
third_party/blink/public/devtools_protocol/browser_protocol.pdl
third_party/blink/public/mojom/context_menu/context_menu.mojom
third_party/blink/public/mojom/frame/frame.mojom
third_party/blink/public/strings/blink_strings.grd
ui/accessibility/ax_enums.mojom
boliu:
android_webview/javatests/src/org/chromium/android_webview/test/ContextMenuTest.java
components/embedder_support/android/contextmenu/context_menu_builder.cc
components/embedder_support/android/java/src/org/chromium/components/embedder_support/contextmenu/ContextMenuParams.java
components/embedder_support/android/junit/src/org/chromium/components/embedder_support/contextmenu/ContextMenuUtilsUnitTest.java
content/browser/renderer_host/page_impl.h
dtseng:
chrome/browser/resources/chromeos/accessibility/definitions/automation.d.ts
content/browser/accessibility/dump_accessibility_tree_browsertest.cc
content/browser/accessibility/dump_accessibility_tree_browsertest.h
extensions/common/api/automation.idl
ui/accessibility/ax_computed_node_data.cc
ui/accessibility/ax_enum_util.cc
ui/accessibility/platform/ax_platform_node_base.cc
ui/accessibility/platform/inspect/ax_tree_formatter_auralinux.cc
Open in Gerrit

Related details

Attention is currently required from:
  • Bo Liu
  • Daniel Cheng
  • David Tseng
  • Joey Arhar
  • Theresa Sullivan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
    Gerrit-Change-Number: 6626064
    Gerrit-PatchSet: 12
    Gerrit-Owner: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
    Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
    Gerrit-Reviewer: David Tseng <dts...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
    Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Alexis Menard <alexis...@intel.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
    Gerrit-CC: Fredrik Söderquist <f...@opera.com>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
    Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
    Gerrit-CC: Stephen Chenney <sche...@chromium.org>
    Gerrit-Attention: David Tseng <dts...@chromium.org>
    Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
    Gerrit-Attention: Bo Liu <bo...@chromium.org>
    Gerrit-Attention: Joey Arhar <jar...@chromium.org>
    Gerrit-Attention: Theresa Sullivan <twell...@chromium.org>
    Gerrit-Comment-Date: Mon, 23 Jun 2025 22:10:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Bo Liu (Gerrit)

    unread,
    Jun 23, 2025, 6:49:04 PMJun 23
    to Mason Freed, Bo Liu, Theresa Sullivan, Daniel Cheng, David Tseng, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
    Attention needed from Daniel Cheng, David Tseng, Joey Arhar, Mason Freed and Theresa Sullivan

    Bo Liu voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Daniel Cheng
    • David Tseng
    • Joey Arhar
    • Mason Freed
    • Theresa Sullivan
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Gerrit-Attention: Joey Arhar <jar...@chromium.org>
      Gerrit-Attention: Theresa Sullivan <twell...@chromium.org>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Mon, 23 Jun 2025 22:48:58 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Theresa Sullivan (Gerrit)

      unread,
      Jun 23, 2025, 8:18:01 PMJun 23
      to Mason Freed, Bo Liu, Daniel Cheng, David Tseng, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
      Attention needed from Daniel Cheng, David Tseng, Joey Arhar and Mason Freed

      Theresa Sullivan voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Daniel Cheng
      • David Tseng
      • Joey Arhar
      • Mason Freed
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Jun 2025 00:17:51 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Daniel Cheng (Gerrit)

      unread,
      Jun 24, 2025, 1:13:22 AMJun 24
      to Mason Freed, Daniel Cheng, Theresa Sullivan, Bo Liu, David Tseng, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
      Attention needed from David Tseng, Joey Arhar and Mason Freed

      Daniel Cheng voted and added 1 comment

      Votes added by Daniel Cheng

      Code-Review+1

      1 comment

      Patchset-level comments
      Daniel Cheng . resolved

      LGTM for mojo and third_party/blink

      Open in Gerrit

      Related details

      Attention is currently required from:
      Gerrit-Attention: Joey Arhar <jar...@chromium.org>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Jun 2025 05:13:11 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      David Tseng (Gerrit)

      unread,
      Jun 24, 2025, 12:14:25 PMJun 24
      to Mason Freed, Daniel Cheng, Theresa Sullivan, Bo Liu, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
      Attention needed from Joey Arhar and Mason Freed

      David Tseng voted Code-Review+1

      lgtm

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joey Arhar
      • Mason Freed
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
      Gerrit-Change-Number: 6626064
      Gerrit-PatchSet: 13
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: David Tseng <dts...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Fredrik Söderquist <f...@opera.com>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Attention: Joey Arhar <jar...@chromium.org>
      Gerrit-Attention: Mason Freed <mas...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Jun 2025 16:14:09 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Mason Freed (Gerrit)

      unread,
      Jun 24, 2025, 12:17:43 PMJun 24
      to David Tseng, Daniel Cheng, Theresa Sullivan, Bo Liu, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, Chromium LUCI CQ, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org
      Attention needed from Joey Arhar

      Mason Freed voted and added 1 comment

      Votes added by Mason Freed

      Commit-Queue+2

      1 comment

      Patchset-level comments
      File-level comment, Patchset 13 (Latest):
      Mason Freed . resolved

      Thanks for the quick +1's everyone. :-)

      Open in Gerrit

      Related details

      Attention is currently required from:
      • Joey Arhar
      Gerrit-Comment-Date: Tue, 24 Jun 2025 16:17:30 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jun 24, 2025, 12:23:41 PMJun 24
      to Mason Freed, David Tseng, Daniel Cheng, Theresa Sullivan, Bo Liu, AyeAye, Akihiro Ota, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Rename interesttarget attribute and friends

      **** GARDENERS: Please note! ****
      Please do me a huge favor and don't revert this CL if there are a
      few test flakes after landing it. Instead, please just mark those
      tests as flaky/fail and assign me a bug and I'll get it cleaned up.
      Thanks in advance!
      *********************************

      There have been a few standards conversations about naming:
      - https://github.com/w3c/csswg-drafts/issues/9236#issuecomment-2940736593
      - https://github.com/whatwg/html/issues/11312

      Per those conversations, this CL renames the following:
      - the `interesttarget` attribute becomes the `interestfor` attribute
      - `interestTargetElement` -> `interestForElement`
      - CSS `interest-target-*-delay` -> `interest-*-delay`

      I also renamed the feature flags and associated code, so that the new
      names are code-searchable. I did not rename the IDS string var names,
      so that we don't waste time on re-translating them.

      Bug: 364669918
      AX-Relnotes: Just renaming the attribute
      Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
      Reviewed-by: Daniel Cheng <dch...@chromium.org>
      Reviewed-by: Bo Liu <bo...@chromium.org>
      Reviewed-by: David Tseng <dts...@chromium.org>
      Reviewed-by: Theresa Sullivan <twell...@chromium.org>
      Commit-Queue: Mason Freed <mas...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1477967}
      Files:
      • M android_webview/javatests/src/org/chromium/android_webview/test/ContextMenuTest.java
      • M android_webview/test/data/web_tests/webexposed/global-interface-listing-expected.txt
      • M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java
      • M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinator.java
      • M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulatorTest.java
      • M chrome/android/javatests/src/org/chromium/chrome/browser/contextmenu/ContextMenuTest.java
      • M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuCoordinatorTest.java
      • M chrome/android/junit/src/org/chromium/chrome/browser/contextmenu/ContextMenuHeaderMediatorTest.java
      • M chrome/browser/resources/chromeos/accessibility/definitions/automation.d.ts
      • M components/embedder_support/android/contextmenu/context_menu_builder.cc
      • M components/embedder_support/android/java/src/org/chromium/components/embedder_support/contextmenu/ContextMenuParams.java
      • M components/embedder_support/android/junit/src/org/chromium/components/embedder_support/contextmenu/ContextMenuUtilsUnitTest.java
      • M content/browser/accessibility/dump_accessibility_tree_browsertest.cc
      • M content/browser/accessibility/dump_accessibility_tree_browsertest.h
      • M content/browser/renderer_host/page_impl.h
      • M content/test/content_test_bundle_data.filelist
      • R content/test/data/accessibility/html/interest-for-expected-auralinux.txt
      • R content/test/data/accessibility/html/interest-for-expected-blink.txt
      • R content/test/data/accessibility/html/interest-for-expected-win.txt
      • R content/test/data/accessibility/html/interest-for.html
      • M extensions/common/api/automation.idl
      • M third_party/blink/common/context_menu_data/context_menu_mojom_traits.cc
      • M third_party/blink/common/context_menu_data/context_menu_params_builder.cc
      • M third_party/blink/common/context_menu_data/untrustworthy_context_menu_params.cc
      • M third_party/blink/public/common/context_menu_data/context_menu_data.h
      • M third_party/blink/public/common/context_menu_data/context_menu_mojom_traits.h
      • M third_party/blink/public/common/context_menu_data/untrustworthy_context_menu_params.h
      • M third_party/blink/public/devtools_protocol/browser_protocol.pdl
      • M third_party/blink/public/mojom/context_menu/context_menu.mojom
      • M third_party/blink/public/mojom/frame/frame.mojom
      • M third_party/blink/public/mojom/use_counter/metrics/css_property_id.mojom
      • M third_party/blink/public/mojom/use_counter/metrics/web_feature.mojom
      • M third_party/blink/public/strings/blink_strings.grd
      • M third_party/blink/renderer/core/animation/css_time_interpolation_type.cc
      • M third_party/blink/renderer/core/animation/interpolation_types_map.cc
      • M third_party/blink/renderer/core/css/css_properties.json5
      • M third_party/blink/renderer/core/css/css_property_equality.cc
      • M third_party/blink/renderer/core/css/css_selector.cc
      • M third_party/blink/renderer/core/css/css_value_keywords.json5
      • M third_party/blink/renderer/core/css/properties/computed_style_utils.cc
      • M third_party/blink/renderer/core/css/properties/computed_style_utils.h
      • M third_party/blink/renderer/core/css/properties/longhands/longhands_custom.cc
      • M third_party/blink/renderer/core/css/properties/shorthands/shorthands_custom.cc
      • M third_party/blink/renderer/core/css/selector_checker.cc
      • M third_party/blink/renderer/core/css/style_environment_variables.h
      • M third_party/blink/renderer/core/css/style_property_serializer.cc
      • M third_party/blink/renderer/core/dom/element.cc
      • M third_party/blink/renderer/core/dom/element.h
      • M third_party/blink/renderer/core/dom/interest_invoker_element.idl
      • M third_party/blink/renderer/core/dom/interest_invoker_target_data.h
      • M third_party/blink/renderer/core/dom/invoker_data.h
      • M third_party/blink/renderer/core/dom/popover_data.h
      • M third_party/blink/renderer/core/events/interest_event.cc
      • M third_party/blink/renderer/core/events/interest_event.idl
      • M third_party/blink/renderer/core/frame/local_frame.h
      • M third_party/blink/renderer/core/html/forms/html_form_control_element.cc
      • M third_party/blink/renderer/core/html/forms/html_form_control_element.h
      • M third_party/blink/renderer/core/html/forms/html_input_element.cc
      • M third_party/blink/renderer/core/html/forms/html_text_area_element.cc
      • M third_party/blink/renderer/core/html/html_anchor_element.cc
      • M third_party/blink/renderer/core/html/html_anchor_element.h
      • M third_party/blink/renderer/core/html/html_attribute_names.json5
      • M third_party/blink/renderer/core/html/html_dialog_element.cc
      • M third_party/blink/renderer/core/html/html_element.cc
      • M third_party/blink/renderer/core/html/html_menu_item_element.cc
      • M third_party/blink/renderer/core/html/resources/html.css
      • M third_party/blink/renderer/core/inspector/inspector_dom_agent.cc
      • M third_party/blink/renderer/core/page/context_menu_controller.cc
      • M third_party/blink/renderer/core/sanitizer/builtins_default_config.json
      • M third_party/blink/renderer/core/svg/svg_a_element.cc
      • M third_party/blink/renderer/core/svg/svg_a_element.h
      • M third_party/blink/renderer/core/svg/svg_attribute_names.json5
      • M third_party/blink/renderer/modules/accessibility/ax_node_object.cc
      • M third_party/blink/renderer/modules/accessibility/ax_object.cc
      • M third_party/blink/renderer/modules/accessibility/ax_object.h
      • M third_party/blink/renderer/modules/context_menu/context_menu.cc
      • M third_party/blink/renderer/platform/runtime_enabled_features.json5
      • M third_party/blink/web_tests/TestExpectations
      • M third_party/blink/web_tests/TestLists/content_shell.filter
      • M third_party/blink/web_tests/VirtualTestSuites
      • R third_party/blink/web_tests/accessibility/interest-for-expected.txt
      • R third_party/blink/web_tests/accessibility/interest-for.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/idlharness.tentative.html
      • A third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestelement-interface.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestevent-dispatch-shadow.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestevent-interface.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-anchor-event-dispatch.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-area-event-dispatch.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-basic-delays.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-button-event-dispatch.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-css-properties.tentative.html
      • A third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-css-shorthands.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-hide-delay.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-input-modalities.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-invoker-descendants.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-keyboard-behavior.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-keyboard-invalidation-ref.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-keyboard-invalidation.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-on-popover-behavior.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-partial-interest.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-plain-inline-element.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-popover-focus.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-pseudo-classes.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-show-delay.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-svg-a-event-dispatch.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/interestfor-user-select.tentative.html
      • R third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-for/resources/invoker-utils.js
      • D third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-target/interestelement-interface.tentative.html
      • D third_party/blink/web_tests/external/wpt/html/semantics/the-button-element/interest-target/interesttarget-css-shorthands.tentative.html
      • M third_party/blink/web_tests/external/wpt/interfaces/interest-invokers.tentative.idl
      • R third_party/blink/web_tests/external/wpt/shadow-dom/reference-target/tentative/interestfor.tentative.html
      • M third_party/blink/web_tests/external/wpt/shadow-dom/reference-target/tentative/resources/property-reflection-helper.js
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-listing-expected.txt
      • M third_party/blink/web_tests/fast/css/getComputedStyle/computed-style-without-renderer-listing-expected.txt
      • A third_party/blink/web_tests/fast/forms/button/button-interestfor-usecounter.html
      • D third_party/blink/web_tests/fast/forms/button/button-interesttarget-usecounter.html
      • M third_party/blink/web_tests/inspector-protocol/dom/dom-getElementByRelation.js
      • M third_party/blink/web_tests/inspector-protocol/dom/resources/dom-get-element-by-relation.html
      • M third_party/blink/web_tests/svg/css/getComputedStyle-listing-expected.txt
      • R third_party/blink/web_tests/virtual/interest-for-no-partial-interest/README.md
      • R third_party/blink/web_tests/virtual/interest-for-no-partial-interest/external/wpt/html/semantics/the-button-element/interest-for/interestfor-partial-interest.tentative-expected.txt
      • R third_party/blink/web_tests/virtual/interest-for-no-partial-interest/external/wpt/html/semantics/the-button-element/interest-for/interestfor-popover-focus.tentative-expected.txt
      • R third_party/blink/web_tests/virtual/interest-for-no-partial-interest/external/wpt/html/semantics/the-button-element/interest-for/interestfor-pseudo-classes.tentative-expected.txt
      • M third_party/blink/web_tests/webexposed/css-properties-as-js-properties-expected.txt
      • M third_party/blink/web_tests/webexposed/css-property-listing-expected.txt
      • M third_party/blink/web_tests/webexposed/element-instance-property-listing-expected.txt
      • M third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
      • M tools/metrics/histograms/metadata/blink/enums.xml
      • M ui/accessibility/ax_computed_node_data.cc
      • M ui/accessibility/ax_enum_util.cc
      • M ui/accessibility/ax_enums.mojom
      • M ui/accessibility/platform/ax_platform_node_base.cc
      • M ui/accessibility/platform/inspect/ax_tree_formatter_auralinux.cc
      Change size: XL
      Delta: 133 files changed, 746 insertions(+), 749 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by David Tseng, +1 by Bo Liu, +1 by Daniel Cheng, +1 by Theresa Sullivan
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
      Gerrit-Change-Number: 6626064
      Gerrit-PatchSet: 14
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: David Tseng <dts...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      open
      diffy
      satisfied_requirement

      Blink W3C Test Autoroller (Gerrit)

      unread,
      Jun 24, 2025, 1:18:29 PMJun 24
      to Chromium LUCI CQ, Mason Freed, David Tseng, Daniel Cheng, Theresa Sullivan, Bo Liu, AyeAye, Alexis Menard, Chromium Metrics Reviews, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Fredrik Söderquist, Olga Gerchikov, (Julie)Jeongeun Kim, Kevin Babbitt, Stephen Chenney, mac-r...@chromium.org, abigailbk...@google.com, aleventhal...@chromium.org, alexmo...@chromium.org, anastas...@google.com, android-web...@chromium.org, apavlo...@chromium.org, ashleynewson+w...@chromium.org, asvitkine...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-rev...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org, chromium-a...@chromium.org, creis...@chromium.org, devtools-re...@chromium.org, dtseng...@chromium.org, extension...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, hirokisa...@chromium.org, ipc-securi...@chromium.org, jmedle...@chromium.org, josiah...@chromium.org, katie...@chromium.org, kinuko...@chromium.org, kouhe...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, navigation...@chromium.org, nektar...@chromium.org, oshima...@chromium.org, pdr+svgw...@chromium.org, rrsilva+wat...@google.com, shannc...@chromium.org, yuzo+...@chromium.org

      Message from Blink W3C Test Autoroller

      The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/53356

      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I4e78b655ef9622faa8c8e4306d97f480885eb3db
      Gerrit-Change-Number: 6626064
      Gerrit-PatchSet: 14
      Gerrit-Owner: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Bo Liu <bo...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
      Gerrit-Reviewer: David Tseng <dts...@chromium.org>
      Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
      Gerrit-Reviewer: Mason Freed <mas...@chromium.org>
      Gerrit-Reviewer: Theresa Sullivan <twell...@chromium.org>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Alexis Menard <alexis...@intel.com>
      Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
      Gerrit-CC: Fredrik Söderquist <f...@opera.com>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-CC: Nektarios Paisios <nek...@chromium.org>
      Gerrit-CC: Olga Gerchikov <gerc...@microsoft.com>
      Gerrit-CC: Stephen Chenney <sche...@chromium.org>
      Gerrit-Comment-Date: Tue, 24 Jun 2025 17:18:24 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: No
      satisfied_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages