Don't run DefaultEventHandler on disabled input elements [chromium/src : main]

0 views
Skip to first unread message

David Baron (Gerrit)

unread,
Jul 31, 2026, 4:58:00 PM (10 hours ago) Jul 31
to David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar

David Baron added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
David Baron . resolved

This basically looks fine -- except I wonder if this is risky enough that it should have a killswitch flag. (I didn't really look in to what's in the default event handling code, but I suspect there are a decent number of things in there...)

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I24903ec2faa16bab712a73a7f4ecb8e771d200a0
Gerrit-Change-Number: 8077604
Gerrit-PatchSet: 3
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Fri, 31 Jul 2026 20:57:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Baron (Gerrit)

unread,
Jul 31, 2026, 4:58:13 PM (10 hours ago) Jul 31
to David Baron, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar

David Baron added 1 comment

Patchset-level comments
David Baron . unresolved

This basically looks fine -- except I wonder if this is risky enough that it should have a killswitch flag. (I didn't really look in to what's in the default event handling code, but I suspect there are a decent number of things in there...)

David Baron

.

Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I24903ec2faa16bab712a73a7f4ecb8e771d200a0
    Gerrit-Change-Number: 8077604
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Attention: Joey Arhar <jar...@chromium.org>
    Gerrit-Comment-Date: Fri, 31 Jul 2026 20:58:06 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: David Baron <dba...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages