Avoid crashes in HTMLDataListElement::MoveActiveOption [chromium/src : main]

0 views
Skip to first unread message

David Grogan (Gerrit)

unread,
Apr 20, 2026, 7:36:14 PM (2 days ago) Apr 20
to David Grogan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar

David Grogan voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7f07ec0135473b3e0905317e24b3b5e94db94ab8
Gerrit-Change-Number: 7765870
Gerrit-PatchSet: 2
Gerrit-Owner: Joey Arhar <jar...@chromium.org>
Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Apr 2026 23:36:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Apr 20, 2026, 7:56:50 PM (2 days ago) Apr 20
to David Grogan, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

Joey Arhar voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7f07ec0135473b3e0905317e24b3b5e94db94ab8
    Gerrit-Change-Number: 7765870
    Gerrit-PatchSet: 2
    Gerrit-Owner: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Comment-Date: Mon, 20 Apr 2026 23:56:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 20, 2026, 8:32:35 PM (2 days ago) Apr 20
    to David Grogan, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Avoid crashes in HTMLDataListElement::MoveActiveOption

    This method was not fully updated after I made other changes to allow
    active_option_ to be null so that nothing is highlighted when opening
    the datalist. Now, when there is no active option, the first valid
    option will become active when pressing the up or down arrows.
    Bug: 453705243
    Change-Id: I7f07ec0135473b3e0905317e24b3b5e94db94ab8
    Reviewed-by: David Grogan <dgr...@chromium.org>
    Reviewed-by: Joey Arhar <jar...@chromium.org>
    Commit-Queue: Joey Arhar <jar...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1617884}
    Files:
    • M third_party/blink/renderer/core/html/forms/html_data_list_element.cc
    • M third_party/blink/web_tests/external/wpt/html/semantics/forms/customizable-combobox/customizable-combobox-keyboard-behavior.tentative.html
    Change size: M
    Delta: 2 files changed, 78 insertions(+), 34 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joey Arhar, +1 by David Grogan
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7f07ec0135473b3e0905317e24b3b5e94db94ab8
    Gerrit-Change-Number: 7765870
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    open
    diffy
    satisfied_requirement

    Blink W3C Test Autoroller (Gerrit)

    unread,
    Apr 20, 2026, 10:06:28 PM (2 days ago) Apr 20
    to Chromium LUCI CQ, David Grogan, android-bu...@system.gserviceaccount.com, blink-revie...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Message from Blink W3C Test Autoroller

    The WPT PR for this CL has been merged upstream! https://github.com/web-platform-tests/wpt/pull/59372

    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7f07ec0135473b3e0905317e24b3b5e94db94ab8
    Gerrit-Change-Number: 7765870
    Gerrit-PatchSet: 3
    Gerrit-Owner: Joey Arhar <jar...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Grogan <dgr...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-CC: Blink W3C Test Autoroller <blink-w3c-te...@chromium.org>
    Gerrit-Comment-Date: Tue, 21 Apr 2026 02:06:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages