Convert <DETAILS> to manual assignment. [chromium/src : main]
Chris Harrelson (Gerrit)
Attention is currently required from: Aleks Totic.
Chris Harrelson uploaded patch set #5 to the change originally created by Aleks Totic.
Convert <DETAILS> to manual assignment.
Some user agent custom elements used non-standard slot assignment.
Convert it to manual slot assignment.
Elements that want to do manual assignment:
- Implement Element::ManuallyAssignSlots method
- SetSlotAssignmentMode(SlotAssignmentMode::kManual);
First implementation: details element.
Bug: 1179356
Change-Id: Ida73ae8436f78da134b3b5414a1e4f972983dd63
---
M third_party/blink/renderer/core/dom/element.h
M third_party/blink/renderer/core/dom/slot_assignment.cc
M third_party/blink/renderer/core/html/html_details_element.cc
M third_party/blink/renderer/core/html/html_details_element.h
M third_party/blink/renderer/core/html/html_slot_element.cc
M third_party/blink/renderer/core/html/html_slot_element.h
M third_party/blink/web_tests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
7 files changed, 138 insertions(+), 66 deletions(-)
To view, visit change 3163573. To unsubscribe, or for help writing mail filters, visit settings.
Aleks Totic (Gerrit)
Patch set 6:Commit-Queue +2
2 comments:
Patchset:
Nice, this LGTM! Should make the next two a piece of cake.
Piece of cake would be great. With Chrome code, I've learned to expect the unexpected ;)
Patchset:
thanks!
To view, visit change 3163573. To unsubscribe, or for help writing mail filters, visit settings.
Aleks Totic (Gerrit)
Patch set 6:Commit-Queue +2
1 comment:
Patchset:
Android builds are broken for everyone....
To view, visit change 3163573. To unsubscribe, or for help writing mail filters, visit settings.
Chromium LUCI CQ (Gerrit)
Chromium LUCI CQ submitted this change.
4 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/blink/web_tests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
Insertions: 3, Deletions: 1.
The diff is too large to show. Please review the diff.
```
Convert <DETAILS> to manual assignment.
Some user agent custom elements used non-standard slot assignment.
Convert it to manual slot assignment.
Elements that want to do manual assignment:
- Implement Element::ManuallyAssignSlots method
- SetSlotAssignmentMode(SlotAssignmentMode::kManual);
First implementation: details element.
Bug: 1179356
Change-Id: Ida73ae8436f78da134b3b5414a1e4f972983dd63
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3163573
Commit-Queue: Aleks Totic <ato...@chromium.org>
Reviewed-by: Mason Freed <mas...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#922806}
---
M third_party/blink/renderer/core/dom/element.h
M third_party/blink/renderer/core/dom/slot_assignment.cc
M third_party/blink/renderer/core/html/html_details_element.cc
M third_party/blink/renderer/core/html/html_details_element.h
M third_party/blink/renderer/core/html/html_slot_element.cc
M third_party/blink/renderer/core/html/html_slot_element.h
M third_party/blink/web_tests/fast/dom/shadow/offset-parent-does-not-leak-ua-shadow.html
7 files changed, 78 insertions(+), 20 deletions(-)
ADIr2d2 (Gerrit)
1 comment:
Patchset:
To view, visit change 3163573. To unsubscribe, or for help writing mail filters, visit settings.
Aleks Totic (Gerrit)
Aleks Totic has created a revert of this change.
To view, visit change 3163573. To unsubscribe, or for help writing mail filters, visit settings.