Enable Speculation Rules mobile viewport heuristics in DevTools mobile emulation [chromium/src : main]

0 views
Skip to first unread message

Takashi Toyoshima (Gerrit)

unread,
3:38 AM (9 hours ago) 3:38 AM
to Helmut Januschka, Hiroki Nakagawa, Barry Pollard, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, prerendering-reviews, Chromium LUCI CQ, devtools-re...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, gavin...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Helmut Januschka and Hiroki Nakagawa

Takashi Toyoshima added 1 comment

Patchset-level comments
File-level comment, Patchset 7 (Latest):
Takashi Toyoshima . unresolved

+nhiroki for speculationrules related changes in blink

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Hiroki Nakagawa
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib15101432ccd2dafe324b0e5eccf302b77b4c00d
Gerrit-Change-Number: 7800216
Gerrit-PatchSet: 7
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Barry Pollard <barryp...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 07:37:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Hiroki Nakagawa (Gerrit)

unread,
6:33 AM (6 hours ago) 6:33 AM
to Helmut Januschka, Takashi Nakayama, Takashi Toyoshima, Barry Pollard, Nate Chapin, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, prerendering-reviews, Chromium LUCI CQ, devtools-re...@chromium.org, loading...@chromium.org, gavinp...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org, gavin...@chromium.org, kinuko...@chromium.org, tburkar...@chromium.org
Attention needed from Helmut Januschka and Takashi Nakayama

Hiroki Nakagawa added 1 comment

Patchset-level comments
Hiroki Nakagawa . resolved

tnak@: Can you review this CL? Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Helmut Januschka
  • Takashi Nakayama
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib15101432ccd2dafe324b0e5eccf302b77b4c00d
Gerrit-Change-Number: 7800216
Gerrit-PatchSet: 7
Gerrit-Owner: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Helmut Januschka <hel...@januschka.com>
Gerrit-Reviewer: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-Reviewer: Takashi Nakayama <tn...@chromium.org>
Gerrit-Reviewer: Takashi Toyoshima <toyo...@chromium.org>
Gerrit-CC: Barry Pollard <barryp...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>
Gerrit-Attention: Helmut Januschka <hel...@januschka.com>
Gerrit-Attention: Takashi Nakayama <tn...@chromium.org>
Gerrit-Comment-Date: Tue, 12 May 2026 10:33:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages