Speculative crash fix for <option> owner <selectlist> [chromium/src : main]
0 views
Skip to first unread message
Di Zhang (Gerrit)
Apr 18, 2024, 4:33:37 PMApr 18
to Joey Arhar, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, dpr...@google.com, blink-...@chromium.org
Attention needed from Joey Arhar
Di Zhang voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Joey Arhar
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joey Arhar (Gerrit)
Apr 18, 2024, 4:45:34 PMApr 18
to Di Zhang, AyeAye, Chromium LUCI CQ, blink-rev...@chromium.org, dpr...@google.com, blink-...@chromium.org
Joey Arhar voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 18, 2024, 4:48:58 PMApr 18
to Joey Arhar, Di Zhang, AyeAye, blink-rev...@chromium.org, dpr...@google.com, blink-...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Speculative crash fix for <option> owner <selectlist>
The attached crash report shows that we are crashing during slot
assignment when changing the child content of an <option>. Slot
assignment should not crash at this time, so I am adding a CHECK() which
should help show whether an element which might be null is null or not.
It also adds a feature check for <selectlist>, because we shouldn't even
be doing a flat tree traversal with slot assignment recalc here when the
<selectlist> flag is disabled.
Fixed: 335599521
Change-Id: I336b40e7cc459720922c1487a5870dbef37c7e9b
Reviewed-by: Di Zhang <dizh...@chromium.org>
Commit-Queue: Joey Arhar <jar...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1289561}
Files:
- M third_party/blink/renderer/core/html/forms/html_option_element.cc
- M third_party/blink/renderer/core/html/forms/select_type.cc
Change size: XS
Delta: 2 files changed, 7 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Di Zhang
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages