Peng Zhou (Gerrit)

unread,

Oct 15, 2025, 10:42:33 AM (4 days ago) Oct 15

to Mason Freed, (Julie)Jeongeun Kim, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, francisjp...@google.com, dtseng...@chromium.org, josiah...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, yuzo+...@chromium.org, nektar...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org

Attention needed from Mason Freed

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:

Mason Freed

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mason Freed (Gerrit)

unread,

Oct 17, 2025, 7:19:22 PM (2 days ago) Oct 17

to Peng Zhou, (Julie)Jeongeun Kim, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, francisjp...@google.com, dtseng...@chromium.org, josiah...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, yuzo+...@chromium.org, nektar...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org

Attention needed from Peng Zhou

Mason Freed voted and added 3 comments

Votes added by Mason Freed

Code-Review

+1

3 comments

Patchset-level comments

File-level comment, Patchset 7 (Latest):

Mason Freed . resolved

Wow awesome work updating so many of the tests to modern syntax! Code looks great. Just one small thing on the test.

Commit Message

Line 19, Patchset 7 (Latest):Bug: 442293382

Mason Freed . unresolved

nit: you can do `Fixed: 442293382` here and it'll close the bug when this lands.

File third_party/blink/web_tests/fast/forms/resources/common.js

Line 265, Patchset 7 (Latest): // Return true if the node cannot be found.

Mason Freed . unresolved

Maybe it's safer to fail the test if the node/pseudo can't be found? I know the new tests all do `assert_false(isDisabled())` but someone could add one that checks `assert_true`. Better to just fail directly with an `assert()` here.

Open in Gerrit

Related details

Attention is currently required from:

Peng Zhou

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Peng Zhou (Gerrit)

unread,

Oct 18, 2025, 9:11:18 AM (yesterday) Oct 18

to Mason Freed, (Julie)Jeongeun Kim, Chromium LUCI CQ, chromium...@chromium.org, AyeAye, francisjp...@google.com, dtseng...@chromium.org, josiah...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, yuzo+...@chromium.org, nektar...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org

Peng Zhou voted and added 2 comments

Votes added by Peng Zhou

Commit-Queue

+2

2 comments

Commit Message

Line 19, Patchset 7:Bug: 442293382

Mason Freed . resolved

nit: you can do `Fixed: 442293382` here and it'll close the bug when this lands.

Peng Zhou

Done

File third_party/blink/web_tests/fast/forms/resources/common.js

Line 265, Patchset 7: // Return true if the node cannot be found.

Mason Freed . resolved

Maybe it's safer to fail the test if the node/pseudo can't be found? I know the new tests all do `assert_false(isDisabled())` but someone could add one that checks `assert_true`. Better to just fail directly with an `assert()` here.

Peng Zhou

Done

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Oct 18, 2025, 9:31:20 AM (yesterday) Oct 18

to Peng Zhou, Mason Freed, (Julie)Jeongeun Kim, Akihiro Ota, chromium...@chromium.org, AyeAye, francisjp...@google.com, dtseng...@chromium.org, josiah...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, yuzo+...@chromium.org, nektar...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

7 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: third_party/blink/web_tests/fast/forms/resources/common.js
Insertions: 2, Deletions: 2.

@@ -262,8 +262,8 @@
 
 function isDisabledField(input, pseudo) {
     const node = internals.shadowRoot(input).querySelector(`*[pseudo="${pseudo}"]`);
-    // Return true if the node cannot be found.
-    return !node || node.hasAttribute('disabled');
+    assert_true(!!node);
+    return node.hasAttribute('disabled');
 }
 
 function isYearFieldDisabled(input) {
```

Change information

Commit message:

Skip field disabled checks in DateTimeEditElement

`ShouldXXFieldDisabled` is over ten years old and disables fields such
as year, month, and day when min/max values fall within the same unit.

This CL introduces a runtime flag to optionally skip these legacy
checks, allowing the fields to remain enabled and aligning behavior with
Firefox’s placeholders.

Related tests have been updated, as they previously assumed the fields
would be disabled.

Fixed: 442293382

Change-Id: Ic09cc506543c728d56e90bc2ec6a2e16ac593b5c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7037611

Reviewed-by: Mason Freed <mas...@chromium.org>

Commit-Queue: Peng Zhou <zhoupe...@bytedance.com>

Cr-Commit-Position: refs/heads/main@{#1531830}

Files:

M content/test/data/accessibility/html/input-time-with-popup-open-expected-blink.txt
M content/test/data/accessibility/html/input-time-with-popup-open-expected-uia-win.txt
M content/test/data/accessibility/html/input-time-with-popup-open-expected-win.txt
M third_party/blink/renderer/core/html/forms/date_time_edit_element.cc
M third_party/blink/renderer/platform/runtime_enabled_features.json5
D third_party/blink/web_tests/fast/forms/date-multiple-fields/date-multiple-fields-focus-expected.txt
M third_party/blink/web_tests/fast/forms/date-multiple-fields/date-multiple-fields-focus.html
A third_party/blink/web_tests/fast/forms/date-multiple-fields/date-multiple-fields-non-disabled-subfield.html
D third_party/blink/web_tests/fast/forms/date-multiple-fields/date-multiple-fields-readonly-subfield.html
M third_party/blink/web_tests/fast/forms/date/date-keyoperation.html
A third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-non-disabled-subfield.html
D third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt
D third_party/blink/web_tests/fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html
A third_party/blink/web_tests/fast/forms/month-multiple-fields/month-multiple-fields-non-disabled-subfield.html
D third_party/blink/web_tests/fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield-expected.txt
D third_party/blink/web_tests/fast/forms/month-multiple-fields/month-multiple-fields-readonly-subfield.html
M third_party/blink/web_tests/fast/forms/resources/common.js
A third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-non-disabled-subfield.html
D third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt
D third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html
M third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-stepup-stepdown-from-renderer-hour.html
D third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt
M third_party/blink/web_tests/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty.html
A third_party/blink/web_tests/fast/forms/week-multiple-fields/week-multiple-fields-non-disabled-subfield.html
D third_party/blink/web_tests/fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield-expected.txt
D third_party/blink/web_tests/fast/forms/week-multiple-fields/week-multiple-fields-readonly-subfield.html
M third_party/blink/web_tests/platform/linux/fast/forms/calendar-picker/date-picker-appearance-disabled-previous-month-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/date/date-input-horizontal-tb-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/date/date-input-vertical-lr-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/date/date-input-vertical-rl-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
M third_party/blink/web_tests/platform/linux/fast/forms/month/month-picker-appearance-disabled-today-expected.png
D third_party/blink/web_tests/platform/linux/fast/forms/time-multiple-fields/time-multiple-fields-value-set-empty-expected.txt
M third_party/blink/web_tests/platform/linux/fast/forms/time/time-appearance-basic-expected.png
M third_party/blink/web_tests/platform/linux/virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
M third_party/blink/web_tests/platform/linux/virtual/dark-color-scheme/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
A third_party/blink/web_tests/platform/mac-mac12/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png
M third_party/blink/web_tests/platform/mac-mac13-arm64/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
A third_party/blink/web_tests/platform/mac-mac13/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
A third_party/blink/web_tests/platform/mac-mac14-arm64/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/calendar-picker/date-picker-appearance-disabled-previous-month-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/date/date-input-horizontal-tb-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/date/date-input-vertical-lr-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/date/date-input-vertical-rl-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/month/month-picker-appearance-disabled-today-expected.png
M third_party/blink/web_tests/platform/mac/fast/forms/time/time-appearance-basic-expected.png
M third_party/blink/web_tests/platform/mac/virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
M third_party/blink/web_tests/platform/mac/virtual/dark-color-scheme/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/calendar-picker/date-picker-appearance-disabled-previous-month-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
M third_party/blink/web_tests/platform/win/fast/forms/month/month-picker-appearance-disabled-today-expected.png
M third_party/blink/web_tests/platform/win/virtual/controls-refresh-hc/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
M third_party/blink/web_tests/platform/win/virtual/dark-color-scheme/fast/forms/color-scheme/calendar-picker/date-picker-disabled-values-expected.png
A third_party/blink/web_tests/platform/win10/fast/forms/date/date-input-horizontal-tb-expected.png
A third_party/blink/web_tests/platform/win10/fast/forms/date/date-input-vertical-lr-expected.png
A third_party/blink/web_tests/platform/win10/fast/forms/date/date-input-vertical-rl-expected.png
A third_party/blink/web_tests/platform/win10/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png
A third_party/blink/web_tests/platform/win10/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
A third_party/blink/web_tests/platform/win10/fast/forms/time/time-appearance-basic-expected.png
A third_party/blink/web_tests/platform/win11-arm64/fast/forms/date/date-input-horizontal-tb-expected.png
A third_party/blink/web_tests/platform/win11-arm64/fast/forms/date/date-input-vertical-lr-expected.png
A third_party/blink/web_tests/platform/win11-arm64/fast/forms/date/date-input-vertical-rl-expected.png
A third_party/blink/web_tests/platform/win11-arm64/fast/forms/datetimelocal/datetimelocal-appearance-basic-expected.png
A third_party/blink/web_tests/platform/win11-arm64/fast/forms/datetimelocal/datetimelocal-appearance-l10n-expected.png
A third_party/blink/web_tests/platform/win11-arm64/fast/forms/time/time-appearance-basic-expected.png

Change size: XL

Delta: 70 files changed, 404 insertions(+), 653 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mason Freed

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,

Oct 18, 2025, 2:30:23 PM (yesterday) Oct 18

to Chromium LUCI CQ, Peng Zhou, Mason Freed, (Julie)Jeongeun Kim, chromium...@chromium.org, AyeAye, francisjp...@google.com, dtseng...@chromium.org, josiah...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, yuzo+...@chromium.org, nektar...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection has identified this change as the cause of a test failure. See the analysis: https://ci.chromium.org/ui/p/chromium/bisection/test-analysis/b/5688295234207744

Sample build with failed test: https://ci.chromium.org/b/8700667084906263265
Affected test(s):
[ninja://content/test:content_browsertests/DumpAccessibilityTreeTest.AccessibilityInputTimeWithPopupOpen/All.fuchsia](https://ci.chromium.org/ui/test/chromium/ninja:%2F%2Fcontent%2Ftest:content_browsertests%2FDumpAccessibilityTreeTest.AccessibilityInputTimeWithPopupOpen%2FAll.fuchsia?q=VHash%3A8fc6a521f60e522f)
A revert for this change was not created because the builder that this CL broke is not watched by gardeners, therefore less important. You can consider revert this CL, fix forward or let builder owners resolve it themselves.

If this is a false positive, please report it at http://b.corp.google.com/createIssue?component=1199205&description=Analysis%3A+https%3A%2F%2Fci.chromium.org%2Fui%2Fp%2Fchromium%2Fbisection%2Ftest-analysis%2Fb%2F5688295234207744&format=PLAIN&priority=P3&title=Wrongly+blamed+https%3A%2F%2Fchromium-review.googlesource.com%2Fc%2Fchromium%2Fsrc%2F%2B%2F7037611&type=BUG

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,

Oct 18, 2025, 3:24:27 PM (23 hours ago) Oct 18

to Chromium LUCI CQ, Peng Zhou, Mason Freed, (Julie)Jeongeun Kim, chromium...@chromium.org, AyeAye, francisjp...@google.com, dtseng...@chromium.org, josiah...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, yuzo+...@chromium.org, nektar...@chromium.org, jshin...@chromium.org, mac-r...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, jmedle...@chromium.org

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Open original change

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Skip field disabled checks in DateTimeEditElement [chromium/src : main]

Peng Zhou (Gerrit)

New activity on the change

Related details

Mason Freed (Gerrit)

Mason Freed voted and added 3 comments

Votes added by Mason Freed

3 comments

Related details

Peng Zhou (Gerrit)

Peng Zhou voted and added 2 comments

Votes added by Peng Zhou

2 comments

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

Change information

luci-bisection@appspot.gserviceaccount.com (Gerrit)

Message from luci-bi...@appspot.gserviceaccount.com

Related details

luci-bisection@appspot.gserviceaccount.com (Gerrit)

luci-bi...@appspot.gserviceaccount.com has created a revert of this change

Related details