Null-check computed style in SliderContainerElement::CanSlide. [chromium/src : main]

0 views
Skip to first unread message

David Baron (Gerrit)

unread,
Dec 18, 2025, 4:37:04 PM (15 hours ago) Dec 18
to David Baron, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from Joey Arhar

David Baron voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Joey Arhar
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3e29f753169bc65ed39105f6d43b3ae8de91b6ca
Gerrit-Change-Number: 7277172
Gerrit-PatchSet: 1
Gerrit-Owner: David Baron <dba...@chromium.org>
Gerrit-Reviewer: David Baron <dba...@chromium.org>
Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
Gerrit-Attention: Joey Arhar <jar...@chromium.org>
Gerrit-Comment-Date: Thu, 18 Dec 2025 21:36:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joey Arhar (Gerrit)

unread,
Dec 18, 2025, 4:59:51 PM (14 hours ago) Dec 18
to David Baron, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org
Attention needed from David Baron

Joey Arhar voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • David Baron
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3e29f753169bc65ed39105f6d43b3ae8de91b6ca
    Gerrit-Change-Number: 7277172
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>
    Gerrit-Attention: David Baron <dba...@chromium.org>
    Gerrit-Comment-Date: Thu, 18 Dec 2025 21:59:37 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 18, 2025, 5:52:53 PM (13 hours ago) Dec 18
    to David Baron, chromium...@chromium.org, blink-rev...@chromium.org, blink-...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Null-check computed style in SliderContainerElement::CanSlide.
    Fixed: 469831351
    Change-Id: I3e29f753169bc65ed39105f6d43b3ae8de91b6ca
    Commit-Queue: Joey Arhar <jar...@chromium.org>
    Auto-Submit: David Baron <dba...@chromium.org>
    Reviewed-by: Joey Arhar <jar...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1560843}
    Files:
    • M third_party/blink/renderer/core/html/forms/slider_thumb_element.cc
    Change size: XS
    Delta: 1 file changed, 5 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Joey Arhar
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I3e29f753169bc65ed39105f6d43b3ae8de91b6ca
    Gerrit-Change-Number: 7277172
    Gerrit-PatchSet: 2
    Gerrit-Owner: David Baron <dba...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages