[HTML] Reject leading plus sign in meter element floating-point parsing [chromium/src : main]

[Mostafa Aboalkasim (Gerrit)]

Attention needed from Kent Tamura and Kentaro Hara

Mostafa Aboalkasim added 1 comment

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Mostafa Aboalkasim . resolved

Fixed the issue and the tests that were failing before, but it interfered with two other tests. I think I handled them, I’d like your opinion on it.

Open in Gerrit

Related details

Attention is currently required from:

• Kent Tamura
• Kentaro Hara

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 5

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Kentaro Hara <har...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Mon, 11 May 2026 08:11:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Kent Tamura (Gerrit)]

Attention needed from Kentaro Hara and Mostafa Aboalkasim

Kent Tamura added 2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Kent Tamura . unresolved

Please ask review one of third_party/blink/renderer/core/html/OWNERS.

File third_party/blink/renderer/core/html/parser/html_parser_idioms.cc

Line 121, Patchset 5 (Parent): // http://www.whatwg.org/specs/web-apps/current-work/#floating-point-numbers

Kent Tamura . unresolved

So the URL should be updated to https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values , right?

Open in Gerrit

Related details

Attention is currently required from:

• Kentaro Hara
• Mostafa Aboalkasim

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• No-Unresolved-Comments

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 5

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Attention: Kentaro Hara <har...@chromium.org>

Gerrit-Comment-Date: Mon, 11 May 2026 23:39:09 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

[Mostafa Aboalkasim (Gerrit)]

Attention needed from Joey Arhar and Kent Tamura

Mostafa Aboalkasim added 2 comments

Patchset-level comments

File-level comment, Patchset 5 (Latest):

Kent Tamura . resolved

Please ask review one of third_party/blink/renderer/core/html/OWNERS.

Mostafa Aboalkasim

Done

File third_party/blink/renderer/core/html/parser/html_parser_idioms.cc

Line 121, Patchset 5 (Parent): // http://www.whatwg.org/specs/web-apps/current-work/#floating-point-numbers

Kent Tamura . resolved

So the URL should be updated to https://html.spec.whatwg.org/C/#rules-for-parsing-floating-point-number-values , right?

Mostafa Aboalkasim

I don't think we need to update it. The spec already mentions in the parsing algorithm that if a '+' appears before a number (e.g. "+100") [see point 8 here](https://html.spec.whatwg.org/multipage/common-microsyntaxes.html#rules-for-parsing-floating-point-number-values), it should be skipped and the number should still be parsed. Firefox follows the same behavior as well:
https://searchfox.org/firefox-main/source/mozglue/misc/decimal/Decimal.h#234

Open in Gerrit

Related details

Attention is currently required from:

• Joey Arhar
• Kent Tamura

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review

• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I033aad1a261eead7d8aeac3f3344efa16da7712e

Gerrit-Change-Number: 7832192

Gerrit-PatchSet: 5

Gerrit-Owner: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-Reviewer: Joey Arhar <jar...@chromium.org>

Gerrit-Reviewer: Kent Tamura <tk...@chromium.org>

Gerrit-Reviewer: Mostafa Aboalkasim <mostafa.aboal...@gmail.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: android-bu...@system.gserviceaccount.com <android-bu...@system.gserviceaccount.com>

Gerrit-CC: chromium...@chromium.org

Gerrit-Attention: Joey Arhar <jar...@chromium.org>

Gerrit-Attention: Kent Tamura <tk...@chromium.org>

Gerrit-Comment-Date: Tue, 12 May 2026 11:59:49 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: No

Comment-In-Reply-To: Kent Tamura <tk...@chromium.org>