[WIP] Reuse IntersectionObserver plumbing for iframe media pausing [chromium/src : main]

0 views

Skip to first unread message

Gabriel Brito (Gerrit)

unread,

1:43 AM (5 hours ago) 1:43 AM

to Stefan Zager, Dale Curtis, Steve Becker, Hongchan Choi, Rijubrata Bhaumik, David Bokan, chromium...@chromium.org, srirama chandra sekhar, AyeAye, Chromium LUCI CQ, blink-re...@chromium.org, tommyw+w...@chromium.org, mfoltz+wa...@chromium.org, alexmo...@chromium.org, blink-rev...@chromium.org, erickun...@chromium.org, navigation...@chromium.org, blink-revi...@chromium.org, jophba...@chromium.org, chfreme...@chromium.org, kinuko...@chromium.org, creis...@chromium.org, feature-me...@chromium.org, eric.c...@apple.com, blink-...@chromium.org

Gabriel Brito added 1 comment

Patchset-level comments

File-level comment, Patchset 8 (Latest):

Gabriel Brito . resolved

@sza...@chromium.org, @dalec...@chromium.org, @hong...@chromium.org, this is the refactor that I plan to implement to make the media-playback-while-not-visible permission policy reuse the Intersection Observer plumbing. With these code changes, the cross-origin tests pass successfully. It should fix the race conditions we observed so far. I like how the refactor look 😊

Please do not review this. I will create a CL chain to make review easier.

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages