[M141] [carousel] Fix scroll marker group data not working with inline targets [chromium/src : refs/branch-heads/7390]

0 views

Skip to first unread message

Rubber Stamper (Gerrit)

unread,

Sep 15, 2025, 2:32:32 PM (4 days ago) Sep 15

to Daniil Sakhapov, Chrome Cherry Picker, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org

Rubber Stamper voted

Bot-Commit	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Owners
Code-Review
Lint

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Sep 15, 2025, 6:54:08 PM (4 days ago) Sep 15

to Daniil Sakhapov, Chrome Cherry Picker, Rubber Stamper, AyeAye, blink-revie...@chromium.org, blink-...@chromium.org, blink-rev...@chromium.org, blink-re...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[M141] [carousel] Fix scroll marker group data not working with inline targets

Original change's description:
> [carousel] Fix scroll marker group data not working with inline targets
> 
> As those require layout to be done (lifecycle of the document should be
> kAfterPerformLayout), selecting the active scroll marker is moved to the
> snapshoting time.
> 
> Also, this CL changes LayoutBoxes to LayoutObjects in a few places to
> work with inline targets.
> 
> Fixed: 443283020
> Change-Id: I26438cf1156b2dca8cc69930371969a507a71101
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6925380
> Commit-Queue: Daniil Sakhapov <sakh...@chromium.org>
> Reviewed-by: Robert Flack <fla...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1514809}

(cherry picked from commit 75bfbaf0b923e19e6e0341c2248e158d4c26f90e)

Bug: 444673641,443283020

Change-Id: I26438cf1156b2dca8cc69930371969a507a71101

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6951432

Commit-Queue: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>

Auto-Submit: Chrome Cherry Picker <chrome-che...@chops-service-accounts.iam.gserviceaccount.com>

Cr-Commit-Position: refs/branch-heads/7390@{#994}

Cr-Branched-From: d481efce5eb300acbb896686676ebd0352a6f1db-refs/heads/main@{#1509326}

Files:

M third_party/blink/renderer/core/dom/scroll_marker_group_data.cc
M third_party/blink/renderer/core/dom/scroll_marker_group_data.h
M third_party/blink/renderer/core/html/html_anchor_element.cc
A third_party/blink/web_tests/external/wpt/css/css-overflow/scroll-target-group-inline-targets-ref.html
A third_party/blink/web_tests/external/wpt/css/css-overflow/scroll-target-group-inline-targets.html

Change size: M

Delta: 5 files changed, 106 insertions(+), 26 deletions(-)

Branch: refs/branch-heads/7390

Submit Requirements:

Code-Review: Bot-Commit+1 by Rubber Stamper

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages