Reland "[Views AX] Move accessibility strings to ui/" [chromium/src : main]

0 views
Skip to first unread message

Daniel Cheng (Gerrit)

unread,
Aug 13, 2024, 2:20:12 PM8/13/24
to Jacques Newman, Dirk Pranke, Daniel Cheng, Chromium LUCI CQ, David Dorwin, Mark Schillaci, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve, David Dorwin, Dirk Pranke, Jacques Newman and Mark Schillaci

Daniel Cheng added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Daniel Cheng . resolved

Is this ready for re-review? I'm assuming this is just a reland CL created through Gerrit but without any build fixes yet?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • David Dorwin
  • Dirk Pranke
  • Jacques Newman
  • Mark Schillaci
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic01f6499e6542102bdd79aa41c6778d1bf23c97e
Gerrit-Change-Number: 5785068
Gerrit-PatchSet: 1
Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: David Dorwin <ddo...@chromium.org>
Gerrit-Reviewer: Dirk Pranke <dpr...@google.com>
Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: David Tseng <dts...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sergey Ulanov <ser...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Attention: Dirk Pranke <dpr...@google.com>
Gerrit-Attention: David Dorwin <ddo...@chromium.org>
Gerrit-Attention: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Tue, 13 Aug 2024 18:20:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jacques Newman (Gerrit)

unread,
Aug 13, 2024, 2:25:25 PM8/13/24
to Dirk Pranke, Daniel Cheng, Chromium LUCI CQ, David Dorwin, Mark Schillaci, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org

Jacques Newman added 1 comment

Patchset-level comments
Daniel Cheng . resolved

Is this ready for re-review? I'm assuming this is just a reland CL created through Gerrit but without any build fixes yet?

Jacques Newman

Correct, this is just the reland created through Gerrit, identical to the original change with no fixes.
Just marked it as WIP so it should drop off your dashboard. I'll let you know when it is ready for review.

Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Tue, 13 Aug 2024 18:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Jacques Newman (Gerrit)

unread,
Aug 14, 2024, 7:23:39 PM8/14/24
to Tricium, Dirk Pranke, Daniel Cheng, Chromium LUCI CQ, David Dorwin, Mark Schillaci, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve, Daniel Cheng, David Dorwin, Dirk Pranke and Mark Schillaci

Jacques Newman added 1 comment

Patchset-level comments
File-level comment, Patchset 8 (Latest):
Jacques Newman . resolved

Strange to me, but it looks like the bot that runs content_browsertests on Fuchsia isn't part of the regular CI, but this was caught shortly after the original change merged. I have queued this bot when running checks for this reland CL.

Reviewers, PTAL when you get the chance, I have noted the changes from the original in the CL description.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Daniel Cheng
  • David Dorwin
  • Dirk Pranke
  • Mark Schillaci
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic01f6499e6542102bdd79aa41c6778d1bf23c97e
Gerrit-Change-Number: 5785068
Gerrit-PatchSet: 8
Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: David Dorwin <ddo...@chromium.org>
Gerrit-Reviewer: Dirk Pranke <dpr...@google.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: David Tseng <dts...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sergey Ulanov <ser...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Dirk Pranke <dpr...@google.com>
Gerrit-Attention: David Dorwin <ddo...@chromium.org>
Gerrit-Attention: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Aug 2024 23:23:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

David Dorwin (Gerrit)

unread,
Aug 14, 2024, 7:54:42 PM8/14/24
to Jacques Newman, Tricium, Dirk Pranke, Daniel Cheng, Chromium LUCI CQ, Mark Schillaci, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve, Daniel Cheng, Dirk Pranke, Jacques Newman and Mark Schillaci

David Dorwin voted and added 2 comments

Votes added by David Dorwin

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 11 (Latest):
David Dorwin . resolved

//fuchsia_web LGTM (unchanged from the original CL)

Commit Message
Line 37, Patchset 11 (Latest):Bug: 40672441
David Dorwin . unresolved

Please add 358567091 so there's a reference to this CL in the bug.

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Daniel Cheng
  • Dirk Pranke
  • Jacques Newman
  • Mark Schillaci
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic01f6499e6542102bdd79aa41c6778d1bf23c97e
Gerrit-Change-Number: 5785068
Gerrit-PatchSet: 11
Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: David Dorwin <ddo...@chromium.org>
Gerrit-Reviewer: Dirk Pranke <dpr...@google.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: David Tseng <dts...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sergey Ulanov <ser...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Attention: Dirk Pranke <dpr...@google.com>
Gerrit-Attention: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Wed, 14 Aug 2024 23:54:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dirk Pranke (Gerrit)

unread,
Aug 14, 2024, 9:06:08 PM8/14/24
to Jacques Newman, David Dorwin, Tricium, Daniel Cheng, Chromium LUCI CQ, Mark Schillaci, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve, Daniel Cheng, Jacques Newman and Mark Schillaci

Dirk Pranke voted and added 1 comment

Votes added by Dirk Pranke

Code-Review+1

1 comment

Patchset-level comments
Dirk Pranke . resolved

Are the two newly removed strings something you picked up by rebasing, or are they somehow relevant to the diffs in your patch?

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Daniel Cheng
  • Jacques Newman
  • Mark Schillaci
Gerrit-Attention: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Aug 2024 01:05:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Aug 14, 2024, 10:31:41 PM8/14/24
to Jacques Newman, Daniel Cheng, Dirk Pranke, David Dorwin, Tricium, Chromium LUCI CQ, Mark Schillaci, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve, Jacques Newman and Mark Schillaci

Daniel Cheng voted and added 1 comment

Votes added by Daniel Cheng

Code-Review+1

1 comment

Patchset-level comments
Daniel Cheng . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Jacques Newman
  • Mark Schillaci
Gerrit-Attention: Mark Schillaci <mschi...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Aug 2024 02:31:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Mark Schillaci (Gerrit)

unread,
Aug 15, 2024, 10:14:17 AM8/15/24
to Jacques Newman, Daniel Cheng, Dirk Pranke, David Dorwin, Tricium, Chromium LUCI CQ, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve and Jacques Newman

Mark Schillaci voted and added 1 comment

Votes added by Mark Schillaci

Code-Review+1

1 comment

Patchset-level comments
Mark Schillaci . resolved

LGTM!

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Jacques Newman
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Aug 2024 14:14:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Jacques Newman (Gerrit)

unread,
Aug 15, 2024, 12:32:54 PM8/15/24
to Mark Schillaci, Daniel Cheng, Dirk Pranke, David Dorwin, Tricium, Chromium LUCI CQ, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve

Jacques Newman added 2 comments

Patchset-level comments
Dirk Pranke . resolved

Are the two newly removed strings something you picked up by rebasing, or are they somehow relevant to the diffs in your patch?

Jacques Newman

These were simply missed in the original change. I was starting to put together a follow-up CL, but when this was reverted I thought it better to simply include them as well.

Commit Message
Line 37, Patchset 11:Bug: 40672441
David Dorwin . resolved

Please add 358567091 so there's a reference to this CL in the bug.

Jacques Newman

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic01f6499e6542102bdd79aa41c6778d1bf23c97e
Gerrit-Change-Number: 5785068
Gerrit-PatchSet: 12
Gerrit-Owner: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: David Dorwin <ddo...@chromium.org>
Gerrit-Reviewer: Dirk Pranke <dpr...@google.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-Reviewer: Mark Schillaci <mschi...@google.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Alex Keng <shi...@microsoft.com>
Gerrit-CC: David Tseng <dts...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-CC: Sergey Ulanov <ser...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Comment-Date: Thu, 15 Aug 2024 16:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Dirk Pranke <dpr...@google.com>
Comment-In-Reply-To: David Dorwin <ddo...@chromium.org>
satisfied_requirement
open
diffy

Jacques Newman (Gerrit)

unread,
Aug 15, 2024, 12:33:02 PM8/15/24
to Mark Schillaci, Daniel Cheng, Dirk Pranke, David Dorwin, Tricium, Chromium LUCI CQ, Andrew Grieve, David Tseng, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org
Attention needed from Andrew Grieve

Jacques Newman voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Thu, 15 Aug 2024 16:32:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Aug 15, 2024, 12:58:10 PM8/15/24
to Jacques Newman, Mark Schillaci, Daniel Cheng, Dirk Pranke, David Dorwin, Tricium, Andrew Grieve, David Tseng, Akihiro Ota, Kevin Babbitt, Alex Keng, chromium...@chromium.org, (Julie)Jeongeun Kim, Sergey Ulanov, Zijie He, AyeAye, mac-r...@chromium.org, yuzo+...@chromium.org, blink-rev...@chromium.org, fuchsia...@chromium.org, blink-re...@chromium.org, nektar...@chromium.org, josiah...@chromium.org, blink-...@chromium.org, dtseng...@chromium.org, aleventhal...@chromium.org, hirokisa...@chromium.org, abigailbk...@google.com, kyungjunle...@google.com, feature-me...@chromium.org, francisjp...@google.com, steimel+watch...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

11 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
Reland "[Views AX] Move accessibility strings to ui/"

This is a reland of commit 3b4c6a60319ab67b7ca3ebecef6f54447f296d75

The revert was needed due to failures in CrossPlatformAccessibilityBrowserTest on Fuchsia: https://ci.chromium.org/ui/p/chromium/builders/ci/fuchsia-x64-cast-receiver-dbg.
Since these tests rely on strings that are not actually packaged into Fuchsia WebEngine, I have excluded these tests on that platform.

Patchset #1 is identical to the original change
Patchset #2 has the fix to ensure these tests do not run on Fuchsia
Patchset #3 moves two strings that were not moved in the original change, IDS_AX_OBJECT_SELECTED and IDS_AX_OBJECT_NOT_SELECTED.

Original change's description:
> [Views AX] Move accessibility strings to ui/
>
> To ensure we don't break any layering rules in the move of
> BrowserAccessibility from content/ to ui/ these strings must be moved up
> so they are reachable from ui/
>
> Since this change simply moves strings around, and does not add any new ones, I will be bypassing the presubmit check to ensure that there are screenshots associated with each string.
>
> Bug: 40672441
> Change-Id: I4c17402259f7a59bd761cfc0bf020bbff31dae85
> Skip-Translation-Screenshots-Check: True
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5740105
> Commit-Queue: Jacques Newman <jane...@microsoft.com>
> Reviewed-by: Dirk Pranke <dpr...@google.com>
> Reviewed-by: Mark Schillaci <mschi...@google.com>
> Reviewed-by: David Dorwin <ddo...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1340638}
Bug: 40672441, 358567091
Change-Id: Ic01f6499e6542102bdd79aa41c6778d1bf23c97e
Skip-Translation-Screenshots-Check: True
Commit-Queue: Jacques Newman <jane...@microsoft.com>
Reviewed-by: Mark Schillaci <mschi...@google.com>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Reviewed-by: David Dorwin <ddo...@chromium.org>
Reviewed-by: Dirk Pranke <dpr...@google.com>
Cr-Commit-Position: refs/heads/main@{#1342322}
Files:
  • M content/browser/accessibility/browser_accessibility.cc
  • M content/browser/accessibility/browser_accessibility.h
  • M content/browser/accessibility/browser_accessibility_android.cc
  • M content/browser/accessibility/browser_accessibility_cocoa.mm
  • M content/browser/accessibility/cross_platform_accessibility_browsertest.cc
  • M fuchsia_web/webengine/BUILD.gn
  • M third_party/blink/public/strings/blink_strings.grd
  • M third_party/blink/public/strings/translations/blink_strings_af.xtb
  • M third_party/blink/public/strings/translations/blink_strings_am.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ar.xtb
  • M third_party/blink/public/strings/translations/blink_strings_as.xtb
  • M third_party/blink/public/strings/translations/blink_strings_az.xtb
  • M third_party/blink/public/strings/translations/blink_strings_be.xtb
  • M third_party/blink/public/strings/translations/blink_strings_bg.xtb
  • M third_party/blink/public/strings/translations/blink_strings_bn.xtb
  • M third_party/blink/public/strings/translations/blink_strings_bs.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ca.xtb
  • M third_party/blink/public/strings/translations/blink_strings_cs.xtb
  • M third_party/blink/public/strings/translations/blink_strings_cy.xtb
  • M third_party/blink/public/strings/translations/blink_strings_da.xtb
  • M third_party/blink/public/strings/translations/blink_strings_de.xtb
  • M third_party/blink/public/strings/translations/blink_strings_el.xtb
  • M third_party/blink/public/strings/translations/blink_strings_en-GB.xtb
  • M third_party/blink/public/strings/translations/blink_strings_es-419.xtb
  • M third_party/blink/public/strings/translations/blink_strings_es.xtb
  • M third_party/blink/public/strings/translations/blink_strings_et.xtb
  • M third_party/blink/public/strings/translations/blink_strings_eu.xtb
  • M third_party/blink/public/strings/translations/blink_strings_fa.xtb
  • M third_party/blink/public/strings/translations/blink_strings_fi.xtb
  • M third_party/blink/public/strings/translations/blink_strings_fil.xtb
  • M third_party/blink/public/strings/translations/blink_strings_fr-CA.xtb
  • M third_party/blink/public/strings/translations/blink_strings_fr.xtb
  • M third_party/blink/public/strings/translations/blink_strings_gl.xtb
  • M third_party/blink/public/strings/translations/blink_strings_gu.xtb
  • M third_party/blink/public/strings/translations/blink_strings_hi.xtb
  • M third_party/blink/public/strings/translations/blink_strings_hr.xtb
  • M third_party/blink/public/strings/translations/blink_strings_hu.xtb
  • M third_party/blink/public/strings/translations/blink_strings_hy.xtb
  • M third_party/blink/public/strings/translations/blink_strings_id.xtb
  • M third_party/blink/public/strings/translations/blink_strings_is.xtb
  • M third_party/blink/public/strings/translations/blink_strings_it.xtb
  • M third_party/blink/public/strings/translations/blink_strings_iw.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ja.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ka.xtb
  • M third_party/blink/public/strings/translations/blink_strings_kk.xtb
  • M third_party/blink/public/strings/translations/blink_strings_km.xtb
  • M third_party/blink/public/strings/translations/blink_strings_kn.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ko.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ky.xtb
  • M third_party/blink/public/strings/translations/blink_strings_lo.xtb
  • M third_party/blink/public/strings/translations/blink_strings_lt.xtb
  • M third_party/blink/public/strings/translations/blink_strings_lv.xtb
  • M third_party/blink/public/strings/translations/blink_strings_mk.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ml.xtb
  • M third_party/blink/public/strings/translations/blink_strings_mn.xtb
  • M third_party/blink/public/strings/translations/blink_strings_mr.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ms.xtb
  • M third_party/blink/public/strings/translations/blink_strings_my.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ne.xtb
  • M third_party/blink/public/strings/translations/blink_strings_nl.xtb
  • M third_party/blink/public/strings/translations/blink_strings_no.xtb
  • M third_party/blink/public/strings/translations/blink_strings_or.xtb
  • M third_party/blink/public/strings/translations/blink_strings_pa.xtb
  • M third_party/blink/public/strings/translations/blink_strings_pl.xtb
  • M third_party/blink/public/strings/translations/blink_strings_pt-BR.xtb
  • M third_party/blink/public/strings/translations/blink_strings_pt-PT.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ro.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ru.xtb
  • M third_party/blink/public/strings/translations/blink_strings_si.xtb
  • M third_party/blink/public/strings/translations/blink_strings_sk.xtb
  • M third_party/blink/public/strings/translations/blink_strings_sl.xtb
  • M third_party/blink/public/strings/translations/blink_strings_sq.xtb
  • M third_party/blink/public/strings/translations/blink_strings_sr-Latn.xtb
  • M third_party/blink/public/strings/translations/blink_strings_sr.xtb
  • M third_party/blink/public/strings/translations/blink_strings_sv.xtb
  • M third_party/blink/public/strings/translations/blink_strings_sw.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ta.xtb
  • M third_party/blink/public/strings/translations/blink_strings_te.xtb
  • M third_party/blink/public/strings/translations/blink_strings_th.xtb
  • M third_party/blink/public/strings/translations/blink_strings_tr.xtb
  • M third_party/blink/public/strings/translations/blink_strings_uk.xtb
  • M third_party/blink/public/strings/translations/blink_strings_ur.xtb
  • M third_party/blink/public/strings/translations/blink_strings_uz.xtb
  • M third_party/blink/public/strings/translations/blink_strings_vi.xtb
  • M third_party/blink/public/strings/translations/blink_strings_zh-CN.xtb
  • M third_party/blink/public/strings/translations/blink_strings_zh-HK.xtb
  • M third_party/blink/public/strings/translations/blink_strings_zh-TW.xtb
  • M third_party/blink/public/strings/translations/blink_strings_zu.xtb
  • M third_party/blink/renderer/core/BUILD.gn
  • M third_party/blink/renderer/core/DEPS
  • M third_party/blink/renderer/core/html/forms/color_chooser_popup_ui_controller.cc
  • M third_party/blink/renderer/core/html/forms/date_input_type.cc
  • M third_party/blink/renderer/core/html/forms/date_time_chooser_impl.cc
  • M third_party/blink/renderer/core/html/forms/date_time_field_elements.cc
  • M third_party/blink/renderer/core/html/forms/date_time_local_input_type.cc
  • M third_party/blink/renderer/core/html/forms/month_input_type.cc
  • M third_party/blink/renderer/core/html/forms/time_input_type.cc
  • M third_party/blink/renderer/core/html/forms/week_input_type.cc
  • M third_party/blink/renderer/core/page/page_popup_controller.cc
  • M third_party/blink/renderer/modules/BUILD.gn
  • M third_party/blink/renderer/modules/media_controls/BUILD.gn
  • M third_party/blink/renderer/modules/media_controls/DEPS
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_cast_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_display_cutout_fullscreen_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_display_cutout_fullscreen_button_element_test.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_download_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_fullscreen_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_input_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_loading_panel_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_mute_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_overflow_menu_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_overlay_play_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_picture_in_picture_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_play_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_playback_speed_button_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_playback_speed_list_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_text_track_list_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_timeline_element.cc
  • M third_party/blink/renderer/modules/media_controls/elements/media_control_toggle_closed_captions_button_element.cc
  • M ui/accessibility/BUILD.gn
  • M ui/accessibility/platform/ax_platform_node_delegate.h
  • M ui/strings/ax_strings.grd
  • R ui/strings/ax_strings_grd/IDS_AX_ARIA_CURRENT_DATE.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_ARIA_CURRENT_LOCATION.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_ARIA_CURRENT_PAGE.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_ARIA_CURRENT_STEP.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_ARIA_CURRENT_TIME.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_ARIA_CURRENT_TRUE.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_ARIA_REQUIRED_STATE_DESCRIPTION.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_CHECKBOX_PARTIALLY_CHECKED.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_COLOR_EYEDROPPER.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_COMBOBOX_EXPANDED.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_COMBOBOX_EXPANDED_AUTOCOMPLETE_DEFAULT.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_COMBOBOX_EXPANDED_AUTOCOMPLETE_X_OPTIONS_AVAILABLE.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_COMBOBOX_EXPANDED_DIALOG.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_DIALOG_MODAL_OPENED.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_INDETERMINATE_VALUE.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_MEDIA_BACK_TO_OPTIONS_BUTTON.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_MEDIA_SHOW_AUDIO_DESCRIPTIONS_MENU_BUTTON.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_MEDIA_SHOW_PLAYBACK_SPEED_MENU_BUTTON.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_MULTISELECTABLE_STATE_DESCRIPTION.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_MULTISELECTABLE_STATE_DESCRIPTION_NONE.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_RADIO_BUTTON_STATE_DESCRIPTION_CHECKED.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_RADIO_BUTTON_STATE_DESCRIPTION_UNCHECKED.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_TOGGLE_BUTTON_OFF.png.sha1
  • R ui/strings/ax_strings_grd/IDS_AX_TOGGLE_BUTTON_ON.png.sha1
  • M ui/strings/translations/ax_strings_af.xtb
  • M ui/strings/translations/ax_strings_am.xtb
  • M ui/strings/translations/ax_strings_ar.xtb
  • M ui/strings/translations/ax_strings_as.xtb
  • M ui/strings/translations/ax_strings_az.xtb
  • M ui/strings/translations/ax_strings_be.xtb
  • M ui/strings/translations/ax_strings_bg.xtb
  • M ui/strings/translations/ax_strings_bn.xtb
  • M ui/strings/translations/ax_strings_bs.xtb
  • M ui/strings/translations/ax_strings_ca.xtb
  • M ui/strings/translations/ax_strings_cs.xtb
  • M ui/strings/translations/ax_strings_cy.xtb
  • M ui/strings/translations/ax_strings_da.xtb
  • M ui/strings/translations/ax_strings_de.xtb
  • M ui/strings/translations/ax_strings_el.xtb
  • M ui/strings/translations/ax_strings_en-GB.xtb
  • M ui/strings/translations/ax_strings_es-419.xtb
  • M ui/strings/translations/ax_strings_es.xtb
  • M ui/strings/translations/ax_strings_et.xtb
  • M ui/strings/translations/ax_strings_eu.xtb
  • M ui/strings/translations/ax_strings_fa.xtb
  • M ui/strings/translations/ax_strings_fi.xtb
  • M ui/strings/translations/ax_strings_fil.xtb
  • M ui/strings/translations/ax_strings_fr-CA.xtb
  • M ui/strings/translations/ax_strings_fr.xtb
  • M ui/strings/translations/ax_strings_gl.xtb
  • M ui/strings/translations/ax_strings_gu.xtb
  • M ui/strings/translations/ax_strings_hi.xtb
  • M ui/strings/translations/ax_strings_hr.xtb
  • M ui/strings/translations/ax_strings_hu.xtb
  • M ui/strings/translations/ax_strings_hy.xtb
  • M ui/strings/translations/ax_strings_id.xtb
  • M ui/strings/translations/ax_strings_is.xtb
  • M ui/strings/translations/ax_strings_it.xtb
  • M ui/strings/translations/ax_strings_iw.xtb
  • M ui/strings/translations/ax_strings_ja.xtb
  • M ui/strings/translations/ax_strings_ka.xtb
  • M ui/strings/translations/ax_strings_kk.xtb
  • M ui/strings/translations/ax_strings_km.xtb
  • M ui/strings/translations/ax_strings_kn.xtb
  • M ui/strings/translations/ax_strings_ko.xtb
  • M ui/strings/translations/ax_strings_ky.xtb
  • M ui/strings/translations/ax_strings_lo.xtb
  • M ui/strings/translations/ax_strings_lt.xtb
  • M ui/strings/translations/ax_strings_lv.xtb
  • M ui/strings/translations/ax_strings_mk.xtb
  • M ui/strings/translations/ax_strings_ml.xtb
  • M ui/strings/translations/ax_strings_mn.xtb
  • M ui/strings/translations/ax_strings_mr.xtb
  • M ui/strings/translations/ax_strings_ms.xtb
  • M ui/strings/translations/ax_strings_my.xtb
  • M ui/strings/translations/ax_strings_ne.xtb
  • M ui/strings/translations/ax_strings_nl.xtb
  • M ui/strings/translations/ax_strings_no.xtb
  • M ui/strings/translations/ax_strings_or.xtb
  • M ui/strings/translations/ax_strings_pa.xtb
  • M ui/strings/translations/ax_strings_pl.xtb
  • M ui/strings/translations/ax_strings_pt-BR.xtb
  • M ui/strings/translations/ax_strings_pt-PT.xtb
  • M ui/strings/translations/ax_strings_ro.xtb
  • M ui/strings/translations/ax_strings_ru.xtb
  • M ui/strings/translations/ax_strings_si.xtb
  • M ui/strings/translations/ax_strings_sk.xtb
  • M ui/strings/translations/ax_strings_sl.xtb
  • M ui/strings/translations/ax_strings_sq.xtb
  • M ui/strings/translations/ax_strings_sr-Latn.xtb
  • M ui/strings/translations/ax_strings_sr.xtb
  • M ui/strings/translations/ax_strings_sv.xtb
  • M ui/strings/translations/ax_strings_sw.xtb
  • M ui/strings/translations/ax_strings_ta.xtb
  • M ui/strings/translations/ax_strings_te.xtb
  • M ui/strings/translations/ax_strings_th.xtb
  • M ui/strings/translations/ax_strings_tr.xtb
  • M ui/strings/translations/ax_strings_uk.xtb
  • M ui/strings/translations/ax_strings_ur.xtb
  • M ui/strings/translations/ax_strings_uz.xtb
  • M ui/strings/translations/ax_strings_vi.xtb
  • M ui/strings/translations/ax_strings_zh-CN.xtb
  • M ui/strings/translations/ax_strings_zh-HK.xtb
  • M ui/strings/translations/ax_strings_zh-TW.xtb
  • M ui/strings/translations/ax_strings_zu.xtb
Change size: XL
Delta: 227 files changed, 2817 insertions(+), 2771 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng, +1 by Mark Schillaci, +1 by David Dorwin, +1 by Dirk Pranke
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic01f6499e6542102bdd79aa41c6778d1bf23c97e
Gerrit-Change-Number: 5785068
Gerrit-PatchSet: 13
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages