Reland "[canvas] Use synthetic timer when hidden on mac" [chromium/src : main]

0 views
Skip to first unread message

Frank Liberato (Gerrit)

unread,
Apr 16, 2024, 5:20:28 PMApr 16
to Francois Pierre Doray, Chromium LUCI CQ, Justin Novosad, Tricium, Dirk Schulze, chromium...@chromium.org, Stephen Chenney, AyeAye, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, jmedle...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org

Frank Liberato abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I3efadf5bb9665fbc773bc507b56a81292d03b7ed
Gerrit-Change-Number: 5458845
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Liberato <libe...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Frank Liberato (Gerrit)

unread,
Apr 16, 2024, 5:20:28 PMApr 16
to Francois Pierre Doray, Chromium LUCI CQ, Justin Novosad, Tricium, Dirk Schulze, chromium...@chromium.org, Stephen Chenney, AyeAye, blink-...@chromium.org, jmedle...@chromium.org, blink-reviews-p...@chromium.org, fserb...@chromium.org, blink-rev...@chromium.org, kinuko...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org

Frank Liberato abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic91daadb27b7c248f09a2e3fb31aa1fca3d164ba
Gerrit-Change-Number: 5458143
satisfied_requirement
unsatisfied_requirement
open
diffy

Frank Liberato (Gerrit)

unread,
Apr 16, 2024, 5:20:28 PMApr 16
to Francois Pierre Doray, Chromium LUCI CQ, Justin Novosad, Tricium, Dirk Schulze, chromium...@chromium.org, Stephen Chenney, AyeAye, kinuko...@chromium.org, blink-rev...@chromium.org, drott+bl...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, blink-reviews-p...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org

Frank Liberato abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ic4b2e32990c9054498b7bf9371f7186efa657205
Gerrit-Change-Number: 5459102
satisfied_requirement
unsatisfied_requirement
open
diffy

Frank Liberato (Gerrit)

unread,
Apr 16, 2024, 5:27:05 PMApr 16
to Francois Pierre Doray, Chromium LUCI CQ, Justin Novosad, Tricium, Dirk Schulze, chromium...@chromium.org, Stephen Chenney, AyeAye, blink-...@chromium.org, blink-reviews-p...@chromium.org, kinuko...@chromium.org, drott+bl...@chromium.org, fserb...@chromium.org, fmalit...@chromium.org, jmedle...@chromium.org, blink-rev...@chromium.org
Attention needed from Francois Pierre Doray and Justin Novosad

Frank Liberato voted and added 1 comment

Votes added by Frank Liberato

Code-Review-1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Frank Liberato . resolved

i have no idea what's going on with this CL. PS2 looks nothing like PS2 on my local machine...

-fl

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
  • Justin Novosad
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is blockingCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I87960544bb6ede9cc2ee4b5fac357eb43845715f
Gerrit-Change-Number: 5458844
Gerrit-PatchSet: 2
Gerrit-Owner: Frank Liberato <libe...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Frank Liberato <libe...@chromium.org>
Gerrit-Reviewer: Justin Novosad <ju...@chromium.org>
Gerrit-CC: Dirk Schulze <dsch...@chromium.org>
Gerrit-CC: Stephen Chenney <sche...@chromium.org>
Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Justin Novosad <ju...@chromium.org>
Gerrit-Comment-Date: Tue, 16 Apr 2024 21:26:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
blocking_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages