Simplify CanvasSnapshotProvider management across callers [chromium/src : main]

0 views

Skip to first unread message

Dale Curtis (Gerrit)

unread,

Dec 18, 2025, 9:04:10 PM (10 hours ago) Dec 18

to ccameron chromium, Colin Blundell, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, CJ DiMeglio, Stephen Chenney, srirama chandra sekhar, eme-r...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Attention needed from Colin Blundell and ccameron chromium

Dale Curtis added 3 comments

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Dale Curtis . unresolved

WDYT?

File third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc

Line 8875, Patchset 1 (Parent): if (snapshot_provider->Size() != size ||

Dale Curtis . resolved

There's a minor change here: We'll now check CanvasSnapshotProvider::IsValid() before trying to reuse the provider.

File third_party/blink/renderer/platform/graphics/video_frame_image_util.cc

Line 44, Patchset 1 (Parent): if (!raster_context_provider)

Dale Curtis . resolved

Minor change: Flipped trivial check above the more expensive check.

Open in Gerrit

Related details

Attention is currently required from:

Colin Blundell
ccameron chromium

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

AI Code Reviewer (Gerrit)

unread,

Dec 18, 2025, 9:06:56 PM (10 hours ago) Dec 18

to Dale Curtis, ccameron chromium, Colin Blundell, Chromium LUCI CQ, AyeAye, chromium...@chromium.org, Dirk Schulze, CJ DiMeglio, Stephen Chenney, srirama chandra sekhar, eme-r...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, drott+bl...@chromium.org, eric.c...@apple.com, feature-me...@chromium.org, fmalit...@chromium.org, fserb...@chromium.org, kinuko...@chromium.org

Attention needed from Colin Blundell and ccameron chromium

AI Code Reviewer added 1 comment

File third_party/blink/renderer/platform/graphics/video_frame_image_util.h

Line 99, Patchset 3 (Latest): bool reinterpret_video_as_srgb = false);

AI Code Reviewer . unresolved

Blink Style Guide: Prefer enums or StrongAliases to bare bools for function parameters. To improve readability at call sites, consider using a base::StrongAlias<class ReinterpretVideoAsSrgbTag, bool> or an enum for the 'reinterpret_video_as_srgb' parameter.

To keep this interaction as brief and non-intrusive as possible, please consider responding with one of following options:
**Done** | **OK But Won't Fix**: reason | **Later**: b/<bug_id> | **Invalid:** reason

_This comment was generated by [Experimental Blink C++ Code Review Agent](http://go/blink-c++-code-review-agent)._
_AI reviews can sometimes be inaccurate; We appreciate your 🙏 feedback 🙏 to help us improve._
_[File a bug](http://go/blink-c++-code-review-agent-feedback) | [Provide feedback on chat](https://chat.google.com/room/AAQA0zhQHe0?cls=4) | [Opt-out](https://ganpati2.corp.google.com/group/peep-genai-blink-agent-optout.prod)_