Lei Zhang (Gerrit)

unread,

Dec 9, 2025, 11:53:47 AM (3 days ago) Dec 9

to Lei Zhang, Mark Mentovai, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Nikhil Nayunigari, Permissions Reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Wang, Wei4, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, ajayramamurth...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, cros-print...@google.com, cros-report...@google.com, dclasson+w...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, pushi+watc...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-b...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tommyw+w...@chromium.org, torne...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Mark Mentovai

Lei Zhang added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Lei Zhang . resolved

Please OO+1.

Open in Gerrit

Related details

Attention is currently required from:

Mark Mentovai

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mark Mentovai (Gerrit)

unread,

11:32 AM (8 hours ago) 11:32 AM

to Lei Zhang, Code Review Nudger, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Nikhil Nayunigari, Permissions Reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Wang, Wei4, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, ajayramamurth...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, cros-print...@google.com, cros-report...@google.com, dclasson+w...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, pushi+watc...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-b...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tommyw+w...@chromium.org, torne...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Attention needed from Lei Zhang

Mark Mentovai voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

Lei Zhang

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

11:59 AM (8 hours ago) 11:59 AM

to Lei Zhang, Mark Mentovai, Code Review Nudger, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Nikhil Nayunigari, Permissions Reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Wang, Wei4, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, ajayramamurth...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, cros-print...@google.com, cros-report...@google.com, dclasson+w...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, pushi+watc...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-b...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tommyw+w...@chromium.org, torne...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

1:04 PM (7 hours ago) 1:04 PM

to Lei Zhang, Mark Mentovai, Code Review Nudger, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Nikhil Nayunigari, Permissions Reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Wang, Wei4, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, ajayramamurth...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, cros-print...@google.com, cros-report...@google.com, dclasson+w...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, pushi+watc...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-b...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tommyw+w...@chromium.org, torne...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

2:11 PM (6 hours ago) 2:11 PM

to Lei Zhang, Mark Mentovai, Code Review Nudger, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Nikhil Nayunigari, Permissions Reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Wang, Wei4, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, ajayramamurth...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, cros-print...@google.com, cros-report...@google.com, dclasson+w...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, pushi+watc...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-b...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tommyw+w...@chromium.org, torne...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

satisfied_requirement

open

diffy

Lei Zhang (Gerrit)

unread,

7:15 PM (1 hour ago) 7:15 PM

to Lei Zhang, Mark Mentovai, Code Review Nudger, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Nikhil Nayunigari, Permissions Reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Wang, Wei4, AyeAye Python Dispatcher, Chromium LUCI CQ, abigailbk...@google.com, agriev...@chromium.org, ajayramamurth...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, cros-print...@google.com, cros-report...@google.com, dclasson+w...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, pushi+watc...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-b...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tommyw+w...@chromium.org, torne...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Lei Zhang voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

7:18 PM (1 hour ago) 7:18 PM

to Lei Zhang, Mark Mentovai, Code Review Nudger, Akihiro Ota, Menard, Alexis, Arnaud Mandy, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Dirk Schulze, Enterprise Policy Reviews, Olga Gerchikov, Andrew Rayskiy, Kaan Icer, Nate Chapin, (Julie)Jeongeun Kim, Kevin Babbitt, Kenneth R Christiansen, Nikhil Nayunigari, Permissions Reviews, Rijubrata Bhaumik, Stephen Chenney, Simon Hangl, Wang, Wei4, AyeAye Python Dispatcher, abigailbk...@google.com, agriev...@chromium.org, ajayramamurth...@google.com, ajayramamurthy...@google.com, ajayramamurth...@google.com, alexmo...@chromium.org, andysjl...@chromium.org, apavlo...@chromium.org, armalhotra+a...@google.com, asvitki...@chromium.org, bhartmire+w...@google.com, blink-rev...@chromium.org, blink-re...@chromium.org, blink-revi...@chromium.org, blink-rev...@chromium.org, blink-reviews-p...@chromium.org, blink-...@chromium.org, borealis-re...@google.com, browser-comp...@chromium.org, cc-...@chromium.org, chadduffin+w...@chromium.org, chfreme...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromium-a...@chromium.org, chromiumme...@microsoft.com, creis...@chromium.org, crisrael+w...@google.com, crisrael+wa...@google.com, cros-print...@google.com, cros-report...@google.com, dclasson+w...@google.com, derinel+wat...@google.com, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+wa...@chromium.org, dmurph+watc...@chromium.org, drott+bl...@chromium.org, druber...@chromium.org, dtseng...@chromium.org, edgesto...@microsoft.com, ejcaruso+wa...@chromium.org, eme-r...@chromium.org, enne...@chromium.org, estali...@chromium.org, extension...@chromium.org, feature-me...@chromium.org, fmalit...@chromium.org, francisjp...@google.com, fserb...@chromium.org, gavinp...@chromium.org, gcasto+w...@chromium.org, glazuno...@chromium.org, grt+...@chromium.org, hais+wat...@google.com, hansberry+w...@chromium.org, hansberry+wa...@chromium.org, hansberry+w...@chromium.org, hansenmichael...@google.com, hsuregan+wa...@chromium.org, jackshira+w...@google.com, jackshira+w...@google.com, jackshira+wa...@google.com, jackshira+w...@google.com, jasonrhee+w...@google.com, jdonnel...@chromium.org, jiajunz+wa...@google.com, joeantonetti+...@google.com, jonmann+wa...@chromium.org, jonmann+wat...@chromium.org, jophba...@chromium.org, josiah...@chromium.org, khorimoto+w...@chromium.org, kinuko...@chromium.org, kuragin+web-ap...@chromium.org, kyungjunle...@google.com, lizeb...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, loyso...@chromium.org, lucasrada...@google.com, mfoltz+wa...@chromium.org, mgiuca...@chromium.org, mickeybu...@chromium.org, mpdento...@chromium.org, navigation...@chromium.org, nektar...@chromium.org, net-r...@chromium.org, npm+...@chromium.org, nwoked...@chromium.org, nyquis...@chromium.org, omnibox-...@chromium.org, osaul+aut...@google.com, oshima...@chromium.org, pasko...@chromium.org, performance-m...@chromium.org, philli...@chromium.org, print-rev...@chromium.org, pushi+wat...@google.com, pushi+watc...@google.com, rmcelra...@chromium.org, roblia...@chromium.org, rrsilva+wat...@google.com, scheduler-b...@chromium.org, shgar+aut...@google.com, siashah+au...@chromium.org, siyua+aut...@chromium.org, sky+...@chromium.org, stevenjb+wa...@chromium.org, storage...@chromium.org, suetfei+wa...@google.com, tommyw+w...@chromium.org, torne...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, vinnypersky+...@google.com, webap...@microsoft.com, webauthn...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, xlythe+wa...@google.com, yfriedm...@chromium.org, yigu+...@chromium.org, yuzo+...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Unreviewed changes

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:

Do IWYU for FRIEND_TEST_ALL_PREFIXES() in headers

Headers that use FRIEND_TEST_ALL_PREFIXES() should include
gtest_prod_util.h. This CL is mostly automated with:

git grep -l FRIEND_TEST_ALL_PREFIXES | grep '\.h$' | \
  xargs grep -L gtest_prod_util.h | \
  xargs ./tools/add_header.py --header '"base/gtest_prod_util.h"'

Change-Id: Ib935a070b590c57030d7a9589d1ba6717ad46291

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7240633

Commit-Queue: Lei Zhang <the...@chromium.org>

Reviewed-by: Mark Mentovai <ma...@chromium.org>

Owners-Override: Mark Mentovai <ma...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1558348}

Files:

M ash/app_list/model/app_list_item.h
M ash/capture_mode/capture_mode_menu_group.h
M ash/capture_mode/stop_recording_button_tray.h
M ash/quick_pair/fast_pair_handshake/async_fast_pair_handshake_lookup_impl.h
M ash/root_window_controller.h
M ash/shelf/login_shelf_button.h
M ash/system/lock_screen_notification_controller.h
M ash/system/palette/stylus_battery_delegate.h
M ash/system/palette/stylus_battery_view.h
M ash/system/phonehub/onboarding_nudge_controller.h
M ash/system/unified/user_chooser_view.h
M ash/wm/overview/birch/coral_chip_button.h
M ash/wm/overview/birch/tab_app_selection_view.h
M ash/wm/overview/overview_item.h
M ash/wm/overview/overview_session.h
M ash/wm/window_restore/informed_restore_contents_view.h
M base/android/pre_freeze_background_memory_trimmer.h
M base/android/self_compaction_manager.h
M cc/animation/scroll_offset_animation_curve.h
M cc/paint/display_item_list.h
M chrome/browser/accessibility/soda_installer_impl.h
M chrome/browser/android/locale/locale_template_url_loader.h
M chrome/browser/android/omnibox/chrome_omnibox_navigation_observer_android.h
M chrome/browser/ash/borealis/borealis_survey_handler.h
M chrome/browser/ash/lobster/announcement_view.h
M chrome/browser/ash/policy/skyvault/drive_upload_observer.h
M chrome/browser/ash/policy/skyvault/skyvault_rename_handler.h
M chrome/browser/auxiliary_search/auxiliary_search_top_site_provider_bridge.h
M chrome/browser/extensions/api/printing/printing_api_handler.h
M chrome/browser/facilitated_payments/ui/android/facilitated_payments_controller.h
M chrome/browser/login_detection/login_detection_tab_helper.h
M chrome/browser/media/webrtc/multi_capture/multi_capture_data_service.h
M chrome/browser/media/webrtc/multi_capture/multi_capture_usage_indicator_service.h
M chrome/browser/navigation_predictor/search_engine_preconnector.h
M chrome/browser/page_image_service/android/image_service_bridge.h
M chrome/browser/performance_manager/user_tuning/cpu_health_tracker.h
M chrome/browser/permissions/one_time_permissions_tracker.h
M chrome/browser/picture_in_picture/auto_picture_in_picture_safe_browsing_checker_client.h
M chrome/browser/picture_in_picture/auto_picture_in_picture_tab_helper.h
M chrome/browser/policy/messaging_layer/upload/encrypted_reporting_client.h
M chrome/browser/safe_browsing/extension_telemetry/extension_telemetry_service.h
M chrome/browser/safe_browsing/notification_telemetry/notification_telemetry_service.h
M chrome/browser/safe_browsing/safe_browsing_pref_change_handler.h
M chrome/browser/safe_browsing/safe_browsing_service.h
M chrome/browser/safe_browsing/tailored_security/chrome_tailored_security_service.h
M chrome/browser/safe_browsing/tailored_security/consented_message_android.h
M chrome/browser/signin/bound_session_credentials/bound_session_refresh_cookie_fetcher_impl.h
M chrome/browser/ui/ash/input_method/announcement_view.h
M chrome/browser/ui/privacy_sandbox/privacy_sandbox_prompt_helper.h
M chrome/browser/ui/safety_hub/abusive_notification_permissions_manager.h
M chrome/browser/ui/safety_hub/disruptive_notification_permissions_manager.h
M chrome/browser/ui/safety_hub/menu_notification.h
M chrome/browser/ui/safety_hub/notification_permission_review_result.h
M chrome/browser/ui/safety_hub/password_status_check_service.h
M chrome/browser/ui/safety_hub/unused_site_permissions_manager.h
M chrome/browser/ui/tabs/saved_tab_groups/collaboration_messaging_observer.h
M chrome/browser/ui/views/bookmarks/saved_tab_groups/saved_tab_group_button.h
M chrome/browser/ui/views/find_bar_view.h
M chrome/browser/ui/views/frame/layout/browser_view_layout_impl_old.h
M chrome/browser/ui/views/omnibox/omnibox_popup_view_views.h
M chrome/browser/ui/views/omnibox/omnibox_popup_view_webui.h
M chrome/browser/ui/views/omnibox/omnibox_result_view.h
M chrome/browser/ui/views/page_action/collaboration_messaging_page_action_icon_view.h
M chrome/browser/ui/views/permissions/chip/chip_controller.h
M chrome/browser/ui/views/profiles/batch_upload_dialog_view.h
M chrome/browser/ui/views/tabs/tab_group_header.h
M chrome/browser/ui/views/tabs/tab_hover_card_bubble_view.h
M chrome/browser/ui/views/toolbar/reload_button.h
M chrome/browser/ui/views/webid/account_selection_bubble_view.h
M chrome/browser/ui/views/webid/fedcm_account_selection_view_desktop.h
M chrome/browser/ui/webui/ash/cloud_upload/drive_upload_handler.h
M chrome/browser/ui/webui/browser_command/browser_command_handler.h
M chrome/browser/ui/webui/cr_components/searchbox/contextual_searchbox_handler.h
M chrome/browser/ui/webui/cr_components/searchbox/searchbox_handler.h
M chrome/browser/ui/webui/history/foreign_session_handler.h
M chrome/browser/ui/webui/settings/glic_handler.h
M chrome/browser/ui/webui/settings/performance_handler.h
M chrome/browser/ui/webui/settings/saved_info_handler.h
M chrome/browser/ui/webui/signin/history_sync_optin_service.h
M chrome/browser/ui/webui/signin/managed_user_profile_notice_handler.h
M chrome/browser/ui/webui/whats_new/whats_new_handler.h
M chrome/browser/web_applications/isolated_web_apps/install/isolated_web_app_installation_manager.h
M chrome/browser/webauthn/authenticator_request_dialog_controller.h
M chrome/installer/util/install_service_work_item_impl.h
M chrome/services/sharing/nearby/nearby_presence.h
M chrome/updater/util/progress_sampler.h
M chromeos/ash/components/network/metrics/default_network_metrics_logger.h
M chromeos/ash/components/tether/secure_channel_tether_availability_operation_orchestrator.h
M components/autofill/core/browser/payments/save_and_fill_manager_impl.h
M components/browsing_topics/browsing_topics_service_impl.h
M components/component_updater/installer_policies/tpcd_metadata_component_installer_policy.h
M components/facilitated_payments/content/browser/content_facilitated_payments_driver_factory.h
M components/facilitated_payments/core/browser/network_api/get_details_for_pix_account_linking_request.h
M components/gwp_asan/client/lightweight_detector/random_eviction_quarantine.h
M components/history/core/browser/history_service.h
M components/js_injection/browser/navigation_web_message_sender.h
M components/live_caption/views/caption_bubble.h
M components/metrics/private_metrics/puma_service.h
M components/persistent_cache/sqlite/sqlite_backend_impl.h
M components/safe_browsing/content/browser/client_side_detection_feature_cache.h
M components/safe_browsing/content/browser/ui_manager.h
M components/search_engines/android/template_url_service_android.h
M components/visitedlink/browser/partitioned_visitedlink_writer.h
M components/viz/service/input/fling_scheduler_android.h
M content/browser/android/overscroll_controller_android.h
M content/browser/devtools/shared_storage_worklet_devtools_agent_host.h
M content/browser/fenced_frame/fenced_frame_config.h
M content/browser/indexed_db/instance/backing_store_pre_close_task_queue.h
M content/browser/loader/keep_alive_url_loader.h
M content/browser/media/capture/desktop_capture_device.h
M content/browser/media/webaudio/audio_context_manager_impl.h
M content/browser/renderer_host/code_cache_host_impl.h
M content/browser/renderer_host/navigation_request.h
M content/browser/renderer_host/spare_render_process_host_manager_impl.h
M content/browser/scheduler/browser_task_executor.h
M extensions/browser/api/storage/storage_api.h
M extensions/common/manifest_handler_registry.h
M gpu/command_buffer/service/shared_image/gl_ozone_image_representation.h
M gpu/command_buffer/service/shared_image/ozone_image_backing.h
M media/cdm/cdm_adapter.h
M net/cookies/canonical_cookie.h
M net/socket/ssl_client_socket_impl.h
M sandbox/policy/win/sandbox_win.h
M services/device/compute_pressure/probes_manager.h
M services/device/geolocation/location_provider_manager.h
M services/preferences/tracked/pref_hash_filter.h
M third_party/blink/renderer/core/css/style_recalc_context.h
M third_party/blink/renderer/core/frame/cached_permission_status.h
M third_party/blink/renderer/core/html/fenced_frame/fenced_frame_config.h
M third_party/blink/renderer/core/html/html_geolocation_element.h
M third_party/blink/renderer/core/html/html_permission_element.h
M third_party/blink/renderer/modules/accessibility/ax_object.h
M third_party/blink/renderer/modules/canvas/canvas2d/canvas_rendering_context_2d.h
M third_party/blink/renderer/modules/mediastream/webaudio_media_stream_audio_sink.h
M third_party/blink/renderer/platform/fonts/shaping/shape_result_cursor.h
M third_party/blink/renderer/platform/fonts/shaping/shape_result_run.h
M third_party/blink/renderer/platform/loader/fetch/resource.h
M third_party/blink/renderer/platform/text/character_break_iterator.h
M third_party/blink/renderer/platform/text/text_break_iterator.h
M ui/accessibility/platform/ax_platform_node_win.h
M ui/base/accelerators/global_accelerator_listener/global_accelerator_listener_linux.h
M ui/display/win/screen_win.h
M ui/views/accessibility/view_accessibility.h

Change size: M

Delta: 143 files changed, 146 insertions(+), 3 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Mark Mentovai

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

Do IWYU for FRIEND_TEST_ALL_PREFIXES() in headers [chromium/src : main]

Lei Zhang (Gerrit)

Lei Zhang added 1 comment

Related details

Mark Mentovai (Gerrit)

Mark Mentovai voted

Related details

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Lei Zhang (Gerrit)

Lei Zhang (Gerrit)

Lei Zhang (Gerrit)

Lei Zhang voted Commit-Queue+2

Related details

Chromium LUCI CQ (Gerrit)

Chromium LUCI CQ submitted the change

Unreviewed changes

Change information